apply suggestions

front/components/editor/CourtPlayer.tsx

@@ -24,8 +24,8 @@ export default function CourtPlayer({
 }: PlayerProps) {
     const pieceRef = useRef<HTMLDivElement>(null)
 
-    const [x, setX] = useState(player.rightRatio)
-    const [y, setY] = useState(player.bottomRatio)
+    const x = player.rightRatio
+    const y = player.bottomRatio
 
     return (
         <Draggable
@@ -39,9 +39,6 @@ export default function CourtPlayer({
 
                 const { x, y } = calculateRatio(pieceBounds, parentBounds)
 
-                setX(x)
-                setY(y)
-
                 onChange({
                     rightRatio: x,
                     bottomRatio: y,

front/views/Editor.tsx

@@ -132,7 +132,7 @@ function EditorView({
                         default_value={name}
                         on_validated={(new_name) => {
                             onNameChange(new_name).then((success) => {
-                                success ? setStyle({}) : setStyle(ERROR_STYLE)
+                                setStyle(success ? {} : ERROR_STYLE)
                             })
                         }}
                     />
@@ -239,7 +239,7 @@ function useContentState<S>(
             }
             return state
         })
-    }, [])
+    }, [saveStateCallback])
 
     return [content, setContentSynced, savingState]
 }

src/Api/Controller/APITacticController.php

@@ -57,7 +57,7 @@ class APITacticController {
             "content" => [],
         ], function (HttpRequest $req) use ($id) {
             if ($fail = $this->model->updateContent($id, json_encode($req["content"]))) {
-                return new JsonHttpResponse([$fail]);
+                return new JsonHttpResponse([$fail], HttpCodes::BAD_REQUEST);
             }
             return HttpResponse::fromCode(HttpCodes::OK);
         });