apply suggestions

src/Controller/AuthController.php

@@ -26,37 +26,37 @@ class AuthController {
         return ViewHttpResponse::twig("display_register.html.twig", []);
     }
 
-    private function displayRegisterBadFields(array $fails): HttpResponse{
+    private function displayBadFields(string $viewName, array $fails): HttpResponse{
         $bad_fields = [];
         foreach ($fails as $err) {
             if ($err instanceof FieldValidationFail) {
                 $bad_fields[] = $err->getFieldName();
             }
         }
-        return ViewHttpResponse::twig("display_register.html.twig", ['bad_fields' => $bad_fields]);
+        return ViewHttpResponse::twig($viewName, ['bad_fields' => $bad_fields]);
     }
     public function confirmRegister(array $request): HttpResponse {
 
         $fails = [];
         $request = HttpRequest::from($request, $fails, [
-            "username" => [Validators::name(), Validators::lenBetween(0, 32)],
+            "username" => [Validators::name(), Validators::lenBetween(2, 32)],
             "password" => [Validators::lenBetween(6, 256)],
             "confirmpassword" => [Validators::lenBetween(6, 256)],
-            "email" => [Validators::regex("/^[\w-\.]+@([\w-]+\.)+[\w-]{2,4}$/g"),Validators::lenBetween(5, 256)]
+            "email" => [Validators::regex("/^\\S+@\\S+\\.\\S+$/"),Validators::lenBetween(5, 256)]
         ]);
 
 
         if (!empty($fails)) {
-            return $this->displayRegisterBadFields($fails);
+            return $this->displayBadFields("display_register.html.twig",$fails);
         }
 
-        $fails = $this->model->validationRegister($request['username'], $request["password"], $request['confirmpassword'], $request['email']);
+        $fails = $this->model->register($request['username'], $request["password"], $request['confirmpassword'], $request['email']);
         if (empty($fails)) {
             $results = $this->model->getUserFields($request['email']);
             return ViewHttpResponse::twig("display_auth_confirm.html.twig", ['username' => $results['username'], 'email' => $results['email']]);
         }
 
-        return $this->displayRegisterBadFields($fails);
+        return $this->displayBadFields("display_register.html.twig",$fails);
     }
 
     public function displayLogin():HttpResponse{
@@ -66,18 +66,18 @@ class AuthController {
     public function displayLoginPassed(array $request):HttpResponse{
         $fails = [];
         $request = HttpRequest::from($request, $fails, [
-            "password" => [Validators::lenBetween(0, 256)],
-            "email" => [Validators::regex("/@/")]
+            "password" => [Validators::lenBetween(6, 256)],
+            "email" => [Validators::regex("/^\\S+@\\S+\\.\\S+$/"),Validators::lenBetween(5, 256)]
         ]);
 
 
-        $fails = $this->model->validationLogin($request['email'],$request['password']);
+        $fails = $this->model->login($request['email'],$request['password']);
 
         if (empty($fails)){
             $results = $this->model->getUserFields($request['email']);
             return ViewHttpResponse::twig("display_auth_confirm.html.twig",['username' => $results['username'], 'email' => $results['email']]);
         }
-        return $this->displayRegisterBadFields($fails);
+        return $this->displayBadFields("display_login.html.twig",$fails);
     }
 
 }

src/Model/AuthModel.php

@@ -18,11 +18,11 @@ class AuthModel {
     }
 
 
-    public function validationRegister(string $username, string $password, string $confirmPassword,string $email): array {
+    public function register(string $username, string $password, string $confirmPassword,string $email): array {
         $errors = [];
 
         if ($password != $confirmPassword) {
-            $errors[] = new FieldValidationFail("confirmpassword","passwords not equals");
+            $errors[] = new FieldValidationFail("confirmpassword","password and password confirmation are not equals");
         }
 
         if ($this->gateway->mailExist($email)){
@@ -42,7 +42,7 @@ class AuthModel {
     }
 
 
-    public function validationLogin(string $email,string $password): array{
+    public function login(string $email,string $password): array{
         $errors = [];
 
         if (!$this->gateway->mailExist($email)) {

src/Views/display_auth_confirm.html.twig

@@ -1,5 +1,3 @@
-
-<!DOCTYPE html>
 <html lang="en">
 <head>
     <meta charset="UTF-8">

src/Views/display_error_validation_register.html.twig

@@ -1,4 +1,3 @@
-<!DOCTYPE html>
 <html lang="en">
 <head>
     <meta charset="UTF-8">

src/Views/display_login.html.twig

@@ -1,4 +1,3 @@
-<!DOCTYPE html>
 <html lang="en">
 <head>
     <meta charset="UTF-8">

src/Views/display_register.html.twig

@@ -1,4 +1,3 @@
-<!DOCTYPE html>
 <html lang="en">
 <head>
     <meta charset="UTF-8">

src/Views/display_results.html.twig

@@ -1,4 +1,3 @@
-<!DOCTYPE html>
 <html lang="en">
 <head>
     <meta charset="UTF-8">

src/Views/sample_form.html.twig

@@ -1,4 +1,3 @@
-<!DOCTYPE html>
 <html lang="en">
 <head>
     <meta charset="UTF-8">