add /team/new and /team/[i:id] and /team/list #16

Merged
mael.daim merged 18 commits from team/bootstrap into master 1 year ago
Owner

/team/new : create a new team thanks to a form. The team is directly saved in the database after some validations. Afterward the brand new team is displayed

/team/[i:id]: The action that displays a specific team thnaks to its id.

/team/list: This action currently list all team that are in the database because there's still no account yet. Once it'll be added then this action should list all team of the current user thanks to his id.

/team/new : create a new team thanks to a form. The team is directly saved in the database after some validations. Afterward the brand new team is displayed /team/[i:id]: The action that displays a specific team thnaks to its id. /team/list: This action currently list all team that are in the database because there's still no account yet. Once it'll be added then this action should list all team of the current user thanks to his id.
mael.daim added 12 commits 1 year ago
continuous-integration/drone/push Build is passing Details
c8df556699
made progression on the create team almost done
continuous-integration/drone/push Build is passing Details
0859467e3f
WIP just a few little adjusments and progress
continuous-integration/drone/push Build is passing Details
1acede4169
WIP did a few little changes
continuous-integration/drone/push Build is passing Details
d824f17ea7
every bugs has been fixed
mael.daim requested review from clement.freville2 1 year ago
mael.daim requested review from yanis.dahmane-bounoua 1 year ago
mael.daim requested review from maxime.batista 1 year ago
mael.daim requested review from vivien.dufour 1 year ago
mael.daim requested review from samuel.berion 1 year ago
mael.daim removed review request for clement.freville2 1 year ago
mael.daim added 1 commit 1 year ago
vivien.dufour approved these changes 1 year ago
maxime.batista requested changes 1 year ago
maxime.batista left a comment

#
class TeamController
{
private TeamModel $model;
private Environment $twig;

useless, remove this

useless, remove this
private const ROLE_COACH = 1;
public const ROLE_PLAYER = 0;
public const ROLE_COACH = 1;

as you made public static functions coach and player, you can bring back this as being private constants

as you made public static functions `coach` and `player`, you can bring back this as being private constants
return $teams;
}
public function displayTeam(int $id): Team {

you should not name this method as displayX as the class is only a class that manipulates data.

The thing this method really does is that it gets a team, filled with its members from its identifier : getTeam(int $id): Team seems correct.

you should not name this method as `displayX` as the class is only a class that manipulates data. The thing this method really does is that it gets a team, filled with its members from its identifier : `getTeam(int $id): Team` seems correct.
mael.daim added 1 commit 1 year ago
continuous-integration/drone/push Build is passing Details
262fa6180e
applied suggestions
mael.daim added 1 commit 1 year ago
continuous-integration/drone/push Build is passing Details
65151cc1ea
add some css
mael.daim added 1 commit 1 year ago
continuous-integration/drone/push Build is failing Details
7199a80562
Conflicts
mael.daim added 1 commit 1 year ago
continuous-integration/drone/push Build is failing Details
76e64a5ae5
formated the code and verification plus some more css
mael.daim added 1 commit 1 year ago
continuous-integration/drone/push Build is passing Details
d8000bcf3b
fixing CI
mael.daim merged commit b856e0c286 into master 1 year ago
mael.daim deleted branch team/bootstrap 1 year ago

Reviewers

samuel.berion was requested for review 1 year ago
yanis.dahmane-bounoua was requested for review 1 year ago
vivien.dufour approved these changes 1 year ago
maxime.batista requested changes 1 year ago
continuous-integration/drone/push Build is passing
The pull request has been merged as b856e0c286.
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: IQBall/Application-Web#16
Loading…
There is no content yet.