Add possibility to edit tactics that takes place on a semi court #37

Merged
maxime.batista merged 6 commits from editor/half-court into master 1 year ago
There is no content yet.
maxime.batista requested review from clement.freville2 1 year ago
maxime.batista requested review from yanis.dahmane-bounoua 1 year ago
maxime.batista requested review from vivien.dufour 1 year ago
maxime.batista requested review from mael.daim 1 year ago
maxime.batista requested review from samuel.berion 1 year ago
clement.freville2 requested changes 1 year ago
import TitleInput from "../components/TitleInput"
import { BasketCourt } from "../components/editor/BasketCourt"
import plainCourt from "../assets/court/court.svg"

The current build system doesn't properly handle CSS/image assets, for instance it is served as /IQBall/public/court-088e6f4e.svg on maxou.dev.

The current build system doesn't properly handle CSS/image assets, for instance it is served as `/IQBall/public/court-088e6f4e.svg` on `maxou.dev`.
maxime.batista marked this conversation as resolved
tactic: Tactic
onContentChange: (tactic: TacticContent) => Promise<boolean>
onNameChange: (name: string) => Promise<boolean>
courtType: string
-     courtType: string 
+     courtType: "PLAIN" | "HALF"
```diff - courtType: string + courtType: "PLAIN" | "HALF" ```
maxime.batista marked this conversation as resolved
id: number
name: string
content: string
courtType: string
-     courtType: string 
+     courtType: "PLAIN" | "HALF"
```diff - courtType: string + courtType: "PLAIN" | "HALF" ```
maxime.batista marked this conversation as resolved
return (
<div
className="court-kind-button"
onClick={() => (location.href = redirect)}>

This doesn't account for the base path (see https://maxou.dev/IQBall/editor/half-court/public/tactic/new/plain for instance).

This doesn't account for the base path (see https://maxou.dev/IQBall/editor/half-court/public/tactic/new/plain for instance).
maxime.batista marked this conversation as resolved
return new CourtType(CourtType::COURT_HALF);
}
public function name(): string {

It seems that your enum may be better backed by a string (and it is also supported by PHP 8.0 enums).

It seems that your enum may be better backed by a `string` (and it is also supported by PHP 8.0 enums).
maxime.batista marked this conversation as resolved
}
public function name(): string {
switch ($this->value) {

Cries for PHP 8.0 match 😥

Cries for [PHP 8.0 `match`](https://www.php.net/manual/en/control-structures.match.php) 😥
Poster

we're using php 7.4

we're using php 7.4
maxime.batista marked this conversation as resolved
maxime.batista force-pushed editor/half-court from 57b26e4f1d to afcdbc2019 1 year ago
samuel.berion approved these changes 1 year ago
maxime.batista force-pushed editor/half-court from 5a04554c1a to a27100c799 1 year ago
maxime.batista force-pushed editor/half-court from a27100c799 to 940d87930a 1 year ago
maxime.batista merged commit b43eb46638 into master 1 year ago
maxime.batista deleted branch editor/half-court 1 year ago

Reviewers

vivien.dufour was requested for review 1 year ago
yanis.dahmane-bounoua was requested for review 1 year ago
mael.daim was requested for review 1 year ago
clement.freville2 requested changes 1 year ago
samuel.berion approved these changes 1 year ago
continuous-integration/drone/push Build is passing
The pull request has been merged as b43eb46638.
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: IQBall/Application-Web#37
Loading…
There is no content yet.