home-page #81

Merged
maxime.batista merged 92 commits from home-page into master 1 year ago
There is no content yet.
yanis.dahmane-bounoua added 43 commits 1 year ago
continuous-integration/drone/push Build is failing Details
5ef36b754c
Add a basic react view with html component
continuous-integration/drone/push Build is failing Details
23a0039fe4
WIP Page Home integration img
continuous-integration/drone/push Build is failing Details
6d36115204
WIP page home
continuous-integration/drone/push Build is failing Details
86230fc702
WIP : Trying to give some argument to the JSView Home
continuous-integration/drone/push Build is failing Details
5668519c33
Add the display of tactic name
continuous-integration/drone/push Build is failing Details
4a2424ac22
WIP Home
continuous-integration/drone/push Build is failing Details
45f2cf3817
Add the structure and some style
continuous-integration/drone/push Build is failing Details
7bb93be50c
WIP
continuous-integration/drone/push Build is failing Details
fdea80ce87
WIP update the tactic research
continuous-integration/drone/push Build is failing Details
7a04924617
Fix the owner issue
continuous-integration/drone/push Build is failing Details
9febc0f29e
Can display all tactics in the personal space
continuous-integration/drone/push Build is failing Details
b4bbbbaad5
Open a tactic in the personal space
continuous-integration/drone/push Build is passing Details
a472a4d0b7
can now remove player by scroll en dehors du terrain
continuous-integration/drone/push Build is failing Details
b209a40465
merging
continuous-integration/drone/push Build is failing Details
5d10ec8c47
WIP
continuous-integration/drone/push Build is failing Details
6a5bd8deee
Home page fonctionnelle
continuous-integration/drone/push Build is failing Details
792c47537b
Remove var_dump
continuous-integration/drone/push Build is failing Details
3edb7f9fc0
Overflow
continuous-integration/drone/push Build is failing Details
7b4b80770c
WIP
continuous-integration/drone/push Build is failing Details
0d10717133
Creation component ButtonTactic
continuous-integration/drone/push Build is failing Details
0aba5f2c38
TroncName function and improve code structure
continuous-integration/drone/push Build is failing Details
ad500d694a
Add some color and style
continuous-integration/drone/push Build is failing Details
4a185449b5
Home Page ready, some Css added
yanis.dahmane-bounoua added 1 commit 1 year ago
continuous-integration/drone/push Build is failing Details
09aaf2065a
lastCommit for the home-page's base
maxime.batista requested changes 1 year ago
maxime.batista left a comment
  • Please, fix the errors reported by the CI. (./verify.sh)
  • Format your code (./format.sh)
  • this branch contains some commits related with other branch that you have pulled (seems to be an old version of editor/assign-ball). So please, rebase (not pull) from origin/master
- Please, fix the errors reported by the CI. (./verify.sh) - Format your code (./format.sh) - this branch contains some commits related with other branch that you have pulled (seems to be an old version of editor/assign-ball). So please, __rebase__ (not _pull_) from origin/master
yanis.dahmane-bounoua added 1 commit 1 year ago
continuous-integration/drone/push Build encountered an error Details
cc06b7ec69
some changes
yanis.dahmane-bounoua added 2 commits 1 year ago
continuous-integration/drone/push Build encountered an error Details
ac675cc5cd
Update style
yanis.dahmane-bounoua added 24 commits 1 year ago
yanis.dahmane-bounoua added 1 commit 1 year ago
continuous-integration/drone/push Build is failing Details
c3ae661d2b
WIP
yanis.dahmane-bounoua added 1 commit 1 year ago
continuous-integration/drone/push Build is failing Details
cace81c726
Add the link to the settings page
yanis.dahmane-bounoua added 1 commit 1 year ago
continuous-integration/drone/push Build is failing Details
3310078ab5
Title clickable
yanis.dahmane-bounoua added 1 commit 1 year ago
continuous-integration/drone/push Build is failing Details
1d995eba88
WIP
yanis.dahmane-bounoua added 1 commit 1 year ago
continuous-integration/drone/push Build is passing Details
5dea14a5e8
Correction error
yanis.dahmane-bounoua requested review from maxime.batista 1 year ago
yanis.dahmane-bounoua added 1 commit 1 year ago
continuous-integration/drone/push Build is passing Details
50032d2795
doc
yanis.dahmane-bounoua added 1 commit 1 year ago
continuous-integration/drone/push Build is passing Details
30b81aa590
Add titre
yanis.dahmane-bounoua added 1 commit 1 year ago
yanis.dahmane-bounoua added 1 commit 1 year ago
continuous-integration/drone/push Build is passing Details
5407d3fcb7
format
yanis.dahmane-bounoua added 1 commit 1 year ago
continuous-integration/drone/push Build is passing Details
ce81de812e
Drop .vscode file
maxime.batista requested changes 1 year ago
maxime.batista left a comment
  • style/home/titre.css defines much more than titles, and seems not to be used.
  • You created a style/home folder but didnt put home.css in it.
  • Please name your files and identifiers accordingly, following conventions
  • front/views/ProfilPage.tsx is empty
  • remove all commented code
* style/home/titre.css defines much more than titles, and seems not to be used. * You created a `style/home` folder but didnt put `home.css` in it. * Please name your files and identifiers accordingly, following conventions * front/views/ProfilPage.tsx is empty * remove all commented code
config.php Outdated
/**
* Maps the given relative source uri (relative to the `/front` folder) to its actual location depending on imported profile.
* @param string $assetURI relative uri path from `/front` folder
* @return string valid url that points to the given uri

why did you removed this line

why did you removed this line
yanis.dahmane-bounoua marked this conversation as resolved
cursor: pointer;
}
.ball-div:focus-within {

empty css rule

empty css rule
Poster
Owner

not my production

not my production
yanis.dahmane-bounoua marked this conversation as resolved
/* border-radius: 0.75cap; */
}
#IQBall {

you may not name your html identifiers and classes with capital letters, prefer the conventional kebab-case style

  • this applies to all of your html identifiers and classes
you may not name your html identifiers and classes with capital letters, prefer the conventional `kebab-case` style - this applies to all of your html identifiers and classes
yanis.dahmane-bounoua marked this conversation as resolved
display: block;
}
.SetButton {

for example : list-tactic, set-button

for example : `list-tactic`, `set-button`
yanis.dahmane-bounoua marked this conversation as resolved
border-spacing: 1em;
}
td {

i don't recommend applying css styles to html components, you should add an enclosing parent at least, for example : .table-data td

i don't recommend applying css styles to html components, you should add an enclosing parent at least, for example : `.table-data td`
yanis.dahmane-bounoua marked this conversation as resolved
:root {

you should merge this file with style/themes/default.css

you should merge this file with `style/themes/default.css`
yanis.dahmane-bounoua marked this conversation as resolved
second_color: string
}
export default function Home({

Only this function should be exported, all the other functions may not be exported as they are not intended to be used by external files.

Only this function should be exported, all the other functions may not be exported as they are not intended to be used by external files.
yanis.dahmane-bounoua marked this conversation as resolved
)
}
export function Tactic({ lastTactics }: { lastTactics: Tactic[] }) {

Not used

Not used
Poster
Owner

used at line 121

used at line 121
yanis.dahmane-bounoua marked this conversation as resolved
if (name.length > limit) {
name = name.substring(0, limit) + "..."
} else {
name = name

this else block is useless

this else block is useless
yanis.dahmane-bounoua marked this conversation as resolved
$allTactics = $this->tactics->getAll($session->getAccount()->getId());
$name = $session->getAccount()->getName();
//TODO

todo what

todo what
yanis.dahmane-bounoua marked this conversation as resolved
"teams" => $teams,
"username" => $name,
]);
// return ViewHttpResponse::react("views/Home.tsx", []);

remove this commented line

remove this commented line
yanis.dahmane-bounoua marked this conversation as resolved
* @param integer $nb
* @return array<array<string,mixed>>

I think it should rather return TacticInfo[]

I think it should rather return `TacticInfo[]`
yanis.dahmane-bounoua marked this conversation as resolved
/**
* Get all the tactics of the owner
*
* @return array<array<string,mixed>>

I think it should rather returns TacticInfo[]

I think it should rather returns `TacticInfo[]`
yanis.dahmane-bounoua marked this conversation as resolved
}
/**
* Undocumented function

Undocumented function

Undocumented function
yanis.dahmane-bounoua marked this conversation as resolved
yanis.dahmane-bounoua added 8 commits 1 year ago
yanis.dahmane-bounoua added 1 commit 1 year ago
continuous-integration/drone/push Build is passing Details
3ab10269f3
Translate css name to kebab-case
yanis.dahmane-bounoua requested review from maxime.batista 1 year ago
yanis.dahmane-bounoua added 1 commit 1 year ago
continuous-integration/drone/push Build is passing Details
f7f28ae08b
Last review's request
maxime.batista added 1 commit 1 year ago
continuous-integration/drone/push Build is passing Details
ea6a696bdb
format
maxime.batista force-pushed home-page from ea6a696bdb to af7c7e6e0b 1 year ago
maxime.batista merged commit 2b49a1393c into master 1 year ago
maxime.batista referenced this issue from a commit 1 year ago
maxime.batista deleted branch home-page 1 year ago

Reviewers

maxime.batista was requested for review 1 year ago
continuous-integration/drone/push Build is passing
The pull request has been merged as 2b49a1393c.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: IQBall/Application-Web#81
Loading…
There is no content yet.