Please, fix the errors reported by the CI. (./verify.sh)
Format your code (./format.sh)
this branch contains some commits related with other branch that you have pulled (seems to be an old version of editor/assign-ball). So please, rebase (not pull) from origin/master
- Please, fix the errors reported by the CI. (./verify.sh)
- Format your code (./format.sh)
- this branch contains some commits related with other branch that you have pulled (seems to be an old version of editor/assign-ball). So please, __rebase__ (not _pull_) from origin/master
style/home/titre.css defines much more than titles, and seems not to be used.
You created a style/home folder but didnt put home.css in it.
Please name your files and identifiers accordingly, following conventions
front/views/ProfilPage.tsx is empty
remove all commented code
* style/home/titre.css defines much more than titles, and seems not to be used.
* You created a `style/home` folder but didnt put `home.css` in it.
* Please name your files and identifiers accordingly, following conventions
* front/views/ProfilPage.tsx is empty
* remove all commented code
you may not name your html identifiers and classes with capital letters, prefer the conventional kebab-case style
this applies to all of your html identifiers and classes
you may not name your html identifiers and classes with capital letters, prefer the conventional `kebab-case` style
- this applies to all of your html identifiers and classes
yanis.dahmane-bounoua marked this conversation as resolved
style/home
folder but didnt puthome.css
in it./**
* Maps the given relative source uri (relative to the `/front` folder) to its actual location depending on imported profile.
* @param string $assetURI relative uri path from `/front` folder
* @return string valid url that points to the given uri
why did you removed this line
cursor: pointer;
}
.ball-div:focus-within {
empty css rule
not my production
/* border-radius: 0.75cap; */
}
#IQBall {
you may not name your html identifiers and classes with capital letters, prefer the conventional
kebab-case
styledisplay: block;
}
.SetButton {
for example :
list-tactic
,set-button
border-spacing: 1em;
}
td {
i don't recommend applying css styles to html components, you should add an enclosing parent at least, for example :
.table-data td
:root {
you should merge this file with
style/themes/default.css
second_color: string
}
export default function Home({
Only this function should be exported, all the other functions may not be exported as they are not intended to be used by external files.
)
}
export function Tactic({ lastTactics }: { lastTactics: Tactic[] }) {
Not used
used at line 121
if (name.length > limit) {
name = name.substring(0, limit) + "..."
} else {
name = name
this else block is useless
$allTactics = $this->tactics->getAll($session->getAccount()->getId());
$name = $session->getAccount()->getName();
//TODO
todo what
"teams" => $teams,
"username" => $name,
]);
// return ViewHttpResponse::react("views/Home.tsx", []);
remove this commented line
* @param integer $nb
* @return array<array<string,mixed>>
I think it should rather return
TacticInfo[]
/**
* Get all the tactics of the owner
*
* @return array<array<string,mixed>>
I think it should rather returns
TacticInfo[]
}
/**
* Undocumented function
Undocumented function
ea6a696bdb
toaf7c7e6e0b
1 year ago2b49a1393c
into master 1 year agoReviewers
2b49a1393c
.