IQBall
/
Application-Web
6
0
Fork 0
Code Issues 49 Pull Requests Packages Projects 5 Releases Wiki Activity
Labels Milestones

Team's part #84

Merged
maxime.batista merged 28 commits from team/completing into master 2 years ago
Conversation 0 Commits 28 Files Changed 43
mael.daim commented 2 years ago
Owner

This pull request adds the members to the team with the possibilitie to add or remove a player or quit the team. It means that this PR implements the account within the team's part of the application.
Moreover some bugs has been fixed.
The view of the team has been translated to react.js
This PR also adds the edit and delete of a team.

This pull request adds the members to the team with the possibilitie to add or remove a player or quit the team. It means that this PR implements the account within the team's part of the application. Moreover some bugs has been fixed. The view of the team has been translated to react.js This PR also adds the edit and delete of a team.
maxime.batista was assigned by mael.daim 2 years ago
samuel.berion was assigned by mael.daim 2 years ago
vivien.dufour was assigned by mael.daim 2 years ago
yanis.dahmane-bounoua was assigned by mael.daim 2 years ago
mael.daim added 17 commits 2 years ago
continuous-integration/drone/push Build is passing Details
1914671699 delete team's action almost done
continuous-integration/drone/push Build is passing Details
fbe31a4de9 added some css
continuous-integration/drone/push Build is failing Details
c0a02c91c5 implementing the add of member in a team
continuous-integration/drone/push Build is passing Details
fafe4a1ff4 format and verified
continuous-integration/drone/push Build is passing Details
59e9cf6503 merged master into the branch team/completing
vivien.dufour approved these changes 2 years ago
maxime.batista added 1 commit 2 years ago
continuous-integration/drone/push Build is failing Details
5ff028229d rm unused Ball.tsx
maxime.batista requested changes 2 years ago
maxime.batista left a comment

please respect naming conventions

please respect naming conventions
front/style/team_panel.css Outdated
#mainDiv {
maxime.batista commented 2 years ago

please name your html identifier and classes in kebab-case (with a - between each words, no capital letters)

please name your html identifier and classes in `kebab-case` (with a `-` between each words, no capital letters)
mael.daim marked this conversation as resolved
front/style/team_panel.css Outdated
height: 100%;
}
header {
maxime.batista commented 2 years ago

Avoid applying styles on html components directly.
Prefer the use of classes instead, because you are applying those changes on all <header></header> components, which can lead to unwanted styles

Avoid applying styles on html components directly. Prefer the use of classes instead, because you are applying those changes on all `<header></header>` components, which can lead to unwanted styles
mael.daim marked this conversation as resolved
public/index.php Outdated
}
return App::runAction($basePath . '/login', $match['target'], $match['params'], $session);
return App::runAction('/login', $match['target'], $match['params'], $session);
maxime.batista commented 2 years ago

why did you removed $basePath here ? please revert it to the original line :

return App::runAction($basePath . '/login', $match['target'], $match['params'], $session);
why did you removed `$basePath` here ? please revert it to the original line : ```php return App::runAction($basePath . '/login', $match['target'], $match['params'], $session); ```
mael.daim marked this conversation as resolved
src/App/Controller/TeamController.php Outdated
return ViewHttpResponse::twig('error.html.twig', [
'failures' => [ValidationFail::unauthorized("Vous n'avez pas accès à cette équipe.")],
], HttpCodes::FORBIDDEN);
} else {
maxime.batista commented 2 years ago

this 'else' is useless since the if statement will always return if executed :

example

if ($condition)  {
	return $value
} else {
	// some code
}

can become :

if ($condition)  {
	return $value //because if `$condition` is true, we already return, the code after the `ìf` statement will not be called
}  

// some code
this 'else' is useless since the if statement will always return if executed : example ```php if ($condition)  { return $value } else { // some code } ``` can become : ```php if ($condition)  { return $value //because if `$condition` is true, we already return, the code after the `ìf` statement will not be called } // some code ```
mael.daim marked this conversation as resolved
mael.daim added 2 commits 2 years ago
maxime.batista force-pushed team/completing from 1efec8c0d9 to 4298230938 2 years ago
mael.daim added 5 commits 2 years ago
continuous-integration/drone/push Build is failing Details
5ff028229d rm unused Ball.tsx
continuous-integration/drone/push Build is failing Details
d8e14adbd1 applied reviews changes
maxime.batista added 1 commit 2 years ago
continuous-integration/drone/push Build is passing Details
34de8f4693 format and fixes
mael.daim added 2 commits 2 years ago
mael.daim added 1 commit 2 years ago
continuous-integration/drone/push Build is passing Details
f79d6ae7b2 fixed CI
maxime.batista added 1 commit 2 years ago
continuous-integration/drone/push Build is passing Details
e6a1b7e4bf fix
maxime.batista merged commit 3a437a7ad1 into master 2 years ago
maxime.batista referenced this issue from a commit 2 years ago
Team's part (#84)
maxime.batista deleted branch team/completing 2 years ago

Reviewers

vivien.dufour approved these changes 2 years ago
maxime.batista requested changes 2 years ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as 3a437a7ad1.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
vivien.dufour
maxime.batista
Labels
Apply labels
Clear labels
bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong question
More information is needed wontfix
This won't be fixed
No Label bug duplicate enhancement help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
samuel.berion
vivien.dufour
yanis.dahmane-bounoua
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: IQBall/Application-Web#84
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'team/completing'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes