add manual deployment scripts

maxime.batista commented

There is no content yet.

maxime.batista added 1 commit

maxime.batista force-pushed manual-deploy from 3984b228a5 to 87e73a3c5f

maxime.batista merged commit 93612c473b into master 1 year ago

maxime.batista referenced this issue from a commit

maxime.batista deleted branch manual-deploy

clement.freville2 requested changes

ci/build_and_deploy_to.sh

clement.freville2 commented

The shebang is missing.

ci/build_and_deploy_to.sh

													
					export OUTPUT=$1

					export BASE=$2

					rm -rf $OUTPUT/*

clement.freville2 commented

Quote the variable as it may contain spaces. Also, if $1 isn't defined, this will literally execute rm -rf /*

ci/build_and_deploy_to.sh

													
					rm -rf $OUTPUT/*

					echo "VITE_API_ENDPOINT=$BASE/api" >> .env.PROD

					echo "VITE_BASE=$BASE" >> .env.PROD

clement.freville2 commented

Just pass those as environment variables? They don't need to be in a file.

profiles/prod-config-profile.php

													
					require __DIR__ . "/../views-mappings.php";

					// THIS VALUE IS TO SET IN THE CI

					const BASE_PATH = null;

clement.freville2 commented

"" is a reasonable default.

clement.freville2 requested changes

continuous-integration/drone/push Build is passing

Details

The pull request has been merged as 93612c473b.

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: IQBall/Application-Web#96

add manual deployment scripts #96