From 0e43ca7f40452833554ac0077d38375b2725f590 Mon Sep 17 00:00:00 2001 From: Alexis Date: Tue, 7 Feb 2023 14:41:59 +0100 Subject: [PATCH] SonarQube code smells resolve #31 --- Source/API/script/Gateway/GatewayQuestion.php | 2 +- Source/BusinessClass/BoxQuestion.php | 6 +++--- Source/BusinessClass/IPrintQuestionStrategy.php | 2 +- Source/BusinessClass/IResponseProcessingStrategy.php | 2 +- Source/BusinessClass/Question.php | 4 ++-- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Source/API/script/Gateway/GatewayQuestion.php b/Source/API/script/Gateway/GatewayQuestion.php index 3ba3c36..d110df0 100644 --- a/Source/API/script/Gateway/GatewayQuestion.php +++ b/Source/API/script/Gateway/GatewayQuestion.php @@ -44,7 +44,7 @@ class GatewayQuestion )); - foreach ($question->getCategories()[$i] as $keyword){ + foreach ($question->getCategories()[$i] as $keyword) { $gatewayForm = new GatewayForm(); $gatewayForm->assignKeywordToQuestion($keyword, $listPossibleResponse[$i], $idQuestion); } diff --git a/Source/BusinessClass/BoxQuestion.php b/Source/BusinessClass/BoxQuestion.php index d929a35..fc4eb6e 100644 --- a/Source/BusinessClass/BoxQuestion.php +++ b/Source/BusinessClass/BoxQuestion.php @@ -21,9 +21,9 @@ abstract class BoxQuestion extends Question $this->possibleResponses = $possibleResponses; } - public abstract function responseStrategy(); + abstract public function responseStrategy(); - public abstract function printStrategy(): string; + abstract public function printStrategy(): string; /** * @return array @@ -56,4 +56,4 @@ abstract class BoxQuestion extends Question { $this->categories = $categories; } -} \ No newline at end of file +} diff --git a/Source/BusinessClass/IPrintQuestionStrategy.php b/Source/BusinessClass/IPrintQuestionStrategy.php index f59c957..06b2d5c 100644 --- a/Source/BusinessClass/IPrintQuestionStrategy.php +++ b/Source/BusinessClass/IPrintQuestionStrategy.php @@ -5,4 +5,4 @@ namespace BusinessClass; interface IPrintQuestionStrategy { public function printStrategy(): string; -} \ No newline at end of file +} diff --git a/Source/BusinessClass/IResponseProcessingStrategy.php b/Source/BusinessClass/IResponseProcessingStrategy.php index 597037b..c6bf1d2 100644 --- a/Source/BusinessClass/IResponseProcessingStrategy.php +++ b/Source/BusinessClass/IResponseProcessingStrategy.php @@ -5,4 +5,4 @@ namespace BusinessClass; interface IResponseProcessingStrategy { public function responseStrategy(); -} \ No newline at end of file +} diff --git a/Source/BusinessClass/Question.php b/Source/BusinessClass/Question.php index 397be54..67dd266 100644 --- a/Source/BusinessClass/Question.php +++ b/Source/BusinessClass/Question.php @@ -17,9 +17,9 @@ abstract class Question implements IResponseProcessingStrategy, IPrintQuestionSt $this->content = $content; } - public abstract function responseStrategy(); + abstract public function responseStrategy(); - public abstract function printStrategy(): string; + abstract public function printStrategy(): string; /** * @return string