From 2c423ce0ef6f33ccf5066c7437debc1d4658de8b Mon Sep 17 00:00:00 2001 From: Alexis Date: Tue, 7 Feb 2023 15:37:07 +0100 Subject: [PATCH] SonarQube code smells resolve Num39 --- Source/Model/Factory.php | 2 +- Source/Model/FactoryQuestion.php | 2 +- Source/Model/ModelAdmin.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Source/Model/Factory.php b/Source/Model/Factory.php index 738afae..1952aba 100644 --- a/Source/Model/Factory.php +++ b/Source/Model/Factory.php @@ -8,7 +8,7 @@ abstract class Factory { abstract public function create(array $results): array; - static public function getBuiltObjects(array $results, string $type): array + public static function getBuiltObjects(array $results, string $type): array { $type = "\\Model\\Factory" . $type; return (new $type())->create($results); diff --git a/Source/Model/FactoryQuestion.php b/Source/Model/FactoryQuestion.php index f91326f..9723d60 100644 --- a/Source/Model/FactoryQuestion.php +++ b/Source/Model/FactoryQuestion.php @@ -11,7 +11,7 @@ class FactoryQuestion extends Factory { $questions = []; if ($results[0] != null) { - for ($i = 0; $i < count($results[0]); $i++) { + for ($i = 0; $i < count($results[0]); $i++) { if (strcmp($results[0][$i]['type'], "BusinessClass\TextQuestion") == 0) { $questions[] = new TextQuestion($results[0][$i]['content'], $results[0][$i]['id']); } else { diff --git a/Source/Model/ModelAdmin.php b/Source/Model/ModelAdmin.php index 440ea97..3162056 100644 --- a/Source/Model/ModelAdmin.php +++ b/Source/Model/ModelAdmin.php @@ -28,7 +28,7 @@ class ModelAdmin $categories = $tmp; array_pop($categories); - if (strcmp($type,"BusinessClass\TextQuestion") == 0) { + if (strcmp($type, "BusinessClass\TextQuestion") == 0) { $question = new $type($questionContent, 0); } else { $question = new $type($responses, $questionContent, $categories, 0);