From 752f3ca068e3b9f62fd5c1a6053bd860d34f64b7 Mon Sep 17 00:00:00 2001 From: alexi Date: Thu, 23 Feb 2023 08:29:15 +0100 Subject: [PATCH] sonar resolve bugs --- Source/BusinessClass/BoxQuestion.php | 4 +--- Source/BusinessClass/CheckBoxQuestion.php | 14 +------------- Source/BusinessClass/ListBoxQuestion.php | 14 +------------- 3 files changed, 3 insertions(+), 29 deletions(-) diff --git a/Source/BusinessClass/BoxQuestion.php b/Source/BusinessClass/BoxQuestion.php index bbf49d4..4504408 100644 --- a/Source/BusinessClass/BoxQuestion.php +++ b/Source/BusinessClass/BoxQuestion.php @@ -17,10 +17,8 @@ abstract class BoxQuestion extends Question private array $categories; - public function __construct() + public function __construct(int $ctp, array $args) { - $ctp = func_num_args(); - $args = func_get_args(); switch($ctp) { case 4: diff --git a/Source/BusinessClass/CheckBoxQuestion.php b/Source/BusinessClass/CheckBoxQuestion.php index 9f76d76..a0fcf5c 100644 --- a/Source/BusinessClass/CheckBoxQuestion.php +++ b/Source/BusinessClass/CheckBoxQuestion.php @@ -9,19 +9,7 @@ class CheckBoxQuestion extends BoxQuestion { public function __construct() { - $ctp = func_num_args(); - $args = func_get_args(); - switch($ctp) - { - case 4: - parent::__construct($args[0], $args[1], $args[2], $args[3]); - break; - case 2: - parent::__construct($args[0], $args[1]); - break; - default: - break; - } + parent::__construct(func_num_args(), func_get_args()); } diff --git a/Source/BusinessClass/ListBoxQuestion.php b/Source/BusinessClass/ListBoxQuestion.php index 31a4809..f3f460f 100644 --- a/Source/BusinessClass/ListBoxQuestion.php +++ b/Source/BusinessClass/ListBoxQuestion.php @@ -9,19 +9,7 @@ class ListBoxQuestion extends BoxQuestion { public function __construct() { - $ctp = func_num_args(); - $args = func_get_args(); - switch($ctp) - { - case 4: - parent::__construct($args[0], $args[1], $args[2], $args[3]); - break; - case 2: - parent::__construct($args[0], $args[1]); - break; - default: - break; - } + parent::__construct(func_num_args(), func_get_args()); }