From 6aff34e98317550f293ebdb9825e775f94992a64 Mon Sep 17 00:00:00 2001 From: tomivt Date: Sat, 8 Feb 2025 22:08:42 +0100 Subject: [PATCH] Code Smells from Model --- WF-WebAdmin/WF-WebAdmin/Model/LoggerSaveStub.cs | 7 +++---- WF-WebAdmin/WF-WebAdmin/Model/Quiz.cs | 15 --------------- WF-WebAdmin/WF-WebAdmin/Model/User.cs | 4 ++-- WF-WebAdmin/WF-WebAdmin/Model/UserLogin.cs | 4 ++-- 4 files changed, 7 insertions(+), 23 deletions(-) diff --git a/WF-WebAdmin/WF-WebAdmin/Model/LoggerSaveStub.cs b/WF-WebAdmin/WF-WebAdmin/Model/LoggerSaveStub.cs index 9c8b0ae..e4b7df8 100644 --- a/WF-WebAdmin/WF-WebAdmin/Model/LoggerSaveStub.cs +++ b/WF-WebAdmin/WF-WebAdmin/Model/LoggerSaveStub.cs @@ -12,13 +12,12 @@ namespace WF_WebAdmin.Model { public static partial class LoggerSaveStub { - public static void Log(ILogger logs,LogLevel logLevel,string message) + public static void Log(ILogger logs, LogLevel logLevel, string message, params object[] args) { - ILogsService logsService = new LogsServiceStub(); - logsService.addLogs( new Logs( logLevel , message ) ); + logsService.addLogs(new Logs(logLevel, string.Format(message, args))); - logs.Log(logLevel, message ); + logs.Log(logLevel, message, args); } } } diff --git a/WF-WebAdmin/WF-WebAdmin/Model/Quiz.cs b/WF-WebAdmin/WF-WebAdmin/Model/Quiz.cs index af6691a..4b5de4f 100644 --- a/WF-WebAdmin/WF-WebAdmin/Model/Quiz.cs +++ b/WF-WebAdmin/WF-WebAdmin/Model/Quiz.cs @@ -12,19 +12,6 @@ namespace WF_WebAdmin.Model public bool IsValid { get; set; } public string UserProposition { get; set; } - public Quiz(int id, string question, string answerA, string answerB, string answerC, string answerD, string cAnswer, bool isValid, string userProposition) - { - Id = id; - Question = question; - AnswerA = answerA; - AnswerB = answerB; - AnswerC = answerC; - AnswerD = answerD; - CAnswer = cAnswer; - IsValid = isValid; - UserProposition = userProposition; - } - public Quiz(int id, string question, string answerA, string answerB, string answerC, string answerD, string cAnswer) { Id = id; @@ -38,7 +25,5 @@ namespace WF_WebAdmin.Model UserProposition = "Admin"; } - public Quiz() {} - } } \ No newline at end of file diff --git a/WF-WebAdmin/WF-WebAdmin/Model/User.cs b/WF-WebAdmin/WF-WebAdmin/Model/User.cs index 5916a3f..1b8d7a5 100644 --- a/WF-WebAdmin/WF-WebAdmin/Model/User.cs +++ b/WF-WebAdmin/WF-WebAdmin/Model/User.cs @@ -4,8 +4,8 @@ { public int Id { get; set; } public string? Image { get; set; } - public string Name { get; set; } - public string Email { get; set; } + public string? Name { get; set; } + public string? Email { get; set; } public DateTime DateCreation { get; set; } public Boolean IsAdmin { get; set; } diff --git a/WF-WebAdmin/WF-WebAdmin/Model/UserLogin.cs b/WF-WebAdmin/WF-WebAdmin/Model/UserLogin.cs index 99c0121..74a4820 100644 --- a/WF-WebAdmin/WF-WebAdmin/Model/UserLogin.cs +++ b/WF-WebAdmin/WF-WebAdmin/Model/UserLogin.cs @@ -5,9 +5,9 @@ namespace WF_WebAdmin.Model { public int Id { get; set; } public string? Image { get; set; } - public string Name { get; set;} + public string? Name { get; set;} public Boolean IsAdmin { get; set; } - public string Mdp { get; set; } + public string? Mdp { get; set; } public UserLogin(int id,string image, string name, bool isAdmin, string mdp) { Id = id;