diff --git a/Sources/Model/Dice/DieManager.cs b/Sources/Model/Dice/DieManager.cs index c1a1aae..5c13ea3 100644 --- a/Sources/Model/Dice/DieManager.cs +++ b/Sources/Model/Dice/DieManager.cs @@ -12,9 +12,9 @@ namespace Model.Dice public KeyValuePair>> Add(KeyValuePair>> toAdd) { // on trim la clé d'abord - if (toAdd.Key == null) + if (string.IsNullOrWhiteSpace(toAdd.Key)) { - throw new ArgumentNullException(nameof(toAdd), "param should not be null"); + throw new ArgumentNullException(nameof(toAdd), "param should not be null or empty"); } if (diceGroups.Contains(toAdd)) @@ -39,22 +39,22 @@ namespace Model.Dice { // les groupes de dés nommés : // ils sont case-sensistive, mais "mon jeu" == "mon jeu " == " mon jeu" - if (name != null) + if (string.IsNullOrWhiteSpace(name)) { - return new KeyValuePair>>(name, diceGroups[name]); + throw new ArgumentNullException(nameof(name), "param should not be null or empty"); } - else { - throw new ArgumentNullException(nameof(name), "param should not be null"); - - + else + { + return new KeyValuePair>>(name, diceGroups[name]); } } public void Remove(KeyValuePair>> toRemove) { - if (toRemove.Key != null) - { - throw new ArgumentNullException(nameof(toRemove), "param should not be null"); } + if (toRemove.Key is null) + { + throw new ArgumentNullException(nameof(toRemove), "param should not be null"); + } else { diceGroups.Remove(toRemove.Key);