From 7e85dba135ffc1c8194efe776fc7445b91e66af8 Mon Sep 17 00:00:00 2001
From: Alexis DRAI <drai.alexis@gmail.com>
Date: Wed, 21 Sep 2022 18:15:01 +0200
Subject: [PATCH] :adhesive_bandage: Fix code smells

---
 Sources/Model/Dice/DieManager.cs      | 2 +-
 Sources/Model/Dice/FavGroupManager.cs | 2 +-
 Sources/Model/Games/Game.cs           | 2 +-
 Sources/Model/Games/GameRunner.cs     | 6 +++---
 Sources/Model/Games/Turn.cs           | 8 +++++++-
 5 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/Sources/Model/Dice/DieManager.cs b/Sources/Model/Dice/DieManager.cs
index ad3d8b9..200ea6b 100644
--- a/Sources/Model/Dice/DieManager.cs
+++ b/Sources/Model/Dice/DieManager.cs
@@ -4,6 +4,6 @@ namespace Model.Dice
 {
     public class DieManager
     {
-        private IEnumerable<Die> dice = new List<Die>();
+        private readonly IEnumerable<Die> dice = new List<Die>();
     }
 }
diff --git a/Sources/Model/Dice/FavGroupManager.cs b/Sources/Model/Dice/FavGroupManager.cs
index 9a5bc78..8e589d7 100644
--- a/Sources/Model/Dice/FavGroupManager.cs
+++ b/Sources/Model/Dice/FavGroupManager.cs
@@ -6,7 +6,7 @@ namespace Model.Dice
     {
         private IEnumerable<FavGroup> favGroups;
 
-        private DieManager dieManager;
+        private readonly DieManager dieManager;
 
         public FavGroupManager(DieManager dieManager)
         {
diff --git a/Sources/Model/Games/Game.cs b/Sources/Model/Games/Game.cs
index b0b4864..cb339df 100644
--- a/Sources/Model/Games/Game.cs
+++ b/Sources/Model/Games/Game.cs
@@ -10,7 +10,7 @@ namespace Model.Games
     {
         public string Name { get; private set; }
 
-        private IEnumerable<Turn> turns = new List<Turn>();
+        private readonly IEnumerable<Turn> turns = new List<Turn>();
 
         public Game(string name)
         {
diff --git a/Sources/Model/Games/GameRunner.cs b/Sources/Model/Games/GameRunner.cs
index 6cbcdf9..b7a30d8 100644
--- a/Sources/Model/Games/GameRunner.cs
+++ b/Sources/Model/Games/GameRunner.cs
@@ -10,9 +10,9 @@ namespace Model.Games
 {
     public class GameRunner
     {
-        private PlayerManager globalPlayerManager;
-        private FavGroupManager favGroupManager;
-        private IEnumerable<Game> games;
+        private readonly PlayerManager globalPlayerManager;
+        private readonly FavGroupManager favGroupManager;
+        private readonly IEnumerable<Game> games;
 
         public GameRunner(PlayerManager globalPlayerManager, FavGroupManager favGroupManager, IEnumerable<Game> games)
         {
diff --git a/Sources/Model/Games/Turn.cs b/Sources/Model/Games/Turn.cs
index df131d1..8ae0a37 100644
--- a/Sources/Model/Games/Turn.cs
+++ b/Sources/Model/Games/Turn.cs
@@ -29,13 +29,17 @@ namespace Model.Games
         /// </summary>
         public readonly Player player;
 
-        private IEnumerable<AbstractDieFace> faces;
+        /// <summary>
+        /// the collection of Face that were rolled
+        /// </summary>
+        private readonly IEnumerable<AbstractDieFace> faces;
 
         /// <summary>
         /// this private constructor is to be used only by factories
         /// </summary>
         /// <param name="when">date and time of the turn</param>
         /// <param name="player">player who played the turn</param>
+        /// <param name="faces">faces that were rolled</param>
         private Turn(DateTime when, Player player, IEnumerable<AbstractDieFace> faces)
         {
             this.when = when;
@@ -51,6 +55,7 @@ namespace Model.Games
         /// </summary>
         /// <param name="when">date and time of the turn</param>
         /// <param name="player">player who played the turn</param>
+        /// <param name="faces">faces that were rolled</param>
         /// <returns>a new Turn object</returns>
         public static Turn CreateWithSpecifiedTime(DateTime when, Player player, IEnumerable<AbstractDieFace> faces)
         {
@@ -75,6 +80,7 @@ namespace Model.Games
         /// creates a Turn with a default time, which is "now" in UTC. 
         /// </summary>
         /// <param name="player">player who played the turn</param>
+        /// <param name="faces">faces that were rolled</param>
         /// <returns>a new Turn object</returns>
         public static Turn CreateWithDefaultTime(Player player, IEnumerable<AbstractDieFace> faces)
         {