fix_die_and_faces_structure #106

Merged

alexis.drai merged 10 commits from fix_die_and_faces_structure into main

ismail.taha_janan commented

Collaborator

There is no content yet.

ismail.taha_janan added 9 commits

6e6f999b09 simple commit

1149c916c4 simple commit

3a263b4dca simple commit

d4d587afb9 ✨ Simplify code and give more freedom

by introducing HomogeneousDie, changing the logic in Face, and making class names shorter

f12997f1f8 ♻️ 🐛 🚨 Refactor URIs and handle URI exceptions in prototype

2fa185829f ✏️ ♻️ Rename Faces and override GetRandomFace()

"ListFaces" was misleading because it is not a list
GetRandomFace should return a Face<T> when called from a HomogeneousDie

3886fc7934 code with error

f2eafe4ded fix merging conflict

949521ff9b ✅ conflict solved

alexis.drai requested changes

alexis.drai left a comment

Owner

Looking good. You just have those 5 class files to delete, and we're good to go

Sources/Model/Dice/Faces/AbstractDieFace.cs Outdated

alexis.drai commented

Owner

You can remove this dead code

Sources/Model/Dice/Faces/ColorDieFace.cs Outdated

													
					﻿using System;

alexis.drai commented

Owner

You can remove this dead code

Sources/Model/Dice/Faces/ImageDieFace.cs Outdated


				`namespace Model.Dice.Faces`

alexis.drai commented

Owner

You can remove this dead code

Sources/Model/Dice/Faces/NumberDieFace.cs Outdated

alexis.drai commented

Owner

You can remove this dead code

Sources/Model/Dice/HomogeneousDice.cs Outdated

													
					﻿using System;

					using System.Collections.Generic;

					using System.Linq;

alexis.drai commented

Owner

You can remove this dead code

alexis.drai changed title from ~~fix_die_and_faces_structure~~ to WIP: fix_die_and_faces_structure

ismail.taha_janan added 1 commit

e49afa3b14 🩹 improve code

alexis.drai changed title from ~~WIP: fix_die_and_faces_structure~~ to fix_die_and_faces_structure

alexis.drai merged commit c28a36292a into main 3 years ago

alexis.drai referenced this issue from a commit

Merge pull request 'fix_die_and_faces_structure' (#106) from fix_die_and_faces_structure into main

Reviewers

alexis.drai requested changes

continuous-integration/drone/push Build is passing

Details

The pull request has been merged as c28a36292a.

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: alexis.drai/dice_app#106