Labels Milestones

🗃️ ✨ Add TurnEntity (many to many) #191

Merged

alexis.drai merged 12 commits from add-turnentities into main 3 years ago

Conversation 1 Commits 12 Files Changed 36

alexis.drai commented 3 years ago

Owner

There is no content yet.

alexis.drai added 12 commits 3 years ago

e6ba5f150e 🚧 WIP

c7aac52f48 🔀 main --> this

7fd6078c25 ♻️ Use inheritance, use properties for FK ...

to prepare for many-to-many with TurnEntity

bf22c44740 ♻️ Rename Player to PlayerEntity in EF project for clarity

0a01b402c0 🗃️ ✨ Add TurnEntity and implement many-to-many

32a58dd414 🐛 Initialize empty collections, debug die creation

27e90bfbd5 🚚 Move Point to Tests root

1bf9d8394f 🚧 Redefine Equals and Hash in dice and faces ...

while it may make comparisons slower, it's useful for redefining equality in TurnEntity

cce587437e ✅ Test TurnEntity

2ef6b304dc 📈 Slither over the 80% line ...

making tickets for UTs + cleanup

5694baf4cd ✅ Unit test Utils.Enumerables

865947fa9c 📈

alexis.drai commented 3 years ago

Poster

Owner

Fixes #144

Fixes #144

alexis.drai merged commit ef1a6966ea into main 3 years ago

alexis.drai deleted branch add-turnentities 3 years ago

alexis.drai referenced this issue from a commit 3 years ago

Merge pull request '🗃️ ✨ Add TurnEntity (many to many)' (#191) from add-turnentities into main

alexis.drai referenced this pull request 3 years ago

Code TurnExtensions #146

continuous-integration/drone/push Build is passing

Details

The pull request has been merged as ef1a6966ea.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

bug
Something is not working code smell
Not exactly a bug, but this code will cause problems down the line doc
About documentation duplicate
This issue or pull request already exists fixed
This issue has been fixed, but should not be closed yet help wanted
Need some help invalid
Something is wrong low priority
This issue has a lower priority meta
About issues / tickets themselves nice to have
This would be nice to have, but not essential performance
This is to improve performance in some way prerequisite
These issues needs to be resolved before moving on to any other issue question
More information is needed required
New requirement setup
About the project tree or structure testing
About code quality and testing waiting for release
This issue will need to be resolved when we release, but not before wontfix
This won't be fixed

No Label bug code smell doc duplicate fixed help wanted invalid low priority meta nice to have performance prerequisite question required setup testing waiting for release wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: alexis.drai/dice_app#191

Write Preview

Loading…

Cancel

Save

There is no content yet.