🐛🛂✅♻️ Add checks and exceptions, move solutions to pb points #52

Closed

alexis.drai wants to merge 0 commits from improve-player-and-mgmt into main

alexis.drai commented

Owner

There is no content yet.

alexis.drai added 11 commits

fd00107e5f 🩹 Pass params by vals instead of by refs

if we pass parameters by reference, it must be because we want to
change them in the method and to keep those changes.
This seems like a different situation, so we should be able
to pass the objects by value.

d36afce173 🐛 Add validation and delegation to Player.Remove()

a5483b3850 ✅ Improve Update() test after bugfix

0f3471cb60 ✏️ Fix typo

fb69b719b4 ✅ Generalize from HashSets to IEnumerables or Collections

e85b9e5550 ♻️ Refactor, D.R.Y., use "expected" and "actual"

fb02307b28 🩹 Move validation to constructor, clarify with comments

86597ef08f 🩹 Remove old or useless TODOs

180c50b2c7 🩹 Improve exception-throwing

1ad5c7cf21 🛂✅ Add null checks and exceptions, reflect change in UTs

bbfe7291c4 🩹 Fix code smell

alexis.drai referenced this issue from a commit

🔀 Merge #52 into main

alexis.drai closed this pull request

alexis.drai deleted branch improve-player-and-mgmt

continuous-integration/drone/push Build is passing

Details

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: alexis.drai/dice_app#52