From 55a7380fcd76b7946fe28b4a325e88512a4514aa Mon Sep 17 00:00:00 2001 From: baollier1 Date: Thu, 2 Feb 2023 11:01:52 +0100 Subject: [PATCH 1/2] add dto fin --- Sources/apiLOL/ChampionDTO.cs | 7 +++++++ Sources/apiLOL/ChampionMapper.cs | 10 +++++----- .../apiLOL/Controllers/ControllerChampions.cs | 17 +++++++---------- 3 files changed, 19 insertions(+), 15 deletions(-) diff --git a/Sources/apiLOL/ChampionDTO.cs b/Sources/apiLOL/ChampionDTO.cs index abbb60d..253af0a 100644 --- a/Sources/apiLOL/ChampionDTO.cs +++ b/Sources/apiLOL/ChampionDTO.cs @@ -2,6 +2,13 @@ { public class ChampionDTO { + + public ChampionDTO(string name, string bio) + { + Name = name; + Bio = bio; + } + public string Name { get; set; } public string Bio { get; set; } diff --git a/Sources/apiLOL/ChampionMapper.cs b/Sources/apiLOL/ChampionMapper.cs index 6875ca4..c3ff994 100644 --- a/Sources/apiLOL/ChampionMapper.cs +++ b/Sources/apiLOL/ChampionMapper.cs @@ -6,12 +6,12 @@ namespace apiLOL { public static ChampionDTO ToDTO(this Champion champion) { - ChampionDTO championDTO = new ChampionDTO(); - championDTO.Name = champion.Name; - championDTO.Bio = champion.Bio; + return new ChampionDTO(champion.Name, champion.Bio); + } - Console.WriteLine(championDTO.Name); - return championDTO; + public static Champion ToModel(this ChampionDTO championDTO) + { + return new Champion(championDTO.Name); } } } diff --git a/Sources/apiLOL/Controllers/ControllerChampions.cs b/Sources/apiLOL/Controllers/ControllerChampions.cs index fa13e23..06cf939 100644 --- a/Sources/apiLOL/Controllers/ControllerChampions.cs +++ b/Sources/apiLOL/Controllers/ControllerChampions.cs @@ -14,7 +14,6 @@ namespace apiLOL.Controllers public ControllerChampions(IDataManager manager) { - data = manager; } @@ -28,19 +27,17 @@ namespace apiLOL.Controllers } - // GET api//5 - [HttpGet("{id}")] - public async Task Get(int id) + // GET api//Charle + [HttpGet] + [Route("{name}")] + public async Task GetChampion(string name) { - //ChampionsManager.GetNbItemsByCharacteristic("Akali"); - //ChampionMapper.ToDTO(ChampionsManager.GetNbItemsByCharacteristic("Akali")); - //return new ChampionMapper.ToDTO(ChampionsManager.GetNbItemsByCharacteristic("Akali")); - //return "value"; - var champs = (await data.ChampionsMgr.GetItems(0, await data.ChampionsMgr.GetNbItems())).Select(Model => Model.ToDTO()); + var champs = (await data.ChampionsMgr.GetItems(0, await data.ChampionsMgr.GetNbItems())).First(i => i.Name == name); + ChampionDTO result = champs.ToDTO(); return Ok(champs); - } + // POST api/ [HttpPost] public void Post([FromBody] string value) From bf7147d881aecfaf41a7c44002ba0edaba2b1539 Mon Sep 17 00:00:00 2001 From: baollier1 Date: Thu, 2 Feb 2023 11:22:00 +0100 Subject: [PATCH 2/2] add get(name) --- Sources/apiLOL/Controllers/ControllerChampions.cs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Sources/apiLOL/Controllers/ControllerChampions.cs b/Sources/apiLOL/Controllers/ControllerChampions.cs index 06cf939..b2cc112 100644 --- a/Sources/apiLOL/Controllers/ControllerChampions.cs +++ b/Sources/apiLOL/Controllers/ControllerChampions.cs @@ -32,9 +32,8 @@ namespace apiLOL.Controllers [Route("{name}")] public async Task GetChampion(string name) { - var champs = (await data.ChampionsMgr.GetItems(0, await data.ChampionsMgr.GetNbItems())).First(i => i.Name == name); - ChampionDTO result = champs.ToDTO(); - return Ok(champs); + var champs = (await data.ChampionsMgr.GetItemsByName(name,0,1)).First(); + return Ok(champs.ToDTO()); }