From a87d611c4f96d74bc9804da19826d2f66255060a Mon Sep 17 00:00:00 2001
From: Corentin LEMAIRE <corentin.lemaire@etu.uca.fr>
Date: Sun, 14 May 2023 21:43:53 +0200
Subject: [PATCH] Fix Critical issues

---
 Sources/Model/InfoTitle.cs                    |  2 +-
 Sources/Model/Manager.cs                      | 20 ++++++++---------
 Sources/Model/Playlist.cs                     |  2 +-
 .../Serialization/LINQ_XML_Serialization.cs   | 22 +++++++++----------
 4 files changed, 23 insertions(+), 23 deletions(-)

diff --git a/Sources/Model/InfoTitle.cs b/Sources/Model/InfoTitle.cs
index a3483c7..444a6ff 100644
--- a/Sources/Model/InfoTitle.cs
+++ b/Sources/Model/InfoTitle.cs
@@ -40,7 +40,7 @@ public class InfoTitle : Title
     {
         get
         {
-            return feat.ToList();
+            return new List<Artist>(feat);
         }
     }
 
diff --git a/Sources/Model/Manager.cs b/Sources/Model/Manager.cs
index 08c405c..a084883 100644
--- a/Sources/Model/Manager.cs
+++ b/Sources/Model/Manager.cs
@@ -2,15 +2,15 @@
 
 public class Manager
 {
-    public static int MAX_NAME_LENGTH = 75;
+    public readonly static int MAX_NAME_LENGTH = 75;
 
-    public static int MAX_DESCRIPTION_LENGTH = 500;
+    public readonly static int MAX_DESCRIPTION_LENGTH = 500;
 
-    public static string DEFAULT_NAME = "Unknown";
+    public readonly static string DEFAULT_NAME = "Unknown";
 
-    public static string DEFAULT_URL = "none.png";
+    public readonly static string DEFAULT_URL = "none.png";
 
-    public static string DEFAULT_DESC = "";
+    public readonly static string DEFAULT_DESC = "";
 
     public IDataManager DataManager { get; set; }
 
@@ -20,7 +20,7 @@ public class Manager
     {
         get
         {
-            return albums.ToList();
+            return new List<Album>(albums);
         }
     }
 
@@ -30,7 +30,7 @@ public class Manager
     {
         get
         {
-            return customTitles.ToList();
+            return new List<CustomTitle>(customTitles);
         }
     }
 
@@ -40,7 +40,7 @@ public class Manager
     {
         get
         {
-            return infoTitles.ToList();
+            return new List<InfoTitle>(infoTitles);
         }
     }
 
@@ -50,7 +50,7 @@ public class Manager
     {
         get
         {
-            return playlists.ToList();
+            return new List<Playlist>(playlists);
         }
     }
 
@@ -60,7 +60,7 @@ public class Manager
     {
         get
         {
-            return artists.ToList();
+            return new List<Artist>(artists);
         }
     }
 
diff --git a/Sources/Model/Playlist.cs b/Sources/Model/Playlist.cs
index 8488ebf..aa67ba3 100644
--- a/Sources/Model/Playlist.cs
+++ b/Sources/Model/Playlist.cs
@@ -105,7 +105,7 @@ public class Playlist
     {
         get
         {
-            return played.ToList();
+            return new List<int>(played);
         }
     }
 
diff --git a/Sources/Model/Serialization/LINQ_XML_Serialization.cs b/Sources/Model/Serialization/LINQ_XML_Serialization.cs
index e0e242f..c976886 100644
--- a/Sources/Model/Serialization/LINQ_XML_Serialization.cs
+++ b/Sources/Model/Serialization/LINQ_XML_Serialization.cs
@@ -31,7 +31,7 @@ public class LINQ_XML_Serialization : IDataManager
     {
         get
         {
-            return artists.ToList();
+            return new List<Artist>(artists);
         }
     }
 
@@ -41,7 +41,7 @@ public class LINQ_XML_Serialization : IDataManager
     {
         get
         {
-            return albums.ToList();
+            return new List<Album>(albums);
         }
     }
 
@@ -51,7 +51,7 @@ public class LINQ_XML_Serialization : IDataManager
     {
         get
         {
-            return playlists.ToList();
+            return new List<Playlist>(playlists);
         }
     }
 
@@ -61,7 +61,7 @@ public class LINQ_XML_Serialization : IDataManager
     {
         get
         {
-            return infoTitles.ToList();
+            return new List<InfoTitle>(infoTitles);
         }
     }
 
@@ -71,7 +71,7 @@ public class LINQ_XML_Serialization : IDataManager
     {
         get
         {
-            return customTitles.ToList();
+            return new List<CustomTitle>(customTitles);
         }
     }
 
@@ -582,11 +582,11 @@ public class LINQ_XML_Serialization : IDataManager
         else return Genre.K_POP;
     }
 
-    public InfoTitle? GetInfoTitleByUrl(string infoUrl)
+    public InfoTitle? GetInfoTitleByUrl(string url)
     {
         foreach(InfoTitle it in infoTitles)
         {
-            if (it.Name == infoUrl)
+            if (it.Name == url)
             {
                 return it;
             }
@@ -594,11 +594,11 @@ public class LINQ_XML_Serialization : IDataManager
         return null;
     }
 
-    public Artist? GetArtistByName(string artist)
+    public Artist? GetArtistByName(string name)
     {
         foreach(Artist a in artists)
         {
-            if (a.Name == artist)
+            if (a.Name == name)
             {
                 return a;
             }
@@ -606,11 +606,11 @@ public class LINQ_XML_Serialization : IDataManager
         return null;
     }
 
-    public Album? GetAlbumByUrl(string album)
+    public Album? GetAlbumByUrl(string url)
     {
         foreach(Album a in albums)
         {
-            if (a.ImageURL == album)
+            if (a.ImageURL == url)
             {
                 return a;
             }