quality review

master
Corentin R 2 years ago
parent b2b59223ec
commit f46b2d9aec

@ -43,34 +43,6 @@ namespace API_LoL.Controllers
}
else { return NoContent(); }
}
///else if peu important : on ne cherche pas des runes par famille ou description
//else if (!string.IsNullOrEmpty(desc))
//{
// var list = await RunesManager.GetItemsBySkill(desc, index, size);
// if (list.Count() != 0)
// {
// return Ok(list.Select(champion => champion?.ToDTO()));
// }
// else { return NoContent(); }
//}
//else if (!string.IsNullOrEmpty(Family))
//{
// var list = await RunesManager.GetItems(index, size);
// if (list.Count() != 0)
// {
// return Ok(list.Select(champion => champion?.ToDTO()));
// }
// else { return NoContent(); }
//}
//else if (!string.IsNullOrEmpty(Image))
//{
// var list = await RunesManager.GetItems(index, size);
// if (list.Count() != 0)
// {
// return Ok(list.Select(champion => champion?.ToDTO()));
// }
// else { return NoContent(); }
//}
else
{
var list = await RunesManager.GetItems(index, size);
@ -95,41 +67,6 @@ namespace API_LoL.Controllers
}
//[HttpGet("name/skins")]
//public async Task<IActionResult> GetSkinsByName(String name)
//{
// if (string.IsNullOrEmpty(name)) return BadRequest();
// var list = await RunesManager.GetItemsByName(name, 0, 1);
// if (list.Count() == 1)
// {
// var nb = await SkinsManager.GetNbItemsByChampion(list.First());
// if (nb != 0)
// {
// var skins = await SkinsManager.GetItemsByChampion(list.First(), 0, nb);
// return Ok(skins.Select(skin => skin?.ToDTO()));
// }
// else { return NoContent(); }
// }
// else { return NoContent(); }
//}
//[HttpGet("name/skills")]
//public async Task<IActionResult> GetSkillsByName(String name)
//{
// if (string.IsNullOrEmpty(name)) return BadRequest();
// var list = await RunesManager.GetItemsByName(name, 0, 1);
// if (list.Count() == 1)
// {
// var skins = await SkinsManager.GetItemsByChampion(list.First(), 0, await SkinsManager.GetNbItemsByChampion(list.First()));
// if (skins.Count() != 0)
// {
// return Ok(skins.Select(skin => skin?.ToDTO()));
// }
// else { return NoContent(); }
// }
// else { return NoContent(); }
//}
// POST api/<ChampionController>
@ -143,7 +80,7 @@ namespace API_LoL.Controllers
else
{
var champ = await RunesManager.GetItemsByName(rune.Name, 0, 1);
if (champ.Count() != 0 && champ.FirstOrDefault().Name == rune.Name)
if (champ.FirstOrDefault() != null && champ.Count() != 0 && champ.FirstOrDefault().Name == rune.Name)
{
return Conflict(rune);
}

@ -25,7 +25,7 @@ namespace ConsoleApplication
Console.WriteLine("\n 9 - Quitter");
}
public static async void championMenu(IChampionsManager championsManager ) {
public static async Task championMenu(IChampionsManager championsManager ) {
string choix = "0";
while (choix != "9")

Loading…
Cancel
Save