From 9a577959af33cafa4f2e19d199af456e9b0114e0 Mon Sep 17 00:00:00 2001 From: Lucas Delanier Date: Fri, 17 Mar 2023 23:41:27 +0100 Subject: [PATCH] clean code smells :cop: --- screens/HomeScreen.tsx | 11 ++++------- screens/InfoScreen.tsx | 10 ++-------- 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/screens/HomeScreen.tsx b/screens/HomeScreen.tsx index 912e1fc..e66b5e4 100644 --- a/screens/HomeScreen.tsx +++ b/screens/HomeScreen.tsx @@ -1,7 +1,7 @@ import * as React from 'react'; import {TouchableOpacity, View, Text, StyleSheet, Image, ImageBackground, SafeAreaView} from 'react-native'; import {RootStackScreenProps} from "../types"; -import {useEffect, useRef, useState} from "react"; +import {useEffect, useState} from "react"; import {useSafeAreaInsets} from "react-native-safe-area-context"; import {addMovieToWatchLater, addMovieToFavourite, removeMovieTrending,} from "../redux/actions/actions"; import {useDispatch, useSelector} from 'react-redux'; @@ -15,7 +15,7 @@ import {NewCard, SuggestedCard} from "../components/cards"; import {setFavouriteList,setWatchLaterList} from "../storage/storage" -export default function HomeScreen({navigation}: RootStackScreenProps<'Home'>) { +export default function HomeScreen({}: RootStackScreenProps<'Home'>) { // @ts-ignore const trendingMovies = useSelector(state => state.appReducer.trendingMovies) // @ts-ignore @@ -30,7 +30,7 @@ export default function HomeScreen({navigation}: RootStackScreenProps<'Home'>) { const [displayIndex, setdisplayIndex] = useState(0); const [suggestedMovies, setSuggestedMovies] = useState([]) - var swiper: any = null + let swiper: any = null const insets = useSafeAreaInsets() @@ -136,7 +136,7 @@ export default function HomeScreen({navigation}: RootStackScreenProps<'Home'>) { useEffect(() => { - const interval = setInterval(() => { + setInterval(() => { const today = moment() today.set({hour: 0, minute: 0, second: 0, millisecond: 0}) @@ -185,7 +185,6 @@ export default function HomeScreen({navigation}: RootStackScreenProps<'Home'>) { dispatch(addMovieToWatchLater(props)) dispatch(removeMovieTrending(props)) setWatchLaterList(newWatchLaterMovies) - console.log("movie: ", props.id, props.full_date, new Date(props.full_date).getTime()), new Date(trendingMovies[displayIndex].full_date).getTime() if (displayIndex == trendingMovies.length - 1) { setdisplayIndex(0) swiper.swipeLeft() @@ -202,9 +201,7 @@ export default function HomeScreen({navigation}: RootStackScreenProps<'Home'>) { else{ dispatch(addMovieToFavourite(props)) dispatch(removeMovieTrending(props)) - console.log(favouriteMovies) setFavouriteList(newFavouriteMovies) - console.log("movie: ", props.id, props.full_date, new Date(props.full_date).getTime()), new Date(trendingMovies[displayIndex].full_date).getTime() if (displayIndex == trendingMovies.length - 1) { setdisplayIndex(0) swiper.swipeLeft() diff --git a/screens/InfoScreen.tsx b/screens/InfoScreen.tsx index 9d7ac72..4afd8aa 100644 --- a/screens/InfoScreen.tsx +++ b/screens/InfoScreen.tsx @@ -1,5 +1,5 @@ import * as React from 'react'; -import {TouchableOpacity, ScrollView, View, Text, StyleSheet, Image, SafeAreaView, FlatList, Animated} from 'react-native'; +import {TouchableOpacity, ScrollView, View, Text, StyleSheet, Image, SafeAreaView, FlatList} from 'react-native'; import {RootStackScreenProps} from "../types"; import {useSafeAreaInsets} from "react-native-safe-area-context"; import Movie from "../model/Movie"; @@ -11,7 +11,6 @@ import Ionicons from "@expo/vector-icons/Ionicons"; import MinimalMovie from "../model/MinimalMovie"; import Review from "../model/review"; import Stars from "../components/StarsComponent"; -import minimalMovie from "../model/MinimalMovie"; import {formatTime} from "../model/formatTime"; export default function InfoScreen({navigation, route}: RootStackScreenProps<'Info'>) { @@ -80,7 +79,7 @@ export default function InfoScreen({navigation, route}: RootStackScreenProps<'In } type SimilarMovieProps = { - movie: minimalMovie; + movie: MinimalMovie; }; function SimilarMovie(props: SimilarMovieProps) { @@ -341,7 +340,6 @@ export default function InfoScreen({navigation, route}: RootStackScreenProps<'In const creditResponse = (await fetch(config.base_url + "movie/" + item.id + "/credits?api_key=" + config.api_key + "&language=fr-FR")); const creditJson = await creditResponse.json(); - //console.log("credittttttt", creditJson) // @ts-ignore let creditList = creditJson.cast.map((elt) => { if (elt["popularity"]) @@ -349,7 +347,6 @@ export default function InfoScreen({navigation, route}: RootStackScreenProps<'In }); creditList = creditList.slice(0, 5).sort((a: [fullname: string, profile_path: string, popularity: number], b: [fullname: string, profil_path: string, popularity: number]) => b[2] - a[2]); - //console.log("credit", creditList); setCredit(creditList); } const getSimilarMovies = async () => { @@ -360,7 +357,6 @@ export default function InfoScreen({navigation, route}: RootStackScreenProps<'In const SimilarMoviesList = SimilarMoviesJson.results.slice(0, 10).map((elt) => { return new MinimalMovie(elt["original_title"], elt["poster_path"]) }); - //console.log("similar", SimilarMoviesList); setSimilarMovies(SimilarMoviesList); } const getReview = async () => { @@ -375,8 +371,6 @@ export default function InfoScreen({navigation, route}: RootStackScreenProps<'In ReviewList = ReviewList.filter((review: Review, index: number, array: Review[]) => { return array.findIndex((item: Review) => item.pseudo === review.pseudo) === index; }); - - //console.log("review", ReviewJson.results); setReview(ReviewList); }