From 508e43fb359296211a1a679ed7a2461851961c30 Mon Sep 17 00:00:00 2001
From: "damien.nortier" <damien.nortier@etu.uca.fr>
Date: Sun, 24 Mar 2024 18:10:35 +0100
Subject: [PATCH] =?UTF-8?q?perf=20:=20suppression=20d'une=20m=C3=A9thode?=
 =?UTF-8?q?=20inutilis=C3=A9e?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 WebApi/DataManagers/AnswerDataManager.cs       |  5 -----
 WebApi/EntityManagers/AnswerEntityManager.cs   | 11 +++--------
 WebApi/ManagerInterfaces/IAnswerManager.cs     |  9 ---------
 WebApi/ServiceManagers/AnswerServiceManager.cs |  5 -----
 WebApi/WebApi/Unit.cs                          |  5 -----
 5 files changed, 3 insertions(+), 32 deletions(-)

diff --git a/WebApi/DataManagers/AnswerDataManager.cs b/WebApi/DataManagers/AnswerDataManager.cs
index d7ef7c8..f7e5c50 100644
--- a/WebApi/DataManagers/AnswerDataManager.cs
+++ b/WebApi/DataManagers/AnswerDataManager.cs
@@ -48,11 +48,6 @@ namespace DataManagers
             return await Task.FromResult<(int nbPages, IEnumerable<Answer>? answers)>((res.nbPages, tmp));
         }
 
-        public async Task<IEnumerable<Answer>?> getAnswers(string content)
-        {
-            return (await manager.getAnswers(content))?.Select(a => a.ToModel());
-        }
-
         public async Task<IEnumerable<Answer>?> getAnswersByIdQuestion(int id)
         {
             var tmp = await manager.getAnswersByIdQuestion(id);
diff --git a/WebApi/EntityManagers/AnswerEntityManager.cs b/WebApi/EntityManagers/AnswerEntityManager.cs
index f65274a..718e148 100644
--- a/WebApi/EntityManagers/AnswerEntityManager.cs
+++ b/WebApi/EntityManagers/AnswerEntityManager.cs
@@ -30,7 +30,7 @@ namespace EntityManagers
             }
             await dbContext.Answers.AddAsync(new AnswerEntity { Content = answer.Content.ToLower(), IdQuestion = answer.IdQuestion });
             await dbContext.SaveChangesAsync();
-            return await dbContext.Answers.Where(a => a.Content == answer.Content && a.IdQuestion == answer.IdQuestion).FirstAsync();
+            return await dbContext.Answers.Where(a => a.Content == answer.Content.ToLower() && a.IdQuestion == answer.IdQuestion).FirstAsync();
         }
 
         public async Task<AnswerEntity?> getAnswer(int id)
@@ -38,15 +38,10 @@ namespace EntityManagers
             return await dbContext.Answers.Where(a => a.Id == id).FirstOrDefaultAsync();
         }
 
-        public async Task<IEnumerable<AnswerEntity>?> getAnswers(string content)
-        {
-            return await Task.FromResult<IEnumerable<AnswerEntity>?>(dbContext.Answers.Where(a => a.Content == content));
-        }
-
         public async Task<(int nbPages, IEnumerable<AnswerEntity>? answers)> getAnswers(int page, int count, AnswerOrderCriteria orderCriteria = AnswerOrderCriteria.ById)
         {
             int nbEl = getNbAnswers();
-            if (page < 0 || count < 0 || page > nbEl / count)
+            if (page <= 0 || count <= 0 || page > nbEl / count)
             {
                 return await Task.FromResult<(
                     int nbPages,
@@ -112,7 +107,7 @@ namespace EntityManagers
 
         public async Task<AnswerEntity?> updateAnswer(int id, AnswerEntity answer)
         {
-            var tmp = await dbContext.Answers.Where(a => a.Id == id).FirstOrDefaultAsync();
+            var tmp = await getAnswer(id);
             if(tmp == null)
             {
                 return null;
diff --git a/WebApi/ManagerInterfaces/IAnswerManager.cs b/WebApi/ManagerInterfaces/IAnswerManager.cs
index 96cd5fe..20d541a 100644
--- a/WebApi/ManagerInterfaces/IAnswerManager.cs
+++ b/WebApi/ManagerInterfaces/IAnswerManager.cs
@@ -81,14 +81,5 @@ namespace ManagerInterfaces
         /// to the id or null if there isn't any
         /// </returns>
         public Task<T?> getAnswer(int id);
-        /// <summary>
-        /// get answers
-        /// </summary>
-        /// <param name="content">the content of the answer</param>
-        /// <returns>
-        /// the answer that corresponde
-        /// to the content or null if there isn't any
-        /// </returns>
-        public Task<IEnumerable<T>?> getAnswers(string content);
     }
 }
\ No newline at end of file
diff --git a/WebApi/ServiceManagers/AnswerServiceManager.cs b/WebApi/ServiceManagers/AnswerServiceManager.cs
index 7188860..e4f88e4 100644
--- a/WebApi/ServiceManagers/AnswerServiceManager.cs
+++ b/WebApi/ServiceManagers/AnswerServiceManager.cs
@@ -78,10 +78,5 @@ namespace ServiceManagers
         {
             return (await manager.updateAnswer(id, answerdto.ToModel()))?.ToDto();
         }
-
-        public async Task<IEnumerable<AnswerDto>?> getAnswers(string content)
-        {
-            return (await manager.getAnswers(content))?.Select(a => a.ToDto());
-        }
     }
 }
diff --git a/WebApi/WebApi/Unit.cs b/WebApi/WebApi/Unit.cs
index e7deba3..c17fc33 100644
--- a/WebApi/WebApi/Unit.cs
+++ b/WebApi/WebApi/Unit.cs
@@ -92,11 +92,6 @@ namespace WebApi
             return AnswerManager.getAnswers(nb, count, orderCriteria);
         }
 
-        public Task<IEnumerable<AnswerDto>?> getAnswers(string content)
-        {
-            return AnswerManager.getAnswers(content);
-        }
-
         public Task<IEnumerable<AnswerDto>?> getAnswersByIdQuestion(int id)
         {
             return AnswerManager.getAnswersByIdQuestion(id);