From a51901e2258c7e90db590ea5d06afc3175bc1540 Mon Sep 17 00:00:00 2001
From: "Jade.VAN_BRABANDT" <Jade.VAN_BRABANDT@etu.uca.fr>
Date: Tue, 9 Jan 2024 11:22:06 +0100
Subject: [PATCH] CI : fix code smells

---
 .../Pages/Questions/AddQuestion.razor.cs       |  6 +++---
 .../Pages/Questions/EditQuestion.razor.cs      |  9 ++++-----
 .../Blazor/Pages/Questions/Questions.razor.cs  | 18 +++++++++---------
 3 files changed, 16 insertions(+), 17 deletions(-)

diff --git a/Blazor/Blazor/Pages/Questions/AddQuestion.razor.cs b/Blazor/Blazor/Pages/Questions/AddQuestion.razor.cs
index aed7c3e..0af3414 100644
--- a/Blazor/Blazor/Pages/Questions/AddQuestion.razor.cs
+++ b/Blazor/Blazor/Pages/Questions/AddQuestion.razor.cs
@@ -10,13 +10,13 @@ namespace Blazor.Pages.Questions
         private QuestionModel questionModel = new();
 
         [Inject]
-        public IDataService DataService { get; set; }
+        public required IDataService DataService { get; set; }
 
         [Inject]
-        public NavigationManager NavigationManager { get; set; }
+        public required NavigationManager NavigationManager { get; set; }
 
         [Inject]
-        public ILogger<AddAdministrator> Logger { get; set; }
+        public required ILogger<AddAdministrator> Logger { get; set; }
 
 
         private async Task HandleValidSubmit()
diff --git a/Blazor/Blazor/Pages/Questions/EditQuestion.razor.cs b/Blazor/Blazor/Pages/Questions/EditQuestion.razor.cs
index cf43cfc..897312c 100644
--- a/Blazor/Blazor/Pages/Questions/EditQuestion.razor.cs
+++ b/Blazor/Blazor/Pages/Questions/EditQuestion.razor.cs
@@ -1,5 +1,4 @@
 using Blazor.Models;
-using Blazor.Pages.Admins;
 using Blazor.Services;
 using Microsoft.AspNetCore.Components;
 
@@ -14,16 +13,16 @@ namespace Blazor.Pages.Questions
         private QuestionModel questionModel = new();
 
         [Inject]
-        public IDataService DataService { get; set; }
+        public required IDataService DataService { get; set; }
 
         [Inject]
-        public NavigationManager NavigationManager { get; set; }
+        public required NavigationManager NavigationManager { get; set; }
 
         [Inject]
-        public IWebHostEnvironment WebHostEnvironment { get; set; }
+        public required IWebHostEnvironment WebHostEnvironment { get; set; }
 
         [Inject]
-        public ILogger<EditQuestion> Logger { get; set; }
+        public required ILogger<EditQuestion> Logger { get; set; }
 
 
         private async Task HandleValidSubmit()
diff --git a/Blazor/Blazor/Pages/Questions/Questions.razor.cs b/Blazor/Blazor/Pages/Questions/Questions.razor.cs
index 6ab7d94..8236906 100644
--- a/Blazor/Blazor/Pages/Questions/Questions.razor.cs
+++ b/Blazor/Blazor/Pages/Questions/Questions.razor.cs
@@ -17,28 +17,28 @@ namespace Blazor.Pages.Questions;
 
 public partial class Questions
 {
-    public List<Question> questions;
+    public List<Question> questions = new();
 
     private int totalQuestion;
 
     [Inject]
-    public NavigationManager NavigationManager { get; set; }
+    public required NavigationManager NavigationManager { get; set; }
 
     [CascadingParameter]
-    public IModalService Modal { get; set; }
+    public required IModalService Modal { get; set; }
 
     [Inject]
-    public IDataService DataService { get; set; }
-    public IWebHostEnvironment WebHostEnvironment { get; set; }
+    public required IDataService DataService { get; set; }
+    public required IWebHostEnvironment WebHostEnvironment { get; set; }
 
     [Inject]
-    public HttpClient Http { get; set; }
+    public required HttpClient Http { get; set; }
 
     [Inject]
-    public ILocalStorageService LocalStorage { get; set; }
+    public required ILocalStorageService LocalStorage { get; set; }
 
     [Inject]
-    public IJSRuntime IJSRuntime { get; set; }
+    public required IJSRuntime IJSRuntime { get; set; }
 
     private async void OnDelete(int id)
     {
@@ -82,7 +82,7 @@ public partial class Questions
         
         var response = Http.GetFromJsonAsync<Question[]>(API.API_URL+"questions/"+API.TOKEN).Result;
 
-        if (!e.CancellationToken.IsCancellationRequested)
+        if (!e.CancellationToken.IsCancellationRequested && response != null)
         {
             questions = new List<Question>(response); // an actual data for the current page