From c45e859e83b009bd728f2fd688808b2507117b8b Mon Sep 17 00:00:00 2001
From: "jules.lascret" <jules.lascret@etu.uca.fr>
Date: Fri, 7 Jun 2024 16:58:21 +0200
Subject: [PATCH] fix some code smells

---
 Qwirkle/QwirkleClassLibrary/Games/Game.cs | 22 ++++++----------------
 1 file changed, 6 insertions(+), 16 deletions(-)

diff --git a/Qwirkle/QwirkleClassLibrary/Games/Game.cs b/Qwirkle/QwirkleClassLibrary/Games/Game.cs
index 9543a70..9e5bf92 100644
--- a/Qwirkle/QwirkleClassLibrary/Games/Game.cs
+++ b/Qwirkle/QwirkleClassLibrary/Games/Game.cs
@@ -552,7 +552,7 @@ namespace QwirkleClassLibrary.Games
             return false;
         }
 
-        public static bool CheckTileInCompletedLines(Tile? t1, Tile? t2, ref int nbTiles, ref List<Tile> checkdoubles)
+        public static bool CheckTileInCompletedLines(Tile? t1, ref int nbTiles, ref List<Tile> checkdoubles)
         {
             if (t1 != null)
             {
@@ -565,19 +565,7 @@ namespace QwirkleClassLibrary.Games
 
                 checkdoubles.Add(t1);
             }
-
-            if (t2 == null) return true;
-            {
-                nbTiles++;
-
-                if (checkdoubles.Any(t => t.CompareTo(t2) == 0))
-                {
-                    return false;
-                }
-
-                checkdoubles.Add(t2);
-            }
-
+            
             return true;
         }
         
@@ -594,8 +582,10 @@ namespace QwirkleClassLibrary.Games
                 {
                     break;
                 }
-                
-                return CheckTileInCompletedLines(extendedCell?.Tile, extendedCell2?.Tile, ref nbTiles, ref checkdoubles);
+
+                if(!CheckTileInCompletedLines(extendedCell?.Tile, ref nbTiles, ref checkdoubles)) return false;
+                       
+                if(!CheckTileInCompletedLines(extendedCell2?.Tile, ref nbTiles, ref checkdoubles)) return false;
             }
             
             return nbTiles <= 6;