From 004a7c190cbf5e3f8bfbf490fe8676e9de1ec192 Mon Sep 17 00:00:00 2001 From: rportet Date: Mon, 3 Jun 2024 19:03:23 +0200 Subject: [PATCH] code smell bye bye --- Qwirkle/QwirkleClassLibrary/Games/Game.cs | 8 ++++---- Qwirkle/QwirkleClassLibrary/Players/Player.cs | 2 +- Qwirkle/QwirkleClassLibrary/Tiles/TileBag.cs | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Qwirkle/QwirkleClassLibrary/Games/Game.cs b/Qwirkle/QwirkleClassLibrary/Games/Game.cs index cab223f..f4729b8 100644 --- a/Qwirkle/QwirkleClassLibrary/Games/Game.cs +++ b/Qwirkle/QwirkleClassLibrary/Games/Game.cs @@ -27,7 +27,7 @@ namespace QwirkleClassLibrary.Games public bool GameRunning { get; set; } [DataMember] - private Board board = new Board(15, 12); + private Board board = new(15, 12); public bool PlayerSwapping { get; set; } public Board Board => board; @@ -35,15 +35,15 @@ namespace QwirkleClassLibrary.Games public ReadOnlyCollection PlayerList => players.AsReadOnly(); [DataMember] - private readonly List players = new(); + private readonly List players = []; [DataMember] - private readonly Dictionary scoreBoard = new(); + private readonly Dictionary scoreBoard = []; public ReadOnlyDictionary ScoreBoard => scoreBoard.AsReadOnly(); [DataMember] - private readonly List cellUsed = new(); + private readonly List cellUsed = []; public ReadOnlyCollection CellsUsed => cellUsed.AsReadOnly(); diff --git a/Qwirkle/QwirkleClassLibrary/Players/Player.cs b/Qwirkle/QwirkleClassLibrary/Players/Player.cs index 0274620..5d8cb7a 100644 --- a/Qwirkle/QwirkleClassLibrary/Players/Player.cs +++ b/Qwirkle/QwirkleClassLibrary/Players/Player.cs @@ -37,7 +37,7 @@ namespace QwirkleClassLibrary.Players } NameTag = name; - Tiles = new ObservableCollection(); + Tiles = []; } [DataMember] diff --git a/Qwirkle/QwirkleClassLibrary/Tiles/TileBag.cs b/Qwirkle/QwirkleClassLibrary/Tiles/TileBag.cs index fc6381a..44c7129 100644 --- a/Qwirkle/QwirkleClassLibrary/Tiles/TileBag.cs +++ b/Qwirkle/QwirkleClassLibrary/Tiles/TileBag.cs @@ -12,7 +12,7 @@ namespace QwirkleClassLibrary.Tiles public class TileBag { [DataMember] - private readonly List tiles = new List(); + private readonly List tiles = []; public ReadOnlyCollection TilesBag { get; private set; } @@ -35,7 +35,7 @@ namespace QwirkleClassLibrary.Tiles { foreach (Color c in Enum.GetValues(typeof(Color))) { - Tile t = new Tile(s, c); + Tile t = new(s, c); tiles.Add(t); } }