From 5686b7267a13b96c340962da1ba7b5995efac37b Mon Sep 17 00:00:00 2001
From: clchieu <clement.chieu@etu.uca.Fr>
Date: Fri, 15 Mar 2024 17:07:01 +0100
Subject: [PATCH] =?UTF-8?q?Am=C3=A9lioration=20du=20code?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../Service/InquiryDataService.cs             |   2 +-
 .../Service/LessonDataService.cs              |   2 +-
 .../Service/ParagraphDataService.cs           |   2 +-
 API_SQLuedo/Shared/SuccessDataService.cs      | 103 ------------------
 4 files changed, 3 insertions(+), 106 deletions(-)
 delete mode 100644 API_SQLuedo/Shared/SuccessDataService.cs

diff --git a/API_SQLuedo/DbDataManager/Service/InquiryDataService.cs b/API_SQLuedo/DbDataManager/Service/InquiryDataService.cs
index df9c2ce..8244c63 100644
--- a/API_SQLuedo/DbDataManager/Service/InquiryDataService.cs
+++ b/API_SQLuedo/DbDataManager/Service/InquiryDataService.cs
@@ -37,7 +37,7 @@ public class InquiryDataService : IInquiryService<InquiryEntity>
         }
 
         var inquiries = query.ToList();
-        return inquiries.Select(s => s);
+        return inquiries;
     }
 
     public InquiryEntity GetInquiryById(int id)
diff --git a/API_SQLuedo/DbDataManager/Service/LessonDataService.cs b/API_SQLuedo/DbDataManager/Service/LessonDataService.cs
index c932f74..41838ad 100644
--- a/API_SQLuedo/DbDataManager/Service/LessonDataService.cs
+++ b/API_SQLuedo/DbDataManager/Service/LessonDataService.cs
@@ -37,7 +37,7 @@ public class LessonDataService : ILessonService<LessonEntity>
         }
 
         var lessons = query.ToList();
-        return lessons.Select(s => s);
+        return lessons;
     }
 
     public LessonEntity GetLessonById(int id)
diff --git a/API_SQLuedo/DbDataManager/Service/ParagraphDataService.cs b/API_SQLuedo/DbDataManager/Service/ParagraphDataService.cs
index fa92a29..d50e0fb 100644
--- a/API_SQLuedo/DbDataManager/Service/ParagraphDataService.cs
+++ b/API_SQLuedo/DbDataManager/Service/ParagraphDataService.cs
@@ -43,7 +43,7 @@ public class ParagraphDataService : IParagraphService<ParagraphEntity>
         }
 
         var paragraphs = query.ToList();
-        return paragraphs.Select(s => s);
+        return paragraphs;
     }
 
     public ParagraphEntity GetParagraphById(int id)
diff --git a/API_SQLuedo/Shared/SuccessDataService.cs b/API_SQLuedo/Shared/SuccessDataService.cs
deleted file mode 100644
index f2f7b88..0000000
--- a/API_SQLuedo/Shared/SuccessDataService.cs
+++ /dev/null
@@ -1,103 +0,0 @@
-using Entities;
-using Microsoft.EntityFrameworkCore;
-using Dto;
-using DbContextLib;
-using Model.OrderCriteria;
-using Shared.Mapper;
-
-namespace Shared;
-
-public class SuccessDataService : ISuccessDataService
-{
-    private UserDbContext DbContext { get; set; }
-    public SuccessDataService(UserDbContext context)
-    {
-        DbContext = context;
-        context.Database.EnsureCreated();
-    }
-    public IEnumerable<SuccessDTO> GetSuccesses(int page, int number, SuccessOrderCriteria orderCriteria)
-    {
-        IQueryable<SuccessEntity> query = DbContext.Successes.Skip((page - 1) * number).Take(number);
-        switch (orderCriteria)
-        {
-            case SuccessOrderCriteria.None:
-                break;
-            case SuccessOrderCriteria.ByUserId:
-                query = query.OrderBy(s => s.UserId);
-                break;
-            case SuccessOrderCriteria.ByInquiryId:
-                query = query.OrderBy(s => s.InquiryId);
-                break;
-            case SuccessOrderCriteria.ByIsFinished:
-                query = query.OrderBy(s => s.IsFinished);
-                break;
-            default:
-                break;
-        }
-        var successes = query.ToList();
-        return successes.Select(s => s.FromEntityToDTO());
-    }
-
-    public SuccessDTO GetSuccessByUserId(int id)
-    {
-        var userEntity = DbContext.Successes.FirstOrDefault(u => u.UserId == id);
-        if (userEntity == null)
-        {
-            throw new ArgumentException("Impossible de trouver le succès", nameof(id));
-        }
-
-        return userEntity.FromEntityToDTO();
-    }
-
-    public SuccessDTO GetSuccessByInquiryId(int id)
-    {
-        var userEntity = DbContext.Successes.FirstOrDefault(u => u.InquiryId == id);
-        if (userEntity == null)
-        {
-            throw new ArgumentException("Impossible de trouver le succès", nameof(id));
-        }
-
-        return userEntity.FromEntityToDTO();
-    }
-
-    public bool DeleteSuccess(int id)
-    {
-        var successEntity = DbContext.Successes.FirstOrDefault(u => u.UserId == id);
-        if (successEntity == null)
-        {
-            return false;
-        }
-
-        DbContext.Successes.Remove(successEntity);
-        DbContext.SaveChangesAsync();
-        return true;
-    }
-
-    public SuccessDTO UpdateSuccess(int id, SuccessDTO success)
-    {
-        var updatingSuccess = DbContext.Successes.FirstOrDefault(u => u.UserId == id);
-        if (updatingSuccess == null)
-        {
-            throw new ArgumentException("Impossible de trouver le succès", nameof(id));
-        }
-
-        updatingSuccess.UserId = success.UserId;
-        updatingSuccess.InquiryId = success.InquiryId;
-        updatingSuccess.IsFinished = success.IsFinished;
-        DbContext.SaveChangesAsync();
-        return updatingSuccess.FromEntityToDTO();
-    }
-
-    public SuccessDTO CreateSuccess(int userId, int inquiryId, bool isFinished)
-    {
-        var newSuccessEntity = new SuccessDTO()
-        {
-            UserId = userId,
-            InquiryId = inquiryId,
-            IsFinished = isFinished,
-        };
-        DbContext.Successes.Add(newSuccessEntity.FromDTOToEntity());
-        DbContext.SaveChangesAsync();
-        return newSuccessEntity;
-    }
-}
\ No newline at end of file