fix bugs

LocalServices/Data/CatastrophicPerformancesDatabase.cs

@@ -143,43 +143,12 @@ namespace LocalServices.Data
             return JsonSerializer.Deserialize<Dictionary<K, V>>(text);
         }
 
-        private async void Save<K, T>(string fileName, Dictionary<K, T> dict)
+        private void Save<K, T>(string fileName, Dictionary<K, T> dict)
         {
             string json = JsonSerializer.Serialize(dict);
-            using (var stream = WaitForFile(dbPath + "/" + fileName, FileMode.Open, FileAccess.Write, FileShare.Write))
-            {
-                var bytes = Encoding.ASCII.GetBytes(json);
-                await stream.WriteAsync(bytes, 0, bytes.Length);
-            }
-        }
-
-        // This is a workaround function to wait for a file to be released before opening it.
-        // This was to fix the Save method that used to throw sometimes as the file were oftenly being scanned by the androids' antivirus.
-        // Simply wait until the file is released and return it. This function will never return until
-        private static FileStream WaitForFile(string fullPath, FileMode mode, FileAccess access, FileShare share)
-        {
-            for (int attempt = 0 ; attempt < 40; attempt++)
-            {
-                FileStream? fs = null;
-                try
-                {
-                    fs = new FileStream(fullPath, mode, access, share);
-                    return fs;
-                }
-                catch (FileNotFoundException e)
-                {
-                    throw e;
-                }
-                catch (IOException e)
-                {
-                    Debug.WriteLine(e.Message + " in thread " + Thread.CurrentThread.Name + " " + Thread.CurrentThread.ManagedThreadId);
-                    if (fs != null)
-                        fs.Dispose();
-
-                    Thread.Sleep(200);
-                }
-            }
-            throw new TimeoutException("Could not access file '" + fullPath + "', maximum attempts reached.");
+            Debug.WriteLine(json);
+
+            File.WriteAllText(dbPath + "/" + fileName, json);
         }
     }
 }

Views/Components/OwnedRecipeView.xaml.cs

@@ -18,6 +18,7 @@ public partial class OwnedRecipeView : ContentView
         BindingContext = info;
         this.clickCallback = onClickCallback;
         this.removeCallback = onRemoveCallback;
+        this.recipeInfo = info;
     }
 
     public bool IsViewing(RecipeInfo info)

Views/MyRecipesPage.xaml.cs

@@ -1,82 +1,84 @@
-using Services;
-using Services;
-using Models;
-using ShoopNCook.Views;
-
-namespace ShoopNCook.Pages;
-
-public partial class MyRecipesPage : ContentPage
-{
-
-    private IRecipesService service;
-    private Account account;
-
-	public MyRecipesPage(
-            Account account,
-            IRecipesService service)
-    {
-        InitializeComponent();
-
-        this.service = service;
-        this.account = account;
-
-        service
-            .GetRecipesOf(account)
-            .GetAccountRecipes()
-            .ForEach(AddRecipeView);
-    }
-
-    private void AddRecipeView(RecipeInfo info)
-    {
-        RecipesLayout.Children.Add(new OwnedRecipeView(info, () =>
-        {
-            Recipe recipe = service.GetRecipe(info);
-            IAccountRecipesPreferencesService preferences = service.GetPreferencesOf(account);
-            Shell.Current.Navigation.PushAsync(new RecipePage(recipe, preferences, 1));
-        },
-            () => RemoveRecipe(info)
-        ));
-    }
-
-    private void RemoveRecipe(RecipeInfo info)
-    {
-        IAccountOwnedRecipesService recipes = service.GetRecipesOf(account);
-
-        if (!recipes.RemoveRecipe(info))
-        {
-            UserNotifier.Error("Could not remove recipe");
-            return;
-        }
-        foreach (OwnedRecipeView view in RecipesLayout.Children)
-        {
-            if (view.IsViewing(info))
-            {
-                RecipesLayout.Remove(view);
-                break;
-            }
-        }
-        UserNotifier.Success("Recipe successfully removed");
-    }
-
-    private async void OnBackButtonClicked(object sender, EventArgs e)
-    {
-        await Navigation.PopAsync();
-    }
-    private async void OnAddRecipeButtonClicked(object sender, EventArgs e)
-    {
-        IAccountOwnedRecipesService recipes = service.GetRecipesOf(account);
-
-        var page = new CreateRecipePage(account.User, recipe =>
-        {
-            if (!recipes.UploadRecipe(recipe))
-            {
-                UserNotifier.Error("Could not upload recipe.");
-                return;
-            }
-            UserNotifier.Success("Recipe Successfuly uploaded !");
-            AddRecipeView(recipe.Info);
-            Shell.Current.Navigation.PopAsync(); //go back to current recipe page.
-        });
-        Shell.Current.Navigation.PushAsync(page); //display RecipePage editor
-    }
+using Services;
+using Models;
+using ShoopNCook.Views;
+
+namespace ShoopNCook.Pages;
+
+public partial class MyRecipesPage : ContentPage
+{
+
+    private IRecipesService service;
+    private Account account;
+
+	public MyRecipesPage(Account account, IRecipesService service)
+    {
+        InitializeComponent();
+
+        this.service = service;
+        this.account = account;
+
+        service
+            .GetRecipesOf(account)
+            .GetAccountRecipes()
+            .ForEach(AddRecipeView);
+    }
+
+    private void AddRecipeView(RecipeInfo info)
+    {
+        RecipesLayout.Children.Add(new OwnedRecipeView(info, () =>
+        {
+            Recipe? recipe = service.GetRecipe(info);
+            if (recipe == null)
+            {
+                UserNotifier.Error("Could not find recipe");
+                return;
+            }
+            IAccountRecipesPreferencesService preferences = service.GetPreferencesOf(account);
+            Shell.Current.Navigation.PushAsync(new RecipePage(recipe, preferences, 1));
+        },
+            () => RemoveRecipe(info)
+        ));
+    }
+
+    private void RemoveRecipe(RecipeInfo info)
+    {
+        IAccountOwnedRecipesService recipes = service.GetRecipesOf(account);
+
+        if (!recipes.RemoveRecipe(info))
+        {
+            UserNotifier.Error("Could not remove recipe");
+            return;
+        }
+        foreach (OwnedRecipeView view in RecipesLayout.Children)
+        {
+            if (view.IsViewing(info))
+            {
+                RecipesLayout.Remove(view);
+                break;
+            }
+        }
+        UserNotifier.Success("Recipe successfully removed");
+    }
+
+    private async void OnBackButtonClicked(object sender, EventArgs e)
+    {
+        await Navigation.PopAsync();
+    }
+    private async void OnAddRecipeButtonClicked(object sender, EventArgs e)
+    {
+        IAccountOwnedRecipesService recipes = service.GetRecipesOf(account);
+
+        var page = new CreateRecipePage(account.User, recipe =>
+        {
+            if (!recipes.UploadRecipe(recipe))
+            {
+                UserNotifier.Error("Could not upload recipe.");
+                return;
+            }
+            UserNotifier.Success("Recipe Successfuly uploaded !");
+            AddRecipeView(recipe.Info);
+            Shell.Current.Navigation.PopAsync(); //go back to current recipe page.
+        });
+        Shell.Current.Navigation.PushAsync(page); //display RecipePage editor
+    }
 }