From 3a746bb711f1a8277ff7d69bb783754eefb75a84 Mon Sep 17 00:00:00 2001
From: ludelanier <lucas.delanier@etu.uca.fr>
Date: Tue, 14 May 2024 19:24:24 +0200
Subject: [PATCH] fix icon and sonar code smells

---
 index.html                         | 2 +-
 src/App.vue                        | 3 ++-
 src/components/ExperienceCell.vue  | 3 ++-
 src/components/GridSkill.vue       | 4 +++-
 src/components/HeaderContainer.vue | 3 ++-
 src/components/ProjectShow.vue     | 3 ++-
 6 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/index.html b/index.html
index 7eab9b6..6f6e3a7 100644
--- a/index.html
+++ b/index.html
@@ -6,7 +6,7 @@
     <link href="//fonts.googleapis.com/css2?family=Sofia+Sans:ital,wght@0,1..1000;1,1..1000&display=swap"
           rel="stylesheet">
     <meta charset="UTF-8" />
-    <link rel="icon" type="image/svg+xml" href="/vite.svg" />
+    <link rel="icon" type="image/png" href="/images/picture.png" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Portfolio</title>
     <link rel="stylesheet" href="src/style.css">
diff --git a/src/App.vue b/src/App.vue
index d85b395..5e2d777 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -157,7 +157,8 @@ onUnmounted(() => {
     <GridSkill class="mx-8 sm:mx-28 py-28"/>
   </div>
   <ShowcaseBanner>
-      <img v-for="langage in langages" :src="`https://codefirst.iut.uca.fr/containers/lucasdelanier-portfolio/images/${ langage.image}`"
+      <img v-for="langage in langages"
+           :src="`https://codefirst.iut.uca.fr/containers/lucasdelanier-portfolio/images/${ langage.image}`"
            class="w-18 h-18 hover:-translate-y-1 transition-all duration-300 ease-in-out hover:rotate-12 origin-center"
            :alt="langage.name" width="64" height="64"/>
   </ShowcaseBanner>
diff --git a/src/components/ExperienceCell.vue b/src/components/ExperienceCell.vue
index e76aa1c..dd58ecd 100644
--- a/src/components/ExperienceCell.vue
+++ b/src/components/ExperienceCell.vue
@@ -19,7 +19,8 @@ const props = defineProps({
       <InfoBuble>{{ props.year }}</InfoBuble>
       <InfoBuble>{{ props.duration }}</InfoBuble>
     </div>
-    <img :src="`https://codefirst.iut.uca.fr/containers/lucasdelanier-portfolio/images/${ props.image }`" class="object-contain mb-6"
+    <img :src="`https://codefirst.iut.uca.fr/containers/lucasdelanier-portfolio/images/${ props.image }`"
+         class="object-contain mb-6"
          :class=" props.important === true ? 'h-24' : 'h-10'" :alt="`logo de l'entreprise ${props.company}`">
     <p class="text-xl text-gray-500" v-html="props.description"/>
 
diff --git a/src/components/GridSkill.vue b/src/components/GridSkill.vue
index 3bd64b2..2991981 100644
--- a/src/components/GridSkill.vue
+++ b/src/components/GridSkill.vue
@@ -46,7 +46,9 @@ const skills = [
 <template>
   <div class="grid gap-5 xl:grid-cols-3 md:grid-cols-2 sm:grid-cols-1 grid-cols-1">
     <SkillCell v-for="(skill, index) in skills" :key="index" :title="skill.title" :text="skill.text" class="group">
-      <img :src="`https://codefirst.iut.uca.fr/containers/lucasdelanier-portfolio/images/${skill.image}.png`" :height="60" :width="60"
+      <img :src="`https://codefirst.iut.uca.fr/containers/lucasdelanier-portfolio/images/${skill.image}.png`"
+           :height="60"
+           :width="60"
            class="h-7 w-7 group-hover:scale-110 transition-all ease-in duration-500 group-hover:brightness-200"
            :alt="skill.alt">
     </SkillCell>
diff --git a/src/components/HeaderContainer.vue b/src/components/HeaderContainer.vue
index 503d830..7067a37 100644
--- a/src/components/HeaderContainer.vue
+++ b/src/components/HeaderContainer.vue
@@ -6,7 +6,8 @@ import {Vue3Lottie} from "vue3-lottie";
 import CopyJson from '../assets/lotties/Animation - 1714933994295.json'
 import { ref } from "vue";
 function openCV(){
-  window.open('https://codefirst.iut.uca.fr/containers/lucasdelanier-portfolio/files/cv.pdf', '_blank');
+  window.open('https://codefirst.iut.uca.fr/containers/lucasdelanier-portfolio/files/cv.pdf', '_blank',
+      "noopener");
 }
 const copyAnimation = ref(null)
 const display = ref(false)
diff --git a/src/components/ProjectShow.vue b/src/components/ProjectShow.vue
index 3d91dd2..b39de36 100644
--- a/src/components/ProjectShow.vue
+++ b/src/components/ProjectShow.vue
@@ -29,7 +29,8 @@ watch(() => props.progress, (progress) => {
       </div>
     </div>
     <div class="flex h-[70vh] lg:h-screen flex-1 justify-center lg:items-center p-4 transform-container-2">
-      <img :src="`https://codefirst.iut.uca.fr/containers/lucasdelanier-portfolio/images/${ props.image}`" class="w-full h-full object-contain p-20"
+      <img :src="`https://codefirst.iut.uca.fr/containers/lucasdelanier-portfolio/images/${ props.image}`"
+           class="w-full h-full object-contain p-20"
            :alt="`screenshot de ${props.application}`">
     </div>
   </div>