room #4

Merged
clement.freville2 merged 7 commits from room into main 1 year ago
Owner
There is no content yet.
bastien.ollier added 2 commits 1 year ago
continuous-integration/drone/push Build is passing Details
f718747294
add route /live
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
b0cb3285fb
add live
bastien.ollier requested review from clement.freville2 1 year ago
bastien.ollier added 1 commit 1 year ago
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
e62b74482e
delete console.log
clement.freville2 requested changes 1 year ago
src/server.ts Outdated
let updates: Update[] = [];
let doc = Text.of(['']);
const liveClients: WebSocket[] = [];
let doc = Text.of(["foo"]);

Each room should use a different document.

Each room should use a different document.
clement.freville2 marked this conversation as resolved
src/server.ts Outdated
clientID: update.clientID,
changes: update.changes.toJSON(),
})),
);

This code is too much indented.

This code is too much indented.
Poster
Owner

it was good 😄 you are wrong

it was good 😄 you are wrong
clement.freville2 marked this conversation as resolved
bastien.ollier added 1 commit 1 year ago
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
d60f9c5c66
update live path
bastien.ollier requested review from clement.freville2 1 year ago
bastien.ollier removed review request for clement.freville2 1 year ago
bastien.ollier requested review from clement.freville2 1 year ago
bastien.ollier requested review from clement.freville2 1 year ago
bastien.ollier removed review request for clement.freville2 1 year ago
bastien.ollier removed review request for clement.freville2 1 year ago
bastien.ollier requested review from clement.freville2 1 year ago
bastien.ollier requested review from clement.freville2 1 year ago
bastien.ollier requested review from clement.freville2 1 year ago
bastien.ollier removed review request for clement.freville2 1 year ago
bastien.ollier removed review request for clement.freville2 1 year ago
bastien.ollier removed review request for clement.freville2 1 year ago
bastien.ollier requested review from clement.freville2 1 year ago
bastien.ollier removed review request for clement.freville2 1 year ago
bastien.ollier added 1 commit 1 year ago
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
e8d57a208a
add multiroom
bastien.ollier requested review from clement.freville2 1 year ago
bastien.ollier added 1 commit 1 year ago
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
ea4160cb6d
add multiroom
clement.freville2 requested changes 1 year ago
src/server.ts Outdated
})
/* Route pour créer une room */
fastify.get(
-fastify.get( 
+fastify.post(
```diff -fastify.get( +fastify.post( ```
clement.freville2 marked this conversation as resolved
bastien.ollier added 1 commit 1 year ago
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
fc6cbadebb
add multiroom
bastien.ollier requested review from clement.freville2 1 year ago
clement.freville2 approved these changes 1 year ago
clement.freville2 left a comment
Owner

Nice work!

Nice work!
clement.freville2 merged commit 85e5d9257e into main 1 year ago
clement.freville2 deleted branch room 1 year ago
clement.freville2 referenced this issue from a commit 1 year ago
clement.freville2 referenced this issue from a commit 1 year ago

Reviewers

clement.freville2 approved these changes 1 year ago
continuous-integration/drone/pr Build is passing
continuous-integration/drone/push Build is passing
The pull request has been merged as 85e5d9257e.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sandkasten/labyrinth#4
Loading…
There is no content yet.