coderoom

Conversation 0 Commits 10 Files Changed 10

bastien.ollier commented

Owner

There is no content yet.

bastien.ollier added 2 commits

57ee11bfea add button créer une salle

819c0e2c74 add editor live

clement.freville2 requested review from clement.freville2

bastien.ollier added 1 commit

4d51e15ab7 gitignore

bastien.ollier added 1 commit

ffd2afbc41 merge editor and editor-live

bastien.ollier added 1 commit

7d0fc24b8c npm start fmt

clement.freville2 requested changes

src/app/components/editor/editor.component.html

src/app/components/editor/editor.component.scss

clement.freville2 commented

Owner

-  width: 100px;

clement.freville2 marked this conversation as resolved

bastien.ollier added 1 commit

89e1fff2c1 add multiroom

bastien.ollier requested review from clement.freville2

bastien.ollier added 1 commit

214e3c265d add multiroom

bastien.ollier added 1 commit

e937c4544a add multiroom

bastien.ollier added 1 commit

52dfc0e75e retour merge request

clement.freville2 requested changes

src/app/components/editor/editor.component.ts Outdated

clement.freville2 commented

Owner

-    this.router.navigate([`./editor-live/${idRoom}`]);
+    await this.router.navigate([`./editor-live/${idRoom}`]);

clement.freville2 marked this conversation as resolved

src/app/services/backendService.service.ts Outdated

clement.freville2 commented

Owner

-    const reponse = await fetch(this.apiUrl + '/live');
+    const reponse = await fetch(this.apiUrl + '/live', { method: 'POST' });

clement.freville2 marked this conversation as resolved

bastien.ollier added 1 commit

09b0e1b2ee retour merge request

clement.freville2 approved these changes

clement.freville2 left a comment

Owner

Great work!

clement.freville2 merged commit 7dfd83b60a into master 1 year ago

clement.freville2 referenced this issue from a commit

Implement personal code rooms (#11)

clement.freville2 deleted branch coderoom

Reviewers

clement.freville2 approved these changes

continuous-integration/drone/pr Build is passing

Details

continuous-integration/drone/push Build is passing

Details

The pull request has been merged as 7dfd83b60a.

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sandkasten/sandkasten-web#11

         (click)="onRunButtonClicked()"
         [disabled]="isLoaded">
         Créer une salle
       </button>

   color: white;
   padding: 12px 16px;
   font-size: 16px;
   width: 100px;

   async onCreateRoomButtonClicked() {
     const idRoom = await this.backendService.createRoom();
     this.router.navigate([`./editor-live/${idRoom}`]);

   constructor() {}
   async createRoom() {
     const reponse = await fetch(this.apiUrl + '/live');

coderoom #11

Reviewers