sandkasten
/
sandkasten-web
6
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Labels Milestones

Ajout Login et Register #14

Merged
clement.freville2 merged 11 commits from form-login-register into master 5 months ago
Conversation 0 Commits 11 Files Changed 20
hugo.pradier2 commented 5 months ago
Owner
There is no content yet.
hugo.pradier2 added 3 commits 5 months ago
continuous-integration/drone/push Build is failing Details
f6d28150c9 verif des champs avant inscription
continuous-integration/drone/push Build is failing Details
continuous-integration/drone/pr Build is failing Details
30397b994c ajout login fonctionnel
hugo.pradier2 requested review from clement.freville2 5 months ago
clement.freville2 requested changes 5 months ago
clement.freville2 left a comment
Owner

Do not commit a .nx directory.

Do not commit a `.nx` directory.
src/app/components/login/login.component.ts
export class LoginComponent {
hide = true;
email = new FormControl('', [Validators.required, Validators.email]);
clement.freville2 commented 5 months ago
Owner

This field is never used in the login template.

This field is never used in the login template.
hugo.pradier2 commented 5 months ago
Poster
Owner

Si je l'utilise pour afficher ou non le mot de passe

Si je l'utilise pour afficher ou non le mot de passe
clement.freville2 marked this conversation as resolved
src/app/components/login/login.component.ts
.subscribe(() => this.updateErrorMessage());
}
updateErrorMessage() {
clement.freville2 commented 5 months ago
Owner

Validators must only exist in FormControl, do not try to duplicate this behavior.

Validators must only exist in `FormControl`, do not try to duplicate this behavior.
clement.freville2 marked this conversation as resolved
src/app/components/register/register.component.html Outdated
<div class="form-container">
clement.freville2 commented 5 months ago
Owner 
-<div class="form-container">
+<form [formGroup]="form">

https://angular.dev/guide/forms/reactive-forms

```diff -<div class="form-container"> +<form [formGroup]="form"> ``` https://angular.dev/guide/forms/reactive-forms
clement.freville2 marked this conversation as resolved
src/app/components/register/register.component.html Outdated
mat-flat-button
color="primary"
(click)="register()"
[disabled]="email.invalid || login.invalid || password.invalid">
clement.freville2 commented 5 months ago
Owner 
-    [disabled]="email.invalid || login.invalid || password.invalid">
+    [disabled]="form.invalid">
```diff - [disabled]="email.invalid || login.invalid || password.invalid"> + [disabled]="form.invalid"> ```
clement.freville2 marked this conversation as resolved
src/app/components/register/register.component.ts Outdated
login = new FormControl('', [Validators.required]);
password = new FormControl('', [Validators.required]);
clement.freville2 commented 5 months ago
Owner 
-  email = new FormControl('', [Validators.required, Validators.email]);
-
-  login = new FormControl('', [Validators.required]);
-
-  password = new FormControl('', [Validators.required]);
+  form = this.formBuilder.group({
+    email: ['', Validators.required, Validators.email],
+    login: ['', Validators.required],
+    password: ['', Validators.required],
+  });
```diff - email = new FormControl('', [Validators.required, Validators.email]); - - login = new FormControl('', [Validators.required]); - - password = new FormControl('', [Validators.required]); + form = this.formBuilder.group({ + email: ['', Validators.required, Validators.email], + login: ['', Validators.required], + password: ['', Validators.required], + }); ```
clement.freville2 marked this conversation as resolved
src/app/services/user.service.ts
export class UserService {
API_URL = 'http://127.0.0.1:3000';
private Users: User[] = [];
clement.freville2 commented 5 months ago
Owner 
-  private Users: User[] = [];
```diff - private Users: User[] = []; ```
clement.freville2 marked this conversation as resolved
src/app/services/user.service.ts Outdated
getUsers(): Observable<any> {
return this.http.get(`${this.API_URL}/Users`);
}
clement.freville2 commented 5 months ago
Owner 
-  getUsers(): Observable<any> {
-    return this.http.get(`${this.API_URL}/Users`);
-  }
```diff - getUsers(): Observable<any> { - return this.http.get(`${this.API_URL}/Users`); - } ```
clement.freville2 marked this conversation as resolved
src/app/services/user.service.ts Outdated
permissions: 0,
};
return this.http.post<any>(`${this.API_URL}/users`, body);
clement.freville2 commented 5 months ago
Owner 
-  postUser(form: NgForm): Observable<HttpResponse<Response>> {
-    let body = {
-      login: form.value.login,
-      password: form.value.password,
-      permissions: 0,
+  postUser(login: string, password: string): Observable<Response> {
+    const body = {
+      login,
+      password,
     };
 
-    return this.http.post<any>(`${this.API_URL}/users`, body);
+    return this.http.post<Response>(`${this.API_URL}/users`, body);

No permissions should appear here, or your application would not be very secure.

```diff - postUser(form: NgForm): Observable<HttpResponse<Response>> { - let body = { - login: form.value.login, - password: form.value.password, - permissions: 0, + postUser(login: string, password: string): Observable<Response> { + const body = { + login, + password, }; - return this.http.post<any>(`${this.API_URL}/users`, body); + return this.http.post<Response>(`${this.API_URL}/users`, body); ``` No permissions should appear here, or your application would not be very secure.
clement.freville2 marked this conversation as resolved
src/app/services/user.service.ts Outdated
};
return this.http.post<any>(`${this.API_URL}/users/login`, body);
}
clement.freville2 commented 5 months ago
Owner 
-  loginUser(form: NgForm): Observable<HttpResponse<Response>> {
-    let body = {
-      login: form.value.login,
-      password: form.value.password,
+  loginUser(login: string, password: string): Observable<Response> {
+    const body = {
+      login,
+      password,
     };
 
-    return this.http.post<any>(`${this.API_URL}/users/login`, body);
+    return this.http.post<Response>(`${this.API_URL}/users/login`, body);

Never take NgForm in a service.

```diff - loginUser(form: NgForm): Observable<HttpResponse<Response>> { - let body = { - login: form.value.login, - password: form.value.password, + loginUser(login: string, password: string): Observable<Response> { + const body = { + login, + password, }; - return this.http.post<any>(`${this.API_URL}/users/login`, body); + return this.http.post<Response>(`${this.API_URL}/users/login`, body); ``` Never take `NgForm` in a service.
clement.freville2 marked this conversation as resolved
src/styles.scss Outdated
}
html, body { height: 100%; }
body { margin: 0; font-family: Roboto, "Helvetica Neue", sans-serif; }
clement.freville2 commented 5 months ago
Owner

It is the same style as above...

It is the same style as above...
clement.freville2 marked this conversation as resolved
hugo.pradier2 added 1 commit 5 months ago
continuous-integration/drone/pr Build is failing Details
continuous-integration/drone/push Build is failing Details
c1a87b13d8 petits correctifs
hugo.pradier2 added 1 commit 5 months ago
continuous-integration/drone/pr Build is failing Details
continuous-integration/drone/push Build is failing Details
cd42d18848 .nx in gitignore
hugo.pradier2 added 1 commit 5 months ago
continuous-integration/drone/pr Build is failing Details
continuous-integration/drone/push Build is failing Details
7de3db7c66 remove nx
hugo.pradier2 requested review from clement.freville2 5 months ago
hugo.pradier2 added 1 commit 5 months ago
continuous-integration/drone/pr Build is failing Details
continuous-integration/drone/push Build is passing Details
2d5c4f126e correctifs
hugo.pradier2 added 1 commit 5 months ago
continuous-integration/drone/pr Build is failing Details
continuous-integration/drone/push Build is passing Details
2aafd3e320 ajout logout
clement.freville2 added 1 commit 5 months ago
continuous-integration/drone/push Build is failing Details
continuous-integration/drone/pr Build is failing Details
3067443127 Merge branch 'master' into form-login-register
clement.freville2 added 1 commit 5 months ago
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
e7501561aa Fix tests
clement.freville2 approved these changes 5 months ago
clement.freville2 added 1 commit 5 months ago
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
825afb69ab Remove duplicated lines
clement.freville2 merged commit 80c0d99bee into master 5 months ago
clement.freville2 deleted branch form-login-register 5 months ago

Reviewers

clement.freville2 approved these changes 5 months ago
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
The pull request has been merged as 80c0d99bee.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
clement.freville2
Labels
Apply labels
Clear labels
bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong question
More information is needed wontfix
This won't be fixed
No Label bug duplicate enhancement help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sandkasten/sandkasten-web#14
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'form-login-register'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes