result to screen

Conversation 0 Commits 3 Files Changed 3

bastien.ollier commented

Owner

please, peer review my code

bastien.ollier added 1 commit

93395cbe37 result to screen

bastien.ollier requested review from clement.freville2

bastien.ollier requested review from hugo.pradier2

clement.freville2 requested changes

src/app/services/codeExecution.service.ts Outdated

													
					    sse.addEventListener('message', (event: MessageEvent<string>) => {

					      console.log(event.data);

					      const result = event.data;

					      console.log(result);

clement.freville2 commented

Owner

-      console.log(result);

src/app/services/codeExecution.service.ts Outdated

													
					      console.log(result);

					      // Émettre le résultat à tous les abonnés

					      this.resultSubject.next(result);

clement.freville2 commented

Owner

Rearrange the result here instead of in the component:

-      this.resultSubject.next(result);
+      const text = decodeURIComponent(result.replace(/%00/g, ''));
+      this.resultSubject.next(text);

clement.freville2 added the enhancement label

bastien.ollier was assigned by clement.freville2

bastien.ollier added 1 commit

d332c8b702 correction demande clement

bastien.ollier requested review from clement.freville2

clement.freville2 approved these changes

clement.freville2 added 1 commit

37726cd51a Fix typo

clement.freville2 merged commit a17d97c050 into master 1 year ago

clement.freville2 referenced this issue from a commit

result to screen (#2)

clement.freville2 deleted branch print-response

Reviewers

hugo.pradier2 was requested for review

clement.freville2 approved these changes

continuous-integration/drone/pr Build is passing

Details

continuous-integration/drone/push Build is passing

Details

The pull request has been merged as a17d97c050.

Sign in to join this conversation.

enhancement

No Milestone

No project

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sandkasten/sandkasten-web#2

result to screen #2

Reviewers