Add editor features

Conversation 0 Commits 2 Files Changed 2

hugo.pradier2 commented

Owner

There is no content yet.

hugo.pradier2 added 1 commit

0c5adc9d6f Add editor features

hugo.pradier2 requested review from clement.freville2

clement.freville2 requested changes

src/app/components/editor/editor.component.html

													
					  </div>

					  <div *ngIf="errorMessage">

					    <p style="color: red">{{ errorMessage }}</p>

clement.freville2 commented

Owner

Use a class for errors instead of hardcoding the style.

hugo.pradier2 commented

Poster

Owner

Ne t'inquiète pas ça sera corrigé par colin lorsqu'il fera le css là, c'est temporaire.

src/app/components/editor/editor.component.ts Outdated

													
					};

					// Langages autorisés

					type AllowedLanguage = 'text/x-sh' | 'text/javascript' | 'text/typescript' | 'text/x-c++src' | 'text/x-csrc';

clement.freville2 commented

Owner

- type AllowedLanguage = 'text/x-sh' | 'text/javascript' | 'text/typescript' | 'text/x-c++src' | 'text/x-csrc';
+ type AllowedLanguage = keyof typeof codeDefaults;

hugo.pradier2 added 1 commit

3ef54ee56e Apply suggestion and add coloration for c, c++ and shell

clement.freville2 approved these changes

clement.freville2 merged commit dd2c99adb2 into master 1 year ago

clement.freville2 referenced this issue from a commit

Add editor features (#4)

clement.freville2 deleted branch editor

Reviewers

clement.freville2 approved these changes

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/pr Build is passing

Details

The pull request has been merged as dd2c99adb2.

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sandkasten/sandkasten-web#4

Add editor features #4

Reviewers