add simple undo/redo

Conversation 0 Commits 1 Files Changed 2

maxime.batista commented

This pull request adds a simple undo/redo for the step contents

maxime.batista added 1 commit

0fdda4da95 add simple undo/redo

maxime.batista requested review from clement.freville2

maxime.batista requested review from yanis.dahmane-bounoua

maxime.batista requested review from vivien.dufour

maxime.batista requested review from mael.daim

maxime.batista requested review from samuel.berion

clement.freville2 requested changes

src/pages/Editor.tsx Outdated

clement.freville2 commented

-                    let versions = stepsVersions.get(stepId!)
-                    if (versions == undefined) {
-                        versions = new ContentVersions()
-                        stepsVersions.set(stepId!, versions)
+                    if (id === stepId) {
+                        let versions = stepsVersions.get(stepId!)
+                        if (versions === undefined) {
+                            versions = new ContentVersions()
+                            stepsVersions.set(stepId!, versions)
+                        }
+                        versions.insertAndCut(content)
+                    } else {
+                        stepsVersions.delete(id)
                     }

-                    versions.insertAndCut(content)

It should account for recursive updates in the subtree by not saving it the current version stack.

maxime.batista marked this conversation as resolved

src/pages/Editor.tsx Outdated

clement.freville2 commented

-                console.log(e.key, stepsVersions)
-

maxime.batista marked this conversation as resolved

src/pages/Editor.tsx Outdated

clement.freville2 commented

-                console.log(versions)

maxime.batista marked this conversation as resolved

Ghost added a new dependency

celeste.barbosa/SAE-2.04#1 - Ecrire une présentation du jeu de données

Ghost removed a dependency

celeste.barbosa/SAE-2.04#1 - Ecrire une présentation du jeu de données

maxime.batista added 1 commit

102bc774af add simple undo/redo

maxime.batista merged commit 4ea531c08c into master 1 year ago

maxime.batista referenced this issue from a commit

Merge pull request 'add simple undo/redo' (#116) from undo-redo into master

maxime.batista deleted branch undo-redo

Reviewers

yanis.dahmane-bounoua was requested for review

mael.daim was requested for review

vivien.dufour was requested for review

samuel.berion was requested for review

clement.freville2 requested changes

continuous-integration/drone/push Build is passing

Details

The pull request has been merged as 4ea531c08c.

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: IQBall/Application-Web#116

             if (!e.ctrlKey) return
             if (e.key == "z" || e.key == "y") {
                 console.log(e.key, stepsVersions)

add simple undo/redo #116

Reviewers