Replicate the parent's content to the visualisation of a step. #117

Merged
maxime.batista merged 4 commits from replicated-parent into master 1 year ago

The parent's content is now displayed in gray :

image
image

The parent's content is now displayed in gray : ![image](/attachments/7de49529-3eb0-4a6b-bd4d-1f5627016aa0) ![image](/attachments/27ae3c81-b924-45fe-b8dc-98be4e018e42)
maxime.batista added 2 commits 1 year ago
maxime.batista requested review from clement.freville2 1 year ago
maxime.batista requested review from yanis.dahmane-bounoua 1 year ago
maxime.batista requested review from vivien.dufour 1 year ago
maxime.batista requested review from mael.daim 1 year ago
maxime.batista requested review from samuel.berion 1 year ago
maxime.batista force-pushed replicated-parent from 145a692400 to 95b89d87e4 1 year ago
clement.freville2 requested changes 1 year ago
clement.freville2 left a comment

Each previous court player shouldn't have a tab index (i.e. be keyboard focusable). Don't forget to run Prettier too.

Each previous court player shouldn't have a tab index (i.e. be keyboard focusable). Don't forget to run Prettier too.
parentComponents.map((i) => renderComponent(i, true))}
{courtRef.current &&
parentComponents &&
parentComponents.flatMap((i) => renderActions(i, true))}
-                parentComponents &&
-                parentComponents.map((i) => renderComponent(i, true))}
+                parentComponents?.map((i) => renderComponent(i, true))}
             {courtRef.current &&
-                parentComponents &&
-                parentComponents.flatMap((i) => renderActions(i, true))}
+                parentComponents?.flatMap((i) => renderActions(i, true))}
```diff - parentComponents && - parentComponents.map((i) => renderComponent(i, true))} + parentComponents?.map((i) => renderComponent(i, true))} {courtRef.current && - parentComponents && - parentComponents.flatMap((i) => renderActions(i, true))} + parentComponents?.flatMap((i) => renderActions(i, true))} ```
maxime.batista marked this conversation as resolved
maxime.batista added 1 commit 1 year ago
continuous-integration/drone/push Build is passing Details
1aa20cb652
Apply suggestions and format
maxime.batista requested review from clement.freville2 1 year ago
maxime.batista force-pushed replicated-parent from 1aa20cb652 to bef196e09e 1 year ago
clement.freville2 approved these changes 1 year ago
clement.freville2 left a comment

Having a coherent keyboard navigation would be nice (see previous review)

Having a coherent keyboard navigation would be nice (see previous review)
maxime.batista merged commit 307a978e15 into master 1 year ago
maxime.batista deleted branch replicated-parent 1 year ago

Reviewers

samuel.berion was requested for review 1 year ago
yanis.dahmane-bounoua was requested for review 1 year ago
mael.daim was requested for review 1 year ago
vivien.dufour was requested for review 1 year ago
clement.freville2 approved these changes 1 year ago
continuous-integration/drone/push Build is passing
The pull request has been merged as 307a978e15.
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: IQBall/Application-Web#117
Loading…
There is no content yet.