IQBall
/
Application-Web
6
0
Fork 0
Code Issues 49 Pull Requests Packages Projects 5 Releases Wiki Activity
Labels Milestones

Can place ball on the court #77

Merged
vivien.dufour merged 14 commits from editor/ball-assign into master 2 years ago
Conversation 0 Commits 14 Files Changed 12
vivien.dufour commented 2 years ago
Owner

Also added player and ball remove by drag and drop them out of the court

Also added player and ball remove by drag and drop them out of the court
vivien.dufour added 6 commits 2 years ago
continuous-integration/drone/push Build is passing Details
a025844528 fix css + verify and format
vivien.dufour requested review from yanis.dahmane-bounoua 2 years ago
vivien.dufour requested review from maxime.batista 2 years ago
vivien.dufour requested review from mael.daim 2 years ago
vivien.dufour requested review from samuel.berion 2 years ago
maxime.batista requested changes 2 years ago
front/components/editor/BallPiece.tsx Outdated
export interface BallPieceProps {
onDrop: () => void
pieceRef: RefObject<HTMLDivElement>
export interface CourtBallProps {
maxime.batista commented 2 years ago

Move this in CourtBall.tsx as its only used by this file

Move this in `CourtBall.tsx` as its only used by this file
vivien.dufour marked this conversation as resolved
front/style/ball.css Outdated
cursor: pointer;
}
.ball-div:focus-within {
maxime.batista commented 2 years ago

remove this

remove this
vivien.dufour marked this conversation as resolved
front/style/editor.css Outdated
justify-content: flex-start;
}
#opponent-rack {
maxime.batista commented 2 years ago

you can factorise allies-rack and opponents-rack :

#allies-rack, #opponent-rack {
    width: 125px;
    min-width: 125px;
    display: flex;
    flex-direction: row;
    align-items: flex-end;
}

#allies-rack {
	justify-content: flex-start;
}

#opponent-rack {
	justify-content: flex-end;
}
you can factorise allies-rack and opponents-rack : ```css #allies-rack, #opponent-rack { width: 125px; min-width: 125px; display: flex; flex-direction: row; align-items: flex-end; } #allies-rack { justify-content: flex-start; } #opponent-rack { justify-content: flex-end; } ```
vivien.dufour marked this conversation as resolved
front/views/Editor.tsx Outdated
}
})
return
} else {
maxime.batista commented 2 years ago

the else here is useless as the if above already returns if executed

the else here is useless as the if above already returns if executed
vivien.dufour marked this conversation as resolved
vivien.dufour added 1 commit 2 years ago
continuous-integration/drone/push Build is passing Details
0c73aa9418 apply modifications
vivien.dufour requested review from maxime.batista 2 years ago
maxime.batista approved these changes 2 years ago
vivien.dufour merged commit eb744d0da4 into master 2 years ago
vivien.dufour referenced this issue from a commit 2 years ago
Can place ball on the court (#77)
vivien.dufour deleted branch editor/ball-assign 2 years ago

Reviewers

mael.daim was requested for review 2 years ago
yanis.dahmane-bounoua was requested for review 2 years ago
samuel.berion was requested for review 2 years ago
maxime.batista approved these changes 2 years ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as eb744d0da4.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
mael.daim
yanis.dahmane-bounoua
samuel.berion
maxime.batista
Labels
Apply labels
Clear labels
bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong question
More information is needed wontfix
This won't be fixed
No Label bug duplicate enhancement help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: IQBall/Application-Web#77
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'editor/ball-assign'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes