IQBall
/
Application-Web
6
0
Fork 0
Code Issues 49 Pull Requests Packages Projects 5 Releases Wiki Activity
Labels Milestones

Add Phantoms #95

Merged
maxime.batista merged 7 commits from editor/phantoms into master 1 year ago
Conversation 0 Commits 7 Files Changed 29
maxime.batista commented 1 year ago

This pull request adds phantoms to the Editor

example : image

This pull request adds phantoms to the Editor example : ![image](/attachments/91cd6dfc-40ca-465a-bb8d-b91d0c713977)
image.png
62 KiB
maxime.batista added 6 commits 1 year ago
continuous-integration/drone/push Build is passing Details
2c95bf6c99 fixes and format
continuous-integration/drone/push Build is passing Details
1328fa50c6 fix desynchronization when pass arrows are removed
maxime.batista requested review from clement.freville2 1 year ago
maxime.batista requested review from yanis.dahmane-bounoua 1 year ago
maxime.batista requested review from vivien.dufour 1 year ago
maxime.batista requested review from mael.daim 1 year ago
maxime.batista requested review from samuel.berion 1 year ago
maxime.batista force-pushed editor/phantoms from 1328fa50c6 to 9a6103e78a 1 year ago
maxime.batista changed title from Add Phantoms to WIP: Add Phantoms 1 year ago
maxime.batista changed title from WIP: Add Phantoms to Add Phantoms 1 year ago
clement.freville2 requested changes 1 year ago
front/editor/ActionsDomains.ts Outdated
if (areInSamePath(origin, target)) return false
if (alreadyHasAnAnteriorActionWith(origin, target, components)) {
console.log("e")
maxime.batista marked this conversation as resolved
front/editor/ActionsDomains.ts
}
const originIdx = originOriginPath.indexOf(origin.id)
for (let i = 0; i <= originIdx; i++) {
clement.freville2 commented 1 year ago 
-    for (let i = 0; i <= originIdx; i++) {
+    for (let i = 0; i < originIdx; i++) {
```diff - for (let i = 0; i <= originIdx; i++) { + for (let i = 0; i < originIdx; i++) { ```
front/editor/TacticContentDomains.ts
return {
...content,
components: content.components.toSpliced(componentIdx, 1),
clement.freville2 commented 1 year ago 
-    const componentIdx = content.components.findIndex(
-        (c) => c.id == componentId,
-    )
-
-    return {
-        ...content,
-        components: content.components.toSpliced(componentIdx, 1),
+    return {
+        components: content.components.filter((c) => c.id != componentId),
```diff - const componentIdx = content.components.findIndex( - (c) => c.id == componentId, - ) - - return { - ...content, - components: content.components.toSpliced(componentIdx, 1), + return { + components: content.components.filter((c) => c.id != componentId), ```
maxime.batista marked this conversation as resolved
front/editor/TacticContentDomains.ts
return {
...content,
components: content.components.toSpliced(componentIdx, 1, component),
}
clement.freville2 commented 1 year ago 
-    const componentIdx = content.components.findIndex(
-        (c) => c.id == component.id,
-    )
     return {
-        ...content,
-        components: content.components.toSpliced(componentIdx, 1, component),
+        components: content.components.map((c) =>
+            c.id === component.id ? component : c,
+        ),
     }
```diff - const componentIdx = content.components.findIndex( - (c) => c.id == component.id, - ) return { - ...content, - components: content.components.toSpliced(componentIdx, 1, component), + components: content.components.map((c) => + c.id === component.id ? component : c, + ), } ```
maxime.batista marked this conversation as resolved
front/model/tactic/Player.ts
import { Component, ComponentId } from "./Tactic"
export type PlayerId = string
clement.freville2 commented 1 year ago

Might be better adding a type PlayerLike = Player | PlayerPhantom union since it is often used.

Might be better adding a `type PlayerLike = Player | PlayerPhantom` union since it is often used.
maxime.batista marked this conversation as resolved
front/views/Editor.tsx
}))
}}
onHeadPicked={(headPos) => {
;(document.activeElement as HTMLElement).blur()
clement.freville2 commented 1 year ago 
-                ;(document.activeElement as HTMLElement).blur() 
+                (document.activeElement as HTMLElement).blur()
```diff - ;(document.activeElement as HTMLElement).blur() + (document.activeElement as HTMLElement).blur() ```
maxime.batista marked this conversation as resolved
maxime.batista added 1 commit 1 year ago
continuous-integration/drone/push Build is passing Details
1b435d4469 apply suggestions
maxime.batista merged commit 00da8d7f54 into master 1 year ago
maxime.batista deleted branch editor/phantoms 1 year ago

Reviewers

vivien.dufour was requested for review 1 year ago
mael.daim was requested for review 1 year ago
yanis.dahmane-bounoua was requested for review 1 year ago
samuel.berion was requested for review 1 year ago
clement.freville2 requested changes 1 year ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as 00da8d7f54.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
vivien.dufour
mael.daim
yanis.dahmane-bounoua
samuel.berion
clement.freville2
Labels
Apply labels
Clear labels
bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong question
More information is needed wontfix
This won't be fixed
No Label bug duplicate enhancement help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: IQBall/Application-Web#95
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'editor/phantoms'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes