fix

API/Controllers/TacticsController.cs

@@ -74,7 +74,7 @@ public class TacticController(ITacticService service, IContextAccessor accessor)
         [AllowedValues("PLAIN", "HALF")] string CourtType
     );
 
-    public record CreateNewResponse(int Id, int RootStepId);
+    public record CreateNewResponse(int Id);
 
     [HttpPost("/tactics")]
     [Authorize]
@@ -88,8 +88,8 @@ public class TacticController(ITacticService service, IContextAccessor accessor)
             throw new ArgumentOutOfRangeException("for req.CourtType");
         }
 
-        var (id, rootId) = await service.AddTactic(userId, req.Name, courtType);
-        return new CreateNewResponse(id, rootId);
+        var id = await service.AddTactic(userId, req.Name, courtType);
+        return new CreateNewResponse(id);
     }
 
     public record AddStepRequest(int ParentId, object Content);

API/Controllers/TeamsController.cs

@@ -1,7 +1,7 @@
 using System.ComponentModel.DataAnnotations;
 using API.Context;
-using API.DTO;
 using API.Validation;
+using AppContext.Entities;
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Mvc;
 using Model;
@@ -11,20 +11,13 @@ namespace API.Controllers;
 
 [ApiController]
 [Authorize]
-public class TeamsController(
-    ITeamService service,
-    ITacticService tactics,
-    IUserService users,
-    IContextAccessor accessor
-) : ControllerBase
+public class TeamsController(ITeamService service, ITacticService tactics,IContextAccessor accessor) : ControllerBase
 {
     public record CreateTeamRequest(
         [Name] string Name,
         [Url] string Picture,
-        [RegularExpression("^#[0-9A-Fa-f]{6}$")]
-        string FirstColor,
-        [RegularExpression("^#[0-9A-Fa-f]{6}$")]
-        string SecondColor
+        [RegularExpression("^#[0-9A-F]{6}$")] string FirstColor,
+        [RegularExpression("^#[0-9A-F]{6}$")] string SecondColor
     );
 
     [HttpPost("/teams")]
@@ -36,14 +29,6 @@ public class TeamsController(
         return Ok(team);
     }
 
-    [HttpGet("/teams/{id:int}")]
-    public async Task<IActionResult> GetTeam(int id)
-    {
-        var team = await service.GetTeam(id);
-        return team == null ? NotFound() : Ok(team);
-    }
-
-
     [HttpGet("/teams/{teamId:int}/members")]
     public async Task<IActionResult> GetMembersOf(int teamId)
     {
@@ -53,16 +38,7 @@ public class TeamsController(
         switch (accessibility)
         {
             case ITeamService.TeamAccessibility.Authorized:
-                var members = (await service.GetMembersOf(teamId)).ToList();
-
-                var membersDto = new List<MemberDto>();
-
-                foreach (var m in members)
-                {
-                    membersDto.Add(new MemberDto((await users.GetUser(m.UserId))!, m.Role));
-                }
-
-                return Ok(membersDto);
+                return Ok(await service.GetMembersOf(teamId));
             case ITeamService.TeamAccessibility.NotFound:
             case ITeamService.TeamAccessibility.Unauthorized:
                 return NotFound();
@@ -135,6 +111,8 @@ public class TeamsController(
             default: //unreachable
                 return Problem();
         }
+        
+
     }
 
     [HttpDelete("/team/{teamId:int}/members/{userId:int}")]
@@ -182,7 +160,6 @@ public class TeamsController(
         {
             return NotFound();
         }
-
         if (currentUserId != tactic.OwnerId)
         {
             return Unauthorized();

API/Controllers/UsersController.cs

@@ -27,7 +27,7 @@ public class UsersController(IUserService users, ITeamService teams, ITacticServ
         return (await users.GetUser(userId))!;
     }
 
-    public record GetUserDataResponse(Team[] Teams, TacticDto[] Tactics);
+    public record GetUserDataResponse(Team[] Teams, TacticDto[] Tactics, TacticDto[] SharedTactics);
 
     [Authorize]
     [HttpGet("/user-data")]
@@ -36,7 +36,8 @@ public class UsersController(IUserService users, ITeamService teams, ITacticServ
         var userId = accessor.CurrentUserId(HttpContext);
         var userTeams = await teams.ListTeamsOf(userId);
         var userTactics = await tactics.ListTacticsOf(userId);
-        return new GetUserDataResponse(userTeams.ToArray(), userTactics.Select(t => t.ToDto()).ToArray());
+        var sharedTactics = await users.GetSharedTacticsToUser(userId);
+        return new GetUserDataResponse(userTeams.ToArray(), userTactics.Select(t => t.ToDto()).ToArray(), sharedTactics.Select(t => t.ToDto()).ToArray());
     }
 
     

API/DTO/MemberDto.cs

@@ -1,5 +0,0 @@
-using Model;
-
-namespace API.DTO;
-
-public record MemberDto(User User, MemberRole Role);

APIConsole/TeamsControllerConsole.cs

@@ -17,9 +17,8 @@ namespace APIConsole
             AppContext.AppContext context = new AppContext.AppContext();
             ITeamService teams = new DbTeamService(context);
             ITacticService tactics = new DbTacticService(context);
-            IUserService users = new DbUserService(context);
             IContextAccessor accessor = new HttpContextAccessor();
-            _controller = new TeamsController(teams, tactics, users, accessor);
+            _controller = new TeamsController(teams, tactics, accessor);
         }
 
         public async void GetMembersOfTest()

DbServices/DbTacticService.cs

@@ -27,7 +27,7 @@ public class DbTacticService(AppContext.AppContext context) : ITacticService
         return tacticEntity.OwnerId == userId;
     }
 
-    public async Task<(int, int)> AddTactic(int userId, string name, CourtType courtType)
+    public async Task<int> AddTactic(int userId, string name, CourtType courtType)
     {
         var tacticEntity = new TacticEntity
         {
@@ -49,7 +49,7 @@ public class DbTacticService(AppContext.AppContext context) : ITacticService
         await context.SaveChangesAsync();
 
         
-        return (tacticEntity.Id, stepEntity.Id);
+        return tacticEntity.Id;
     }
 
     public async Task<bool> UpdateName(int tacticId, string name)

DbServices/DbTeamService.cs

@@ -52,12 +52,6 @@ public class DbTeamService(AppContext.AppContext context) : ITeamService
         return entity.ToModel();
     }
 
-    public async Task<Team?> GetTeam(int id)
-    {
-        var entity = await context.Teams.FirstOrDefaultAsync(t => t.Id == id);
-        return entity?.ToModel();
-    }
-
     public async Task RemoveTeams(params int[] teams)
     {
         await context.Teams

Services/ITacticService.cs

@@ -29,7 +29,7 @@ public interface ITacticService
     /// <param name="name">The name of the tactic.</param>
     /// <param name="courtType">The type of court.</param>
     /// <returns>A task that represents the asynchronous operation. The task result contains the ID of the newly added tactic.</returns>
-    Task<(int, int)> AddTactic(int userId, string name, CourtType courtType);
+    Task<int> AddTactic(int userId, string name, CourtType courtType);
 
     /// <summary>
     /// Updates the name of the specified tactic.

Services/ITeamService.cs

@@ -27,8 +27,6 @@ public interface ITeamService
     /// </summary>
     Task<Team> AddTeam(string name, string picture, string firstColor, string secondColor);
 
-    Task<Team?> GetTeam(int id);
-
     /// <summary>
     /// Removes one or more teams.
     /// </summary>

UnitTests/TacticsControllerTest.cs

@@ -71,7 +71,7 @@ public class TacticsControllerTest
     {
         var (controller, context) = GetController(1);
         var result = await controller.CreateNew(new("Test Tactic", "pLaIn"));
-        result.Should().BeEquivalentTo(new TacticController.CreateNewResponse(2, 2));
+        result.Should().BeEquivalentTo(new TacticController.CreateNewResponse(2));
         var tactic = await context.Tactics.FirstOrDefaultAsync(e => e.Id == 2);
         tactic.Should().NotBeNull();
         tactic!.Name.Should().BeEquivalentTo("Test Tactic");

UnitTests/TeamsControllerTest.cs

@@ -21,9 +21,7 @@ public class TeamsControllerTest
         );
         context.Database.EnsureCreated();
         var controller = new TeamsController(
-            new DbTeamService(context), 
-            new DbTacticService(context),
-            new DbUserService(context),
+            new DbTeamService(context), new DbTacticService(context),
             new ManualContextAccessor(userId)
         );
 
@@ -47,11 +45,11 @@ public class TeamsControllerTest
     {
         var (controller, context) = GetController(1);
         var result = await controller.GetMembersOf(1);
-        // result.Should().BeEquivalentTo(controller.Ok(new Member[]
-        // {
-        //     new(1, 1, MemberRole.Coach),
-        //     new(1, 2, MemberRole.Player)
-        // }));
+        result.Should().BeEquivalentTo(controller.Ok(new Member[]
+        {
+            new(1, 1, MemberRole.Coach),
+            new(1, 2, MemberRole.Player)
+        }));
     }
 
     [Fact]

UnitTests/UserControllerTest.cs

@@ -83,13 +83,4 @@ public class UsersControllerTest
         result.Should().BeOfType<OkResult>();
     }
 
-    [Fact]
-    public async Task TestChangeUserInformation()
-    {
-        var controller = GetUserController(1);
-        await controller.ChangeUserInformation(new("a", "b", "c", "d"));
-        var user = await controller.GetUser();
-        user.Should().BeEquivalentTo(new User(1, "b", "a", "c", true));
-    }
-
 }

ci/.drone.yml

@@ -12,9 +12,9 @@ steps:
       - dotnet tool install --global dotnet-sonarscanner
       - dotnet tool install --global dotnet-coverage
       - export PATH="$PATH:/root/.dotnet/tools"
-      - dotnet sonarscanner begin /k:"IQBall-WebAPI" /d:sonar.host.url="https://codefirst.iut.uca.fr/sonar" /d:sonar.login="sqp_b16ad09dcce1b9dde920e313b10c2fe85566624c" /d:sonar.cs.vscoveragexml.reportsPaths=coverage.xml
+      - dotnet sonarscanner begin /k:"IQBall-WebAPI" /d:sonar.host.url="https://codefirst.iut.uca.fr/sonar"  /d:sonar.login="sqp_b16ad09dcce1b9dde920e313b10c2fe85566624c"
       - dotnet build
-      - dotnet-coverage collect "dotnet test" -f xml -o coverage.xml
+      - dotnet-coverage collect "dotnet test" -f xml -o "coverage.xml"
       - dotnet sonarscanner end /d:sonar.login="sqp_b16ad09dcce1b9dde920e313b10c2fe85566624c"