Code smells and bugs resolve 12
continuous-integration/drone/push Build is passing Details

master
Alexis 2 years ago
parent 85fac9b09e
commit 329f6da171

@ -49,7 +49,7 @@ class ModelAdmin
if (validate::type($type)) { if (validate::type($type)) {
$question = new $type(0, $questionContent); $question = new $type(0, $questionContent);
$res = $this->client->request('GET', 'https://codefirst.iut.uca.fr/containers/Temoignages-deploy_api_form/getForm'); $res = $this->client->request('GET', 'https://codefirst.iut.uca.fr/containers/Temoignages-deploy_api_form/getForm');
if ($res->getStatusCode() != 200){ if ($res->getStatusCode() != 200) {
throw new Exception('GetForm failed'); throw new Exception('GetForm failed');
} }
$form = json_decode($res->getBody()); $form = json_decode($res->getBody());

@ -52,8 +52,7 @@ class ModelCandidate
$categs = explode("_", $categs); $categs = explode("_", $categs);
array_pop($categs); array_pop($categs);
$category[] = $categs; $category[] = $categs;
} } else {
else {
$questionsId[] = array_shift($dataIds); $questionsId[] = array_shift($dataIds);
$answer[] = $answerAndCategory; $answer[] = $answerAndCategory;
$category[] = []; $category[] = [];
@ -68,10 +67,10 @@ class ModelCandidate
$title = $form[0]->title; $title = $form[0]->title;
$cate = "[".implode(',', array_map(function ($subArray) {return implode(',', $subArray);}, $category))."]"; $cate = "[".implode(',', array_map(function ($subArray) {return implode(',', $subArray);}, $category))."]";
$res =$this->client->request('POST', 'https://codefirst.iut.uca.fr/containers/Temoignages-deploy_api_form/insertListResponseOfCandidate?'. $res =$this->client->request('POST', 'https://codefirst.iut.uca.fr/containers/Temoignages-deploy_api_form/insertListResponseOfCandidate?'.
'id='.implode(",",$questionsId).'&'. 'id=' . implode(",", $questionsId) . '&'.
'answer='.implode(",",$answer).'&'. 'answer=' . implode(",", $answer) . '&'.
'category='.$cate.'&'. 'category=' . $cate . '&'.
'titleForm='.$title 'titleForm=' . $title
); );
if ($res->getStatusCode() != 200) { if ($res->getStatusCode() != 200) {
throw new Exception('InsertListResponsesOfCandidate failed'); throw new Exception('InsertListResponsesOfCandidate failed');
@ -112,7 +111,7 @@ class ModelCandidate
throw new Exception('GetAllQuestion failed'); throw new Exception('GetAllQuestion failed');
} }
$questionsTab = json_decode($res->getBody()); $questionsTab = json_decode($res->getBody());
} catch (GuzzleException | ClientException $g){ } catch (GuzzleException | ClientException $g) {
echo "Error : " . $g->getMessage(); echo "Error : " . $g->getMessage();
throw new Exception($g->getMessage(), $g->getCode(), $g); throw new Exception($g->getMessage(), $g->getCode(), $g);
} }
@ -165,7 +164,8 @@ class ModelCandidate
* @throws InexistantLoginException * @throws InexistantLoginException
* @throws Exception * @throws Exception
*/ */
public function login() :void { public function login(): void
{
global $rep, $views, $sel; global $rep, $views, $sel;
$password = Clean::simpleString($_REQUEST['password']); $password = Clean::simpleString($_REQUEST['password']);
$identifiant = Clean::simpleString($_REQUEST['login']); $identifiant = Clean::simpleString($_REQUEST['login']);

Loading…
Cancel
Save