WIP: customer_branche #22
Closed
ismail.taha_janan
wants to merge 4 commits from customer_branche into master
alexis.drai
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'customer_branche'
Deleting a branch is permanent. It CANNOT be undone. Continue?
customer_brancheto WIP: customer_branche 2 years agoOk, here's the review. Well done on everything. I just need a few details changed before we do the merge
using System;No need to use this Dto, please use the current version of
CatDto(frommaster)public string? Name { get; set; }public int Age { get; set; } = 0;No need to commit that, please use the current version of
Cat(frommaster)builder.Services.AddDbContext<CatContext>(opt =>opt.UseInMemoryDatabase("CatCafe"));builder.Services.AddDbContext<CustomerContext>(opt =>opt.UseInMemoryDatabase("CatCafe"));Also add
to resolve the conflict
<PackageReference Include="Swashbuckle.AspNetCore" Version="6.2.3" /></ItemGroup><ItemGroup>Is this necessary?
I think you can delete lines 21 to 26 (included).
Ok, here's the review. Thanks for submitting this PR.
I clicked 'Approve' instead of 'Request changes', sorry. I am in fact requesting changes.
I just need a few details changed before we do the merge. Thanks
Reviewers