mzjeeawody
|
1e4f846edb
|
sequence equak issues
|
3 years ago |
 Alexis Drai
|
c61ffeb783
|
🐛 Replace Equals with SequenceEqual
still not foolproof, since Die and Face don't redefine equals etc.
the reason why all the tests pass is because we don't have UTs for DiceGroupManager
|
3 years ago |
|
Alexis Drai
|
d259884ba8
|
🚨 Encapsulate collections...
make code more readable
add checks and UTs for Utils.Enumerables
|
3 years ago |
|
Alexis Drai
|
a2d832a9f2
|
🚧 WIP
|
3 years ago |
|
Alexis Drai
|
932babdca6
|
🔥 📈 Get rid of ToString() methods
We should keep formatting responsibilities out of the model
|
3 years ago |
|
Alexis Drai
|
5c11e4b253
|
🔊 Use NLog in App.Program and Data.Players.PlayerDbManager
|
3 years ago |
|
Alexis Drai
|
2c44df5e16
|
♻️ Use extension features
ImageDieExtensions.ToModel(entity)
-->
entity.ToModel()
|
3 years ago |
|
Alexis Drai
|
e5fc62499f
|
📈 🔥 Remove unused and untestable code
|
3 years ago |
|
Alexis Drai
|
a319d7deb2
|
🚨 fix code smells
|
3 years ago |
|
Alexis Drai
|
a46d4b73a4
|
⚗️ Play around with async-await
PlayerManager.Remove is bugged
|
3 years ago |
|
Alexis Drai
|
ac5ebd7b87
|
✏️ Fix comment
|
3 years ago |
|
Alexis Drai
|
ca3ec81ae6
|
🐛 Prevent Die ctor from making dice with no face
|
3 years ago |
|
Alexis Drai
|
1f2ca7483f
|
♻️ Rename DieManager to DiceGroupManager
that class is in charge of managing groups of dice (in association with a string name)
|
3 years ago |
|
Alexis Drai
|
b21b78135e
|
♻️ Rename GameRunner to MasterOfCeremonies
|
3 years ago |
|
Alexis Drai
|
08c1e415a9
|
♻️ Refactor manager-y stuff into GameManager
|
3 years ago |
|
Alexis Drai
|
0769b5116f
|
🐛 Throw appropriate exception when trying to update the Die collection itself
|
3 years ago |
|
Alexis Drai
|
a987f36eac
|
🔥 Clean up imports
|
3 years ago |
|
Ismail TAHA JANAN
|
e49afa3b14
|
🩹 improve code
|
3 years ago |
|
Ismail TAHA JANAN
|
949521ff9b
|
✅ conflict solved
|
3 years ago |
|
Ismail TAHA JANAN
|
f2eafe4ded
|
fix merging conflict
|
3 years ago |
|
Ismail TAHA JANAN
|
3886fc7934
|
code with error
|
3 years ago |
|
Alexis Drai
|
fc6a71801f
|
✅ Get UTs done
|
3 years ago |
|
Alexis Drai
|
55436e15a9
|
🎨 🐛 fix bug in Remove, use affirmative statements, reformat
|
3 years ago |
|
mohammad_zafir.jeeawody
|
b84818610e
|
validation method
|
3 years ago |
|
Alexis Drai
|
a0d3caf91c
|
💩 Include methods that throw NotSupportedExceptions for now
|
3 years ago |
|
Alexis Drai
|
2fa185829f
|
✏️ ♻️ Rename Faces and override GetRandomFace()
"ListFaces" was misleading because it is not a list
GetRandomFace should return a Face<T> when called from a HomogeneousDie
|
3 years ago |
|
Alexis Drai
|
753789bcd4
|
🚧 Make data classes internal, start implementing DBManager
|
3 years ago |
|
Alexis Drai
|
32d07e1e3c
|
🩹 Add default value for layer name
|
3 years ago |
|
Alexis Drai
|
d4d587afb9
|
✨ Simplify code and give more freedom
by introducing HomogeneousDie, changing the logic in Face, and making class names shorter
|
3 years ago |
|
Ismail TAHA JANAN
|
3a263b4dca
|
simple commit
|
3 years ago |
|
Ismail TAHA JANAN
|
1149c916c4
|
simple commit
|
3 years ago |
|
Alexis Drai
|
b0bb332f41
|
💩 Include methods that throw NotSupportedExceptions for now
|
3 years ago |
|
Ismail TAHA JANAN
|
6e6f999b09
|
simple commit
|
3 years ago |
|
Alexis Drai
|
55d1f95fd1
|
📝 Add comments and validation to DieManager
|
3 years ago |
|
Alexis Drai
|
ac6c6b0740
|
📝 Update comments a little bit
|
3 years ago |
|
Alexis Drai
|
03bf800fe7
|
🐛 Use polymorphism
|
3 years ago |
|
Alexis Drai
|
006b35066d
|
♻️ Refactor UTs and hope that SonarQube updates coverage
|
3 years ago |
|
Alexis Drai
|
455f1210ef
|
✅ Complete test suite, add checks to R and U
|
3 years ago |
|
Alexis Drai
|
3c74fa4962
|
🚧 WIP
|
3 years ago |
|
Alexis Drai
|
c46d88029b
|
♻️ Remove extra methods, make Game.PlayerManager usable
|
3 years ago |
|
Alexis Drai
|
c59eaceaff
|
♻️ Refactor CRUD on players and die into Manager properties
|
3 years ago |
|
Alexis Drai
|
9d92f3b84f
|
✨ Make GameRunner implement the IManager interface
since it already did (pretty much)
|
3 years ago |
|
Alexis Drai
|
e0abed2590
|
🔥 Remove ption to use shorter hexcodes for colors
|
3 years ago |
|
Alexis Drai
|
855d697572
|
🩹 Make method static, remove Load
PlayGame was never using any instance data, so it could be made static for performance gains
|
3 years ago |
|
Alexis Drai
|
daf468463c
|
👔 Finish GameRunner class for now
|
3 years ago |
|
Alexis Drai
|
2ee91862cf
|
🚧 WIP
|
3 years ago |
|
Alexis Drai
|
8f42e7577e
|
Add comments, break keyboard..?
|
3 years ago |
|
Alexis Drai
|
295d43e3ce
|
🔥 Simplify adding turns
|
3 years ago |
|
Alexis Drai
|
3631af4e8a
|
🚨 Seal Turn and implement IEquatable
|
3 years ago |
|
Alexis Drai
|
9da428862f
|
Override equals and hash, add UTs
|
3 years ago |
