Alexis Drai
359d5845bf
Merge pull request ' ✅ 👔 Create Turn class and corresponding UTs' ( #53 ) from create-turn-class into main
...
Reviewed-on: #53
2 years ago
Alexis Drai
85e16cf590
✅ Implement UTs on Turn class
2 years ago
Alexis Drai
d734fd9215
✅ 👔 Add Turn class and first UTs
2 years ago
Alexis Drai
9d898c0337
🔀 Merge #52 into main
2 years ago
Alexis Drai
bbfe7291c4
🩹 Fix code smell
2 years ago
Alexis Drai
1ad5c7cf21
🛂 ✅ Add null checks and exceptions, reflect change in UTs
2 years ago
Alexis Drai
180c50b2c7
🩹 Improve exception-throwing
2 years ago
Alexis Drai
86597ef08f
🩹 Remove old or useless TODOs
2 years ago
Alexis Drai
fb02307b28
🩹 Move validation to constructor, clarify with comments
2 years ago
Alexis Drai
e85b9e5550
♻️ Refactor, D.R.Y., use "expected" and "actual"
2 years ago
Alexis Drai
fb69b719b4
✅ Generalize from HashSets to IEnumerables or Collections
2 years ago
Alexis Drai
0f3471cb60
✏️ Fix typo
2 years ago
Alexis Drai
a5483b3850
✅ Improve Update() test after bugfix
2 years ago
Alexis Drai
d36afce173
🐛 Add validation and delegation to Player.Remove()
2 years ago
Alexis Drai
fd00107e5f
🩹 Pass params by vals instead of by refs
...
if we pass parameters by reference, it must be because we want to
change them in the method and to keep those changes.
This seems like a different situation, so we should be able
to pass the objects by value.
2 years ago
Alexis Drai
fd661d5b5c
Merge pull request ' 🐛 ♻️ ✅ Fix-uts' ( #51 ) from fix-uts into main
...
Reviewed-on: #51
2 years ago
Alexis Drai
ae063bb58a
📝 Fix badges
2 years ago
Alexis Drai
10690dc991
♻️ Refactor, D.R.Y., use "expected" and "actual"
2 years ago
Alexis Drai
e3a86a67b9
✅ Generalize from HashSets to IEnumerables or Collections
2 years ago
Alexis Drai
085e27122a
✏️ Fix typo
2 years ago
Alexis Drai
4472c56354
✅ Improve Update() test after bugfix
2 years ago
Alexis Drai
f1404f829d
🐛 Add validation and delegation to Player.Remove()
2 years ago
Alexis Drai
dcb9de97e5
🩹 Pass params by vals instead of by refs
...
if we pass parameters by reference, it must be because we want to
change them in the method and to keep those changes.
This seems like a different situation, so we should be able
to pass the objects by value.
2 years ago
Alexis Drai
e9f628c2da
✅ Add one last test to PlayerManager
2 years ago
Alexis Drai
bfc5a79fc0
Merge pull request ' ✅ Fix #29 ut-playermanager' ( #49 ) from ut-playermanager into main
...
Reviewed-on: #49
2 years ago
Alexis Drai
ab2febf1b8
Merge pull request 'smells' ( #48 ) from smells into main
...
Reviewed-on: #48
2 years ago
Alexis Drai
923c42b9f2
✏️ Fix typo
2 years ago
Alexis Drai
9994798c6f
✅ Design unit tests for PlayerManager
2 years ago
Alexis Drai
60c6b0c0c9
Merge pull request 'Complete #27 -- ut-player' ( #45 ) from ut-player into main
...
Reviewed-on: #45
2 years ago
Alexis Drai
33f390b074
✅ 👔 Trim player names and update tests
2 years ago
Alexis Drai
b65fe617bc
♻️ Refactor repeated Fact test into a Theory test
2 years ago
Alexis Drai
92e59083be
Merge pull request ' 👔 Complete #26 -- Code PlayerManager' ( #43 ) from code-player-manager into main
...
Reviewed-on: #43
2 years ago
Alexis Drai
3c2799d363
Merge pull request ' 👔 Complete #15 -- Create the Player class' ( #42 ) from code-player into main
...
Reviewed-on: #42
2 years ago
Alexis Drai
9e4b92f560
Remove redundant check to string value
2 years ago
Alexis Drai
2bf7918a6f
🐛 Add dummy code to remove code smell...
2 years ago
Alexis Drai
ff6e634da1
🐛 Fix #47
2 years ago
Alexis Drai
1593ca1b49
✅ Remove dummy code to improve coverage
2 years ago
Alexis Drai
676413959c
🚨 Fix #46
2 years ago
Alexis Drai
bfe20a653c
✅ Complete #27 and Fix #44
2 years ago
Alexis Drai
0995660259
✅ Design UTs for Player
2 years ago
Alexis Drai
bd1502436d
🐛 Make hash case insensitive, check name validity
2 years ago
Alexis Drai
5c3dccfa04
👔 Complete #26 -- Code PlayerManager
2 years ago
Alexis Drai
9fa4fb56ea
👔 Create the Player class
2 years ago
Alexis Drai
e243144fe5
🚑 Fix IManager (genericity)
...
this makes it possible to manipulate the arguments
2 years ago
Alexis Drai
f30fbbbca6
🚑 Fix build
...
by implementing IManager correctly in PlayerManager
2 years ago
Alexis Drai
78f02448b2
🩹 Fix #38
2 years ago
31f988dcb0
add PlayerManager class and stub class
2 years ago
Najlae LAMBARAA
9c09323f95
Merge pull request 'WIP Finir interface Manager' ( #37 ) from creer_interface_manager into main
...
Reviewed-on: #37
2 years ago
Alexis Drai
f11e86f4d9
Merge pull request 'WIP Creer interface IManager' ( #36 ) from creer_interface_manager into main
...
Reviewed-on: #36
2 years ago
Najlae LAMBARAA
9c60eb9f53
Finir interface Manager
2 years ago
Ismail TAHA JANAN
