 Alexis Drai
|
c61ffeb783
|
🐛 Replace Equals with SequenceEqual
still not foolproof, since Die and Face don't redefine equals etc.
the reason why all the tests pass is because we don't have UTs for DiceGroupManager
|
3 years ago |
|
Alexis Drai
|
d259884ba8
|
🚨 Encapsulate collections...
make code more readable
add checks and UTs for Utils.Enumerables
|
3 years ago |
|
Alexis Drai
|
a2d832a9f2
|
🚧 WIP
|
3 years ago |
|
Alexis Drai
|
e5fc62499f
|
📈 🔥 Remove unused and untestable code
|
3 years ago |
|
Alexis Drai
|
a319d7deb2
|
🚨 fix code smells
|
3 years ago |
|
Alexis Drai
|
a46d4b73a4
|
⚗️ Play around with async-await
PlayerManager.Remove is bugged
|
3 years ago |
|
Alexis Drai
|
ca3ec81ae6
|
🐛 Prevent Die ctor from making dice with no face
|
3 years ago |
|
Alexis Drai
|
1f2ca7483f
|
♻️ Rename DieManager to DiceGroupManager
that class is in charge of managing groups of dice (in association with a string name)
|
3 years ago |
|
Alexis Drai
|
0769b5116f
|
🐛 Throw appropriate exception when trying to update the Die collection itself
|
3 years ago |
|
Alexis Drai
|
a987f36eac
|
🔥 Clean up imports
|
3 years ago |
Ismail TAHA JANAN
|
e49afa3b14
|
🩹 improve code
|
3 years ago |
|
Ismail TAHA JANAN
|
949521ff9b
|
✅ conflict solved
|
3 years ago |
|
Ismail TAHA JANAN
|
f2eafe4ded
|
fix merging conflict
|
3 years ago |
|
Ismail TAHA JANAN
|
3886fc7934
|
code with error
|
3 years ago |
|
Alexis Drai
|
1683414231
|
🎨 🐛 fix bug in Remove, use affirmative statements, reformat
|
3 years ago |
|
mohammad_zafir.jeeawody
|
678d1f7de5
|
validation method
|
3 years ago |
|
Alexis Drai
|
2fa185829f
|
✏️ ♻️ Rename Faces and override GetRandomFace()
"ListFaces" was misleading because it is not a list
GetRandomFace should return a Face<T> when called from a HomogeneousDie
|
3 years ago |
|
Alexis Drai
|
d4d587afb9
|
✨ Simplify code and give more freedom
by introducing HomogeneousDie, changing the logic in Face, and making class names shorter
|
3 years ago |
|
Ismail TAHA JANAN
|
3a263b4dca
|
simple commit
|
3 years ago |
|
Ismail TAHA JANAN
|
1149c916c4
|
simple commit
|
3 years ago |
|
Alexis Drai
|
b0bb332f41
|
💩 Include methods that throw NotSupportedExceptions for now
|
3 years ago |
|
Ismail TAHA JANAN
|
6e6f999b09
|
simple commit
|
3 years ago |
|
Alexis Drai
|
55d1f95fd1
|
📝 Add comments and validation to DieManager
|
3 years ago |
|
Alexis Drai
|
e0abed2590
|
🔥 Remove ption to use shorter hexcodes for colors
|
3 years ago |
|
Alexis Drai
|
82c36049f2
|
🎨 Improve die faces, expose Value, make use of inheritance
|
3 years ago |
|
Alexis Drai
|
7f10eaed24
|
🐛 Fix call to Random.Next()
Next(a, b) returns a random int between a (INCLUDED) and
b (EXCLUDED) -- that is, in [a, b[
|
3 years ago |
|
Alexis Drai
|
535631e0e1
|
🐛 Change 2-tuple to dictionary
|
3 years ago |
|
Alexis Drai
|
6f73dc5abf
|
🐛 Debug genericity
|
3 years ago |
|
Alexis Drai
|
a4f0b3948e
|
⚰️ Remove dead code (names for dice)
|
3 years ago |
|
Alexis Drai
|
242cc86a79
|
🩹 fix #64
|
3 years ago |
|
Alexis Drai
|
dcef907f24
|
🩹 fix #64
|
3 years ago |
|
Alexis Drai
|
86ff2fe752
|
🔥 ⚰️ Fix #60
|
3 years ago |
|
Alexis Drai
|
aaa94de362
|
🏗️ Fix #67
|
3 years ago |
|
Ismail TAHA JANAN
|
5a76434f96
|
🎨 chanege Random type to static
|
3 years ago |
|
Ismail TAHA JANAN
|
344a0fb9ac
|
🎨 improve code performance
|
3 years ago |
|
Ismail TAHA JANAN
|
9292a2cc44
|
🩹 #59 : some name spaces
|
3 years ago |
|
Ismail TAHA JANAN
|
8a81f2ddd7
|
🩹 #59 fix: add some name spaces
|
3 years ago |
|
Ismail TAHA JANAN
|
da6babe2dd
|
#59 : �🩹 fix: more conflict fixing
|
3 years ago |
|
Alexis Drai
|
0f9f581603
|
⚗️ Add content to the stub to explore the logic of the app
|
3 years ago |
|
Alexis Drai
|
48db9ba6de
|
💡♻️ Add to Game thanks to new classes, add fixes
|
3 years ago |
|
Alexis Drai
|
7e85dba135
|
🩹 Fix code smells
|
3 years ago |
|
Alexis Drai
|
7389ee8756
|
✅💬 Include AbstractDieFace in Turn, update ToString(), pass tests
|
3 years ago |
|
Alexis Drai
|
011db706e0
|
🏗️📦️ Make separate packages for clarity
|
3 years ago |
