WIP: TU_Dice #183

Closed
ismail.taha_janan wants to merge 5 commits from TU_Dice into main
Collaborator
There is no content yet.
ismail.taha_janan added 5 commits 2 years ago
continuous-integration/drone/push Build is failing Details
206786271a
code with error
continuous-integration/drone/push Build is passing Details
67edaf0e9b
♻️ Turn Theory into Fact
continuous-integration/drone/push Build is passing Details
190c2adba6
Merge pull request '♻️ Turn Theory into Fact' (#109) from fix-TU-faces into TU_faces
continuous-integration/drone/push Build is passing Details
f2957f06e2
Faces Test implemented
continuous-integration/drone/push Build is passing Details
1ee0e762b4
test fore dices
alexis.drai approved these changes 2 years ago
alexis.drai left a comment
Owner

lgtm, just a few details

lgtm, just a few details
Color.FromArgb(144, 255, 78, 240),
};
yield return new object[]
{
Owner

these are both the same, is it normal?

these are both the same, is it normal?
using System.Threading.Tasks;
using Xunit;
using System.Drawing;
using Model.Dice.Faces;
Owner

please remove this 'using' (double using, code smell)

please remove this 'using' (double using, code smell)
alexis.drai changed title from TU_Dice to WIP: TU_Dice 2 years ago
alexis.drai requested review from alexis.drai 2 years ago
Owner

Wait, this branch is based on the main branch from 6 days ago. You're gonna have so many conflicts.

Can you just make a new branch from main, and then paste your unit tests in the corresponding files?

thanks

Wait, this branch is based on the main branch from 6 days ago. You're gonna have so many conflicts. Can you just make a new branch from main, and then paste your unit tests in the corresponding files? thanks
alexis.drai closed this pull request 2 years ago

Reviewers

alexis.drai was requested for review 2 years ago
All checks were successful
continuous-integration/drone/push Build is passing
Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Loading…
There is no content yet.