WIP: TU_Dice
#183
Closed
ismail.taha_janan
wants to merge 5 commits from TU_Dice
into main
pull from: TU_Dice
merge into: alexis.drai:main
alexis.drai:test_dice_group_manager
alexis.drai:Read_me
alexis.drai:main
alexis.drai:doxygen
alexis.drai:EF_Dice_Faces
alexis.drai:fix-dgmgrut
alexis.drai:TU_faces
alexis.drai:fix_die_and_faces_structure
alexis.drai:TU_NumberDieFace
Reviewers
Request review
No reviewers
Labels
Something is not working code smell
Not exactly a bug, but this code will cause problems down the line doc
About documentation duplicate
This issue or pull request already exists fixed
This issue has been fixed, but should not be closed yet help wanted
Need some help invalid
Something is wrong low priority
This issue has a lower priority meta
About issues / tickets themselves nice to have
This would be nice to have, but not essential performance
This is to improve performance in some way prerequisite
These issues needs to be resolved before moving on to any other issue question
More information is needed required
New requirement setup
About the project tree or structure testing
About code quality and testing waiting for release
This issue will need to be resolved when we release, but not before wontfix
This won't be fixed
Apply labels
Clear labels
bug
Something is not working code smell
Not exactly a bug, but this code will cause problems down the line doc
About documentation duplicate
This issue or pull request already exists fixed
This issue has been fixed, but should not be closed yet help wanted
Need some help invalid
Something is wrong low priority
This issue has a lower priority meta
About issues / tickets themselves nice to have
This would be nice to have, but not essential performance
This is to improve performance in some way prerequisite
These issues needs to be resolved before moving on to any other issue question
More information is needed required
New requirement setup
About the project tree or structure testing
About code quality and testing waiting for release
This issue will need to be resolved when we release, but not before wontfix
This won't be fixed
No Label
bug
code smell
doc
duplicate
fixed
help wanted
invalid
low priority
meta
nice to have
performance
prerequisite
question
required
setup
testing
waiting for release
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Dependencies
No dependencies set.
Reference: alexis.drai/dice_app#183
Reference in new issue
There is no content yet.
Delete Branch 'TU_Dice'
Deleting a branch is permanent. It CANNOT be undone. Continue?
No
Yes
lgtm, just a few details
Color.FromArgb(144, 255, 78, 240),
};
yield return new object[]
{
these are both the same, is it normal?
using System.Threading.Tasks;
using Xunit;
using System.Drawing;
using Model.Dice.Faces;
please remove this 'using' (double using, code smell)
TU_Diceto WIP: TU_Dice 3 years agoWait, this branch is based on the main branch from 6 days ago. You're gonna have so many conflicts.
Can you just make a new branch from main, and then paste your unit tests in the corresponding files?
thanks
Reviewers