alexis.drai
/
dice_app
0
0
Fork 0
Code Issues 60 Pull Requests Packages Projects 1 Releases Wiki Activity
Labels Milestones

✅ Fix UT, fix Tests.csproj, move UT file to proper folder #184

Closed
alexis.drai wants to merge 1 commits from fix-dgmgrut into test_dice_group_manager
Conversation 0 Commits 1 Files Changed 3
alexis.drai commented 2 years ago
Owner

Here is my proposed fix.

You can simply use Assert.Equal from Xunit to compare to IEnumerables. It'll just use A.Get(i).Equals(B.Get(i)) or something like that

For test methods with a Fact annotation, you should not use arguments. Those will be useful for theories.

In general, I believe that if you take all the unit tests from GameManager, and translate the method signatures and bodies for DiceGroups ( KeyValuePair<string, IEnumerable<Die>> ), you'll be just fine.

Here is my proposed fix. You can simply use `Assert.Equal` from Xunit to compare to `IEnumerable`s. It'll just use `A.Get(i).Equals(B.Get(i))` or something like that For test methods with a `Fact` annotation, you should not use arguments. Those will be useful for theories. In general, I believe that if you take all the unit tests from GameManager, and translate the method signatures and bodies for DiceGroups ( `KeyValuePair<string, IEnumerable<Die>>` ), you'll be just fine.
alexis.drai added 1 commit 2 years ago
continuous-integration/drone/push Build is passing Details
781d77fda3 ✅ Fix UT, fix Tests.csproj, move UT file to proper folder
alexis.drai requested review from mohammad_zafir.jeeawody 2 years ago
alexis.drai closed this pull request 1 year ago
alexis.drai removed review request for mohammad_zafir.jeeawody 1 year ago
All checks were successful
continuous-integration/drone/push Build is passing
Details
Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug
Something is not working code smell
Not exactly a bug, but this code will cause problems down the line doc
About documentation duplicate
This issue or pull request already exists fixed
This issue has been fixed, but should not be closed yet help wanted
Need some help invalid
Something is wrong low priority
This issue has a lower priority meta
About issues / tickets themselves nice to have
This would be nice to have, but not essential performance
This is to improve performance in some way prerequisite
These issues needs to be resolved before moving on to any other issue question
More information is needed required
New requirement setup
About the project tree or structure testing
About code quality and testing waiting for release
This issue will need to be resolved when we release, but not before wontfix
This won't be fixed
No Label bug code smell doc duplicate fixed help wanted invalid low priority meta nice to have performance prerequisite question required setup testing waiting for release wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: alexis.drai/dice_app#184
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fix-dgmgrut'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes