alexis.drai
/
dice_app
0
0
Fork 0
Code Issues 60 Pull Requests Packages Projects 1 Releases Wiki Activity
Labels Milestones

🐛 Replace Equals with SequenceEqual for a collection #200

Merged
alexis.drai merged 1 commits from apply-fixes-following-interview into main 2 years ago
Conversation 0 Commits 1 Files Changed 1
alexis.drai commented 2 years ago
Owner

still not foolproof, since Die and Face don't redefine equals etc.

the reason why all the tests pass is because we don't have UTs for DiceGroupManager

still not foolproof, since Die and Face don't redefine equals etc. the reason why all the tests pass is because we don't have UTs for DiceGroupManager
alexis.drai added 1 commit 2 years ago
continuous-integration/drone/push Build is passing Details
c61ffeb783 🐛 Replace Equals with SequenceEqual
alexis.drai merged commit 89c98fef2c into main 2 years ago
alexis.drai deleted branch apply-fixes-following-interview 2 years ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as 89c98fef2c.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug
Something is not working code smell
Not exactly a bug, but this code will cause problems down the line doc
About documentation duplicate
This issue or pull request already exists fixed
This issue has been fixed, but should not be closed yet help wanted
Need some help invalid
Something is wrong low priority
This issue has a lower priority meta
About issues / tickets themselves nice to have
This would be nice to have, but not essential performance
This is to improve performance in some way prerequisite
These issues needs to be resolved before moving on to any other issue question
More information is needed required
New requirement setup
About the project tree or structure testing
About code quality and testing waiting for release
This issue will need to be resolved when we release, but not before wontfix
This won't be fixed
No Label bug code smell doc duplicate fixed help wanted invalid low priority meta nice to have performance prerequisite question required setup testing waiting for release wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: alexis.drai/dice_app#200
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'apply-fixes-following-interview'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes