smells #48

Merged
alexis.drai merged 5 commits from smells into main 3 years ago

@ -7,11 +7,7 @@ namespace App
{ {
static void Main(string[] args) static void Main(string[] args)
{ {
Debug.WriteLine("Hello Debug!"); Debug.WriteLine("HelloWorld");
Player player = new Player("John");
Die die = new Die("I'm a die");
Debug.WriteLine(player.Name);
Debug.WriteLine(die.Name);
} }
} }
} }

@ -3,7 +3,7 @@ using System.Xml.Linq;
namespace Model namespace Model
{ {
public class Player : IEquatable<Player> public sealed class Player : IEquatable<Player>
{ {
public string Name public string Name
{ {
@ -13,7 +13,7 @@ namespace Model
} }
internal set internal set
{ {
if (!String.IsNullOrWhiteSpace(value) && !value.Equals("")) if (!String.IsNullOrWhiteSpace(value))
{ {
name = value; name = value;
} }

@ -55,7 +55,7 @@ namespace Model
/// <returns>player with said name</returns> /// <returns>player with said name</returns>
public Player GetOneByName(string name) public Player GetOneByName(string name)
{ {
if (!String.IsNullOrWhiteSpace(name) && !name.Equals("")) if (!String.IsNullOrWhiteSpace(name))
{ {
Player result = players.FirstOrDefault(p => p.Name.Equals(name)); Player result = players.FirstOrDefault(p => p.Name.Equals(name));
return new Player(result); // THIS IS A COPY (using a copy constructor) return new Player(result); // THIS IS A COPY (using a copy constructor)

Loading…
Cancel
Save