Correcting code smells

.gitignore

@@ -12,4 +12,4 @@ web-build/
 node_modules/
 # macOS
 .DS_Store
-./src/test/coverage
+./src/test/coverage/lcov-report/

src/components/DetailExamples.tsx

@@ -3,11 +3,11 @@ import { FlatList, StyleSheet, Text, useColorScheme, View } from 'react-native';
 
 
 
-interface detailExamplesProps {
+interface DetailExamplesProps {
     data: { japanese: string, english: string }[]
 }
 
-const DetailExamples = (props: detailExamplesProps) => {
+const DetailExamples = (props: DetailExamplesProps) => {
 
     const detailExamplesStyle = useColorScheme() == 'light' ? detailExamplesStyle_light : detailExamplesStyle_dark;
 

src/components/DetailRadical.tsx

@@ -5,12 +5,12 @@ import { learnihonColors } from '../assets/colors';
 
 
 
-interface detailRadicalProps {
+interface DetailRadicalProps {
     character: string,
     icon: string
 }
 
-const DetailRadical = (props: detailRadicalProps) => {
+const DetailRadical = (props: DetailRadicalProps) => {
 
     const detailRadicalStyle = useColorScheme() == 'light' ? detailRadicalStyle_light : detailRadicalStyle_dark;
     return (

src/components/GradeChip.tsx

@@ -3,12 +3,12 @@ import { StyleSheet, Text, TouchableOpacity } from 'react-native';
 import { Check } from "react-native-feather";
 import { learnihonColors } from '../assets/colors';
 
-interface gradeChipProps {
+interface GradeChipProps {
     grade: number;
     onSelect: (item: string, isSelected: boolean) => void;
 }
 
-const GradeChip = (props: gradeChipProps) => {
+const GradeChip = (props: GradeChipProps) => {
 
     const [chipStyle, setChipStyle] = useState(style);
 

src/components/GradeChipList.tsx

@@ -2,11 +2,11 @@ import React from "react";
 import { FlatList, StyleSheet, View } from "react-native";
 import GradeChip from './GradeChip';
 
-interface kanjiListSeachPanelProps {
+interface KanjiListSeachPanelProps {
     onSelect: (item: string, isSelected: boolean) => void;
 }
 
-const GradeChipList = (props: kanjiListSeachPanelProps) => {
+const GradeChipList = (props: KanjiListSeachPanelProps) => {
 
     return (
         <View style={panelStyle.container}>

src/components/KanjiAnswerField.tsx

@@ -1,12 +1,12 @@
 import React from 'react';
 import { StyleSheet, TextInput, View } from 'react-native';
 
-interface kanjiAnswerFieldProps { 
+interface KanjiAnswerFieldProps { 
     answer: string,
     setAnswer: React.Dispatch<React.SetStateAction<string>>
 }
 
-const KanjiAnswerField = (props: kanjiAnswerFieldProps) => {
+const KanjiAnswerField = (props: KanjiAnswerFieldProps) => {
 
 
     return (

src/components/KanjiCard.tsx

@@ -22,7 +22,7 @@ const KanjiCard = () => {
     })
     const [loadingSvg, setLoadingSvg] = useState(false);
     const [selectedItems, setSelectedItems] = useState<{ title: string, data: Kanji[] }[]>([]);
-    const updateSelectedItems = (item: string, isSelected: Boolean) => {
+    const updateSelectedItems = (item: string, isSelected: boolean) => {
         if (!isSelected) {
             setSelectedItems([...selectedItems, {
                 title: item,
@@ -53,7 +53,7 @@ const KanjiCard = () => {
     const fetchXml = async () => {
         if (kanji) {
             setLoadingSvg(true);
-            const xml = await (await fetch(kanji?.image!)).text();
+            const xml = await (await fetch(kanji?.image)).text();
             setImgXml(xml);  
             setLoadingSvg(false);
         }

src/components/KanjiList.tsx

@@ -1,6 +1,6 @@
-import React, { useEffect, useState } from 'react';
+import React, { useState } from 'react';
 import { SectionList, StyleSheet, Text, useColorScheme, View } from 'react-native';
-import { useDispatch, useSelector } from 'react-redux';
+import { useSelector } from 'react-redux';
 import { learnihonColors } from '../assets/colors';
 import { Kanji } from '../model/kanji';
 import { KanjiListByGrade } from '../model/kanjiListByGrades';

src/components/KanjiListCell.tsx

@@ -6,11 +6,11 @@ import { Kanji } from '../model/kanji';
 import { calcCorrectGuessesRatio, getColorByRatio } from '../model/kanjiGuess';
 import { retrieveGuess } from '../storage/storage';
 
-interface kanjiListCellProps {
+interface KanjiListCellProps {
     kanji: Kanji;
 }
 
-const KanjiListCell = React.memo((props: kanjiListCellProps) => {
+const KanjiListCell = React.memo((props: KanjiListCellProps) => {
 
     const cellStyle = useColorScheme() == 'light' ? cellStyle_light : cellStyle_dark;
 
@@ -30,7 +30,7 @@ const KanjiListCell = React.memo((props: kanjiListCellProps) => {
 
     useMemo(async () => {
         const guess = await retrieveGuess(props.kanji.character);
-        const ratio = guess ? await calcCorrectGuessesRatio(guess) : -1;
+        const ratio = guess ? calcCorrectGuessesRatio(guess) : -1;
         setRatio(ratio);
     }, []);
 

src/navigation/Startup.tsx

@@ -42,7 +42,6 @@ export default function Startup() {
     const init = async () => {
         
         await (await fetchKanjis())(dispatch);
-        //await new Promise(resolve => setTimeout(resolve, 5000));
         navigator.replace("Main");
     }
 

src/storage/storage.ts

@@ -7,7 +7,7 @@ export const retrieveGuess = async (kanji: string) => {
         if (value === null) {
             return null;
         }
-        const guess: KanjiGuess = await JSON.parse(value!)
+        const guess: KanjiGuess = await JSON.parse(value)
         return guess;
     } catch (error) {
         console.log(error)