Changed program.cs for versioning in the swagger, also fixed uniqueness issues and created 3 versions of the ChampionController ✅

src/EntityFramework_LoL/Sources/ApiLol/ApiLol.csproj

@@ -9,6 +9,8 @@
   </PropertyGroup>
 
   <ItemGroup>
+    <PackageReference Include="Microsoft.AspNetCore.Mvc.Versioning" Version="5.0.0" />
+    <PackageReference Include="Microsoft.AspNetCore.Mvc.Versioning.ApiExplorer" Version="5.0.0" />
     <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="7.0.2" />
     <PackageReference Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.15.1" />
     <PackageReference Include="Swashbuckle.AspNetCore" Version="6.2.3" />

src/EntityFramework_LoL/Sources/ApiLol/Controllers/SkinsController.cs

@@ -0,0 +1,73 @@
+using ApiLol.Mapper;
+using DTO;
+using Microsoft.AspNetCore.Mvc;
+using Model;
+
+// For more information on enabling Web API for empty projects, visit https://go.microsoft.com/fwlink/?LinkID=397860
+
+namespace ApiLol.Controllers
+{
+    [Route("api/[controller]")]
+    [ApiController]
+    public class SkinsController : ControllerBase
+    {
+        private readonly IDataManager _manager;
+        private readonly ILogger<SkinsController> _logger;
+
+        public SkinsController(IDataManager dataManager, ILogger<SkinsController> logger)
+        {
+            _logger = logger;
+            this._manager = dataManager;
+        }
+
+        // GET: api/<SkinsController>
+        [HttpGet]
+        public async Task<IActionResult> Get([FromQuery] PageRequest pageRequest)
+        {
+            try
+            {
+                int nbTotal = await _manager.ChampionsMgr.GetNbItems();
+                if (pageRequest.count + pageRequest.index > nbTotal)
+                {
+                    _logger.LogWarning($"too many, maximum {nbTotal}");
+                    return BadRequest($"Champion limit exceed, max {nbTotal}");
+                }
+
+                _logger.LogInformation($"method Get call");
+                IEnumerable<SkinDtoC> dtos = (await _manager.SkinsMgr.GetItems(pageRequest.index, pageRequest.count))
+                    .Select(x => x.ToDtoC());
+                return Ok(dtos);
+
+            }
+            catch (Exception e)
+            {
+                return BadRequest(e.Message);
+            }
+        }
+
+        // GET api/<SkinsController>/5
+        [HttpGet("{name}")]
+        public async Task<IActionResult> Get(string name)
+        {
+            return Ok();
+        }
+
+        // POST api/<SkinsController>
+        [HttpPost]
+        public async void Post([FromBody] string value)
+        {
+        }
+
+        // PUT api/<SkinsController>/5
+        [HttpPut("{name}")]
+        public async void Put(int id, [FromBody] string value)
+        {
+        }
+
+        // DELETE api/<SkinsController>/5
+        [HttpDelete("{name}")]
+        public async void Delete(string name)
+        {
+        }
+    }
+}

src/EntityFramework_LoL/Sources/ApiLol/Controllers/v1/ChampionsController.cs

@@ -0,0 +1,84 @@
+using ApiLol.Mapper;
+using DTO;
+using Microsoft.AspNetCore.Mvc;
+using Microsoft.IdentityModel.Tokens;
+using Model;
+
+// For more information on enabling Web API for empty projects, visit https://go.microsoft.com/fwlink/?LinkID=397860
+
+namespace ApiLol.Controllers.v1
+{
+    [ApiVersion("1.0")]
+    [Route("api/v{version:apiVersion}/[controller]")]
+    [ApiController]
+    public class ChampionsController : ControllerBase
+    {
+        private readonly IDataManager _manager;
+        private readonly ILogger<ChampionsController> _logger;
+        public ChampionsController(IDataManager dataManager, ILogger<ChampionsController> logger)
+        {
+            _logger = logger;
+            this._manager = dataManager;
+        }
+
+        // GET: api/<ValuesController>
+        [HttpGet]
+        public async Task<IActionResult> Get([FromQuery] PageRequest pageRequest)
+        {
+
+            int nbTotal = await _manager.ChampionsMgr.GetNbItems();
+
+            _logger.LogInformation($"method Get call");
+            IEnumerable<ChampionDto> dtos = (await _manager.ChampionsMgr.GetItems(pageRequest.index, pageRequest.count))
+                    .Select(x => x.ToDto());
+            return Ok(dtos);
+        }
+
+        // GET api/<ValuesController>/5
+        [HttpGet("{name}")]
+        public async Task<IActionResult> Get(string name)
+        {
+            _logger.LogInformation($"method GetByName call with {name}");
+            var dtos = (await _manager.ChampionsMgr.GetItemsByName(name, 0, await _manager.ChampionsMgr.GetNbItems()))
+                .Select(x => x.ToDto());
+
+            return Ok(dtos);
+
+        }
+
+        // POST api/<ValuesController>
+        [HttpPost]
+        public async Task<IActionResult> Post([FromBody] ChampionDto champion)
+        {
+
+            _logger.LogInformation($"method Post call");
+            return CreatedAtAction(nameof(Get),
+                    (await _manager.ChampionsMgr.AddItem(champion.ToModel())).ToDto());
+
+        }
+
+        // PUT api/<ValuesController>/5
+        [HttpPut("{name}")]
+        public async Task<IActionResult> Put(string name, [FromBody] ChampionDto champion)
+        {
+
+            _logger.LogInformation($"method Put call with {name}");
+            var dtos = (await _manager.ChampionsMgr.GetItemsByName(name, 0, await _manager.ChampionsMgr.GetNbItems()));
+
+            return Ok(await _manager.ChampionsMgr.UpdateItem(dtos.First(), champion.ToModel()));
+
+        }
+
+        // DELETE api/<ValuesController>/5
+        [HttpDelete("{name}")]
+        public async Task<IActionResult> Delete(string name)
+        {
+
+            _logger.LogInformation($"method Delete call with {name}");
+            var dtos = (await _manager.ChampionsMgr.GetItemsByName(name, 0, await _manager.ChampionsMgr.GetNbItems()));
+
+            return Ok(await _manager.ChampionsMgr.DeleteItem(dtos.First()));
+
+        }
+    }
+}

src/EntityFramework_LoL/Sources/ApiLol/Controllers/v2/ChampionsController.cs

@@ -6,14 +6,16 @@ using Model;
 
 // For more information on enabling Web API for empty projects, visit https://go.microsoft.com/fwlink/?LinkID=397860
 
-namespace ApiLol.Controllers
+namespace ApiLol.Controllers.v2
 {
-    [Route("api/[controller]")]
+    [ApiVersion("2.0")]
+    [ApiVersion("3.0")]
+    [Route("api/v{version:apiVersion}/[controller]")]
     [ApiController]
     public class ChampionsController : ControllerBase
     {
         private readonly IDataManager _manager;
-        public readonly ILogger<ChampionsController> _logger;
+        private readonly ILogger<ChampionsController> _logger;
         public ChampionsController(IDataManager dataManager, ILogger<ChampionsController> logger)
         {
             _logger = logger;
@@ -27,7 +29,7 @@ namespace ApiLol.Controllers
             try
             {
                 int nbTotal = await _manager.ChampionsMgr.GetNbItems();
-                if (pageRequest.count + pageRequest.index > nbTotal)
+                if (pageRequest.count * pageRequest.index >= nbTotal)
                 {
                     _logger.LogWarning($"too many, maximum {nbTotal}");
                     return BadRequest($"Champion limit exceed, max {nbTotal}");
@@ -41,7 +43,35 @@ namespace ApiLol.Controllers
             catch (Exception e)
             {
                 return BadRequest(e.Message);
+            }
+        }
 
+        // GET: api/<ValuesController>
+        [HttpGet, MapToApiVersion("3.0")]
+        public async Task<IActionResult> GetV3([FromQuery] PageRequest pageRequest)
+        {
+            try
+            {
+                int nbTotal = await _manager.ChampionsMgr.GetNbItems();
+                if (pageRequest == null)
+                {
+                    pageRequest.index = 0;
+                    pageRequest.count = nbTotal;
+                }
+                else if (pageRequest.count * pageRequest.index >= nbTotal)
+                {
+                    _logger.LogWarning($"too many, maximum {nbTotal}");
+                    return BadRequest($"Champion limit exceed, max {nbTotal}");
+                }
+
+                _logger.LogInformation($"method Get call");
+                IEnumerable<ChampionDto> dtos = (await _manager.ChampionsMgr.GetItems(pageRequest.index, pageRequest.count))
+                        .Select(x => x.ToDto());
+                return Ok(dtos);
+            }
+            catch (Exception e)
+            {
+                return BadRequest(e.Message);
             }
         }
 
@@ -64,7 +94,6 @@ namespace ApiLol.Controllers
             catch (Exception e)
             {
                 return BadRequest(e.Message);
-
             }
         }
 
@@ -86,7 +115,6 @@ namespace ApiLol.Controllers
             catch (Exception e)
             {
                 return BadRequest(e.Message);
-
             }
         }
 
@@ -100,13 +128,13 @@ namespace ApiLol.Controllers
                 var dtos = (await _manager.ChampionsMgr.GetItemsByName(name, 0, await _manager.ChampionsMgr.GetNbItems()));
                 if (dtos.IsNullOrEmpty())
                 {
-                    return BadRequest("Name not exist");
+                    return NotFound("Name not exist");
                 }
                 // Checks if the new name exists
                 if (name != champion.Name)
                 {
                     var dtos2 = (await _manager.ChampionsMgr.GetItemsByName(champion.Name, 0, await _manager.ChampionsMgr.GetNbItems()));
-                    if (!dtos.IsNullOrEmpty())
+                    if (dtos.IsNullOrEmpty() || dtos2.Count() > 0)
                     {
                         return BadRequest("Name is already exist");
                     }
@@ -116,12 +144,11 @@ namespace ApiLol.Controllers
             catch (Exception e)
             {
                 return BadRequest(e.Message);
-
             }
         }
 
         [HttpGet("/{name}/skins")]
-        public async Task<ActionResult<Skin>> GetChampionsSkins(string name)
+        public async Task<ActionResult<SkinDto>> GetChampionsSkins(string name)
         {
             try
             {
@@ -134,12 +161,11 @@ namespace ApiLol.Controllers
             catch (Exception e)
             {
                 return BadRequest(e.Message);
-
             }
         }
 
         [HttpGet("/{name}/skills")]
-        public async Task<ActionResult<Skin>> GetChampionsSkills(string name)
+        public async Task<ActionResult<SkillDto>> GetChampionsSkills(string name)
         {
             try
             {

src/EntityFramework_LoL/Sources/ApiLol/Mapper/SkinMapper.cs

@@ -17,9 +17,23 @@ namespace ApiLol.Mapper
             };
         }
 
+        public static SkinDtoC ToDtoC(this Skin skin)
+        {
+            return new SkinDtoC()
+            {
+                Name = skin.Name,
+                Description = skin.Description,
+                Icon = skin.Icon,
+                Image = skin.Image.ToDto(),
+                Price = skin.Price,
+                ChampionName = skin.Champion.Name
+            };
+        }
+
         public static Skin ToModel(this SkinDto skinDto)
         {
             return new Skin(skinDto.Name, null, skinDto.Price, skinDto.Icon, skinDto.Image.Base64, skinDto.Description);
         }
+
     }
 }

src/EntityFramework_LoL/Sources/ApiLol/Program.cs

@@ -1,3 +1,5 @@
+using Microsoft.AspNetCore.Mvc.ApiExplorer;
+using Microsoft.AspNetCore.Mvc.Versioning;
 using Model;
 using StubLib;
 
@@ -9,14 +11,41 @@ builder.Services.AddControllers();
 // Learn more about configuring Swagger/OpenAPI at https://aka.ms/aspnetcore/swashbuckle
 builder.Services.AddEndpointsApiExplorer();
 builder.Services.AddSwaggerGen();
+
+
+builder.Services.AddApiVersioning(opt =>
+                                    {
+                                        opt.DefaultApiVersion = new Microsoft.AspNetCore.Mvc.ApiVersion(1, 0);
+                                        opt.AssumeDefaultVersionWhenUnspecified = true;
+                                        opt.ReportApiVersions = true;
+                                        opt.ApiVersionReader = ApiVersionReader.Combine(new UrlSegmentApiVersionReader(),
+                                                                                        new HeaderApiVersionReader("x-api-version"),
+                                                                                        new MediaTypeApiVersionReader("x-api-version"));
+                                    });
+// Add ApiExplorer to discover versions
+builder.Services.AddVersionedApiExplorer(setup =>
+{
+    setup.GroupNameFormat = "'v'VVV";
+    setup.SubstituteApiVersionInUrl = true;
+});
+
 builder.Services.AddSingleton<IDataManager, StubData>();
 
 var app = builder.Build();
 
 // Configure the HTTP request pipeline.
-app.UseSwagger();
+var apiVersionDescriptionProvider = app.Services.GetRequiredService<IApiVersionDescriptionProvider>();
-app.UseSwaggerUI();
 
+// Configure the HTTP request pipeline.
+app.UseSwagger();
+app.UseSwaggerUI(options =>
+{
+    foreach (var description in apiVersionDescriptionProvider.ApiVersionDescriptions)
+    {
+        options.SwaggerEndpoint($"/swagger/{description.GroupName}/swagger.json",
+            description.GroupName.ToUpperInvariant());
+    }
+});
 
 app.UseHttpsRedirection();
 

src/EntityFramework_LoL/Sources/Client/ChampionHttpClient.cs

@@ -23,12 +23,12 @@ namespace Client
             var url = $"{ApiChampions}?index={index}&count={count}";
             return await _httpClient.GetFromJsonAsync<IEnumerable<ChampionDto>>(url);
         }
-        public async void Add(ChampionDto champion)
+/*        public async void Add(ChampionDto champion)
         {
             await _httpClient.PostAsJsonAsync<ChampionDto>(ApiChampions, champion);
-        }
+        }*/
 
-        public async void Delete(ChampionDto champion)
+/*        public async void Delete(ChampionDto champion)
         {
             await _httpClient.DeleteAsync(champion.Name);
         }
@@ -36,7 +36,7 @@ namespace Client
         public async void Update(ChampionDto champion)
         {
             await _httpClient.PutAsJsonAsync<ChampionDto>(ApiChampions, champion);
-        }
+        }*/
 
     }
 }

src/EntityFramework_LoL/Sources/DTO/RuneDto.cs

@@ -1,4 +1,5 @@
-using System;
+using DTO.enums;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Text;
@@ -10,6 +11,8 @@ namespace DTO
     {
         public string Name { get; set; }
         public string Description { get; set; }
+        public RuneFamilyDto Family { get; set; }
+        public LargeImageDto Image { get; set; }
 
     }
 }

src/EntityFramework_LoL/Sources/DTO/SkinDtoC.cs

@@ -0,0 +1,20 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace DTO
+{
+    public class SkinDtoC
+    {
+        public string Name { get; set; }
+        public string Description { get; set; }
+        public string Icon { get; set; }
+        public LargeImageDto Image { get; set; }
+        public float Price { get; set; }
+        public string ChampionName { get; set; }
+
+
+    }
+}

src/EntityFramework_LoL/Sources/DTO/enums/RuneFamilyDto.cs

@@ -0,0 +1,15 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace DTO.enums
+{
+    public enum RuneFamilyDto
+    {
+        Unknown,
+        Precision,
+        Domination
+    }
+}

src/EntityFramework_LoL/Sources/StubLib/StubData.Champions.cs

@@ -84,7 +84,7 @@ namespace StubLib
                                     .Select(tuple => tuple.Item1)
                                     .Skip(index*count).Take(count));
 
-            private Func<Champion, string, bool> filterByName = (champ, substring) => champ.Name.Contains(substring, StringComparison.InvariantCultureIgnoreCase);
+            private Func<Champion, string, bool> filterByName = (champ, substring) => champ.Name.Equals(substring, StringComparison.InvariantCultureIgnoreCase);
 
             public Task<int> GetNbItemsByName(string substring)
                 => parent.champions.GetNbItemsWithFilter(champ => filterByName(champ, substring));

src/EntityFramework_LoL/Sources/Tests/ApiTests/ChampionsControllerTest.cs

@@ -1,4 +1,5 @@
 using ApiLol.Controllers;
+using ApiLol.Controllers.v2;
 using DTO;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.Extensions.Logging;
@@ -50,7 +51,6 @@ namespace ApiTests
                 Icon = "",
                 Image = new LargeImageDto() { Base64 = "" },
                 Skins = new List<SkinDto>()
-
             };
 
             //Act