CI : code smells

Blazor/Blazor/Components/DisplayQuestions.razor.cs

@@ -15,10 +15,10 @@ namespace Blazor.Components
         public Question question = new();
 
         private List<Answer> answers = new();
-        public List<Question> questions;
+        public List<Question> questions = new();
 
         [Inject]
-        public HttpClient Http { get; set; }
+        public required HttpClient Http { get; set; }
 
         protected override async Task OnInitializedAsync()
         {

Blazor/Blazor/Modals/DeleteConfirmation.razor.cs

@@ -9,22 +9,14 @@ namespace Blazor.Modals
     public partial class DeleteConfirmation
     {
         [CascadingParameter]
-        public BlazoredModalInstance ModalInstance { get; set; }
+        public required BlazoredModalInstance ModalInstance { get; set; }
 
         [Inject]
-        public IDataService DataService { get; set; }
+        public required IDataService DataService { get; set; }
 
         [Parameter]
         public int Id { get; set; }
 
-        //private Chapter chapter = new Chapter();
-
-        //protected override async Task OnInitializedAsync()
-     
-        //    // Get the chapter
-        //    chapter = await DataService.GetById(Id);
-        //}
-
         void ConfirmDelete()
         {
             ModalInstance.CloseAsync(ModalResult.Ok(true));

Blazor/Blazor/Models/AdministratorModel.cs

@@ -8,8 +8,8 @@ namespace Blazor.Models;
 public class AdministratorModel 
 {
     public int Id { get; set; }
-    public string Username { get; set; }
-    public string HashedPassword { get; set; }
+    public required string Username { get; set; }
+    public required string HashedPassword { get; set; }
 
     public void HashPassword(string password)
     {

Blazor/Blazor/Models/AnswerModel.cs

@@ -4,8 +4,8 @@ public class AnswerModel
 
 {
     public int Id { get; set; }
-    public string Content { get; set; }
-    public int IdQuestion { get; set; }
+    public string? Content { get; set; }
+    public int? IdQuestion { get; set; }
     public AnswerModel(int id)
     {
         Id = id;

Blazor/Blazor/Models/ChapterModel.cs

@@ -8,6 +8,6 @@ namespace Blazor.Models
 
         [Required(ErrorMessage = "Name is required")]
         [StringLength(50, ErrorMessage = "Name is too long.")]
-        public string Name { get; set; }
+        public required string Name { get; set; }
     }
 }

Blazor/Blazor/Models/PlayerModel.cs

@@ -7,8 +7,8 @@ namespace Blazor.Models;
 public class PlayerModel
 {
     public int Id { get; set; }
-    public string Nickname { get; set; }
-    public string HashedPassword { get; set; }
+    public required string Nickname { get; set; }
+    public required string HashedPassword { get; set; }
 
     public void HashPassword(string password)
     {

Blazor/Blazor/Models/QuestionModel.cs

@@ -3,13 +3,12 @@
 public class QuestionModel
 {
     public int Id { get; set; }
-    public string Content { get; set; }
+    public required string Content { get; set; }
     public int IdChapter { get; set; }
-    public int? IdAnswerGood { get; set; }
+    public int IdAnswerGood { get; set; }
     public int Difficulty { get; set; }
     public int NbFails { get; set; }
 
-
     public void addFails(int nb) { NbFails += nb; }
     public void removeFails(int nb) { NbFails -= nb; }
 }

Blazor/Blazor/Pages/Admins/AddAdministrator.razor

@@ -2,7 +2,6 @@
 @using Blazor.Models
 
 <h3>AddAdministrator</h3>
-
 <EditForm Model="@administratorModel" OnValidSubmit="@HandleValidSubmit">
     <DataAnnotationsValidator />
     <ValidationSummary />

Blazor/Blazor/Pages/Admins/AddAdministrator.razor.cs

@@ -6,7 +6,7 @@ namespace Blazor.Pages.Admins
 {
     public partial class AddAdministrator
     {
-        private AdministratorModel administratorModel = new();
+        private AdministratorModel? administratorModel;
 
         [Inject]
         public required IDataService DataService { get; set; }
@@ -19,6 +19,8 @@ namespace Blazor.Pages.Admins
 
 
         private async Task HandleValidSubmit()
+        {
+            if (administratorModel != null)
             {
                 administratorModel.HashPassword(administratorModel.HashedPassword);
 
@@ -28,7 +30,7 @@ namespace Blazor.Pages.Admins
 
                 var formContent = new FormUrlEncodedContent(formData);
 
-            string apiUri = API.API_URL+"add/administrator/"+API.TOKEN;
+                string apiUri = API.API_URL + "add/administrator/" + API.TOKEN;
 
                 using (var httpClient = new HttpClient())
                 {
@@ -49,4 +51,5 @@ namespace Blazor.Pages.Admins
                 NavigationManager.NavigateTo("administrators");
             }
         }
+    }
 }

Blazor/Blazor/Pages/Admins/Administrators.razor.cs

@@ -41,7 +41,7 @@ public partial class Administrators
 
         var response = Http.GetFromJsonAsync<Administrator[]>(API.API_URL+"administrators/"+API.TOKEN).Result;
 
-        if (!e.CancellationToken.IsCancellationRequested)
+        if (!e.CancellationToken.IsCancellationRequested && response != null)
         {
             administrators = new List<Administrator>(response); // an actual data for the current page
             totalItem = administrators.Count;

Blazor/Blazor/Pages/Admins/EditAdministrator.razor.cs

@@ -10,7 +10,7 @@ namespace Blazor.Pages.Admins
         [Parameter]
         public int Id { get; set; }
 
-        private AdministratorModel administratorModel = new();
+        private AdministratorModel? administratorModel;
 
         [Inject]
         public required IDataService DataService { get; set; }
@@ -40,6 +40,8 @@ namespace Blazor.Pages.Admins
         }
 
         private async Task HandleValidSubmit()
+        {
+            if (administratorModel != null)
             {
                 administratorModel.HashPassword(administratorModel.HashedPassword);
 
@@ -49,7 +51,7 @@ namespace Blazor.Pages.Admins
 
                 var formContent = new FormUrlEncodedContent(formData);
 
-            string apiUri = API.API_URL+"update/administrator/" + administratorModel.Id + "/" + API.TOKEN;
+                string apiUri = API.API_URL + "update/administrator/" + administratorModel.Id + "/" + API.TOKEN;
 
                 using (var httpClient = new HttpClient())
                 {
@@ -65,9 +67,10 @@ namespace Blazor.Pages.Admins
                     }
                 }
 
-            Logger.LogInformation("Admin '{OldAdminModelName}' edited in '{NewAdminModelName}'",OldAdminName,administratorModel.Username);
+                Logger.LogInformation("Admin '{OldAdminModelName}' edited in '{NewAdminModelName}'", OldAdminName, administratorModel.Username);
 
                 NavigationManager.NavigateTo("administrators");
             }
         }
+    }
 }

Blazor/Blazor/Pages/Chapters/AddChapter.razor.cs

@@ -6,7 +6,7 @@ namespace Blazor.Pages.Chapters;
 
 public partial class AddChapter
 {
-    private ChapterModel chapterModel = new();
+    private ChapterModel? chapterModel;
 
     [Inject]
     public required IDataService DataService { get; set; }
@@ -20,6 +20,8 @@ public partial class AddChapter
 
 
     private async Task HandleValidSubmit()
+    {
+        if (chapterModel != null)
         {
             var formData = new List<KeyValuePair<string, string>>();
             formData.Add(new KeyValuePair<string, string>("name", chapterModel.Name));
@@ -27,7 +29,7 @@ public partial class AddChapter
 
             var formContent = new FormUrlEncodedContent(formData);
 
-        string apiUri = API.API_URL+"add/chapter/"+API.TOKEN;
+            string apiUri = API.API_URL + "add/chapter/" + API.TOKEN;
 
             using (var httpClient = new HttpClient())
             {
@@ -43,10 +45,10 @@ public partial class AddChapter
                 }
             }
 
-        Logger.LogInformation("Chapter '{chapterModelName}' added",chapterModel.Name);
+            Logger.LogInformation("Chapter '{chapterModelName}' added", chapterModel.Name);
 
             NavigationManager.NavigateTo("chapters");
-
+        }
     }
 
 }

Blazor/Blazor/Pages/Chapters/EditChapter.razor.cs

@@ -9,7 +9,7 @@ public partial class EditChapter
     [Parameter]
     public int Id { get; set; }
 
-    private ChapterModel chapterModel = new();
+    private ChapterModel? chapterModel;
 
     [Inject]
     public IDataService DataService { get; set; }

Blazor/Blazor/Pages/Players/AddPlayer.razor.cs

@@ -6,7 +6,7 @@ namespace Blazor.Pages.Players
 {
     public partial class AddPlayer
     {
-        private PlayerModel playerModel = new();
+        private PlayerModel? playerModel;
 
         [Inject]
         public required IDataService DataService { get; set; }
@@ -16,6 +16,8 @@ namespace Blazor.Pages.Players
 
 
         private async Task HandleValidSubmit()
+        {
+            if (playerModel != null)
             {
                 playerModel.HashPassword(playerModel.HashedPassword);
 
@@ -25,7 +27,7 @@ namespace Blazor.Pages.Players
 
                 var formContent = new FormUrlEncodedContent(formData);
 
-            string apiUri =API.API_URL+"add/player/"+API.TOKEN;
+                string apiUri = API.API_URL + "add/player/" + API.TOKEN;
 
                 using (var httpClient = new HttpClient())
                 {
@@ -43,4 +45,5 @@ namespace Blazor.Pages.Players
                 NavigationManager.NavigateTo("players");
             }
         }
+    }
 }

Blazor/Blazor/Pages/Players/EditPlayer.razor.cs

@@ -10,7 +10,7 @@ namespace Blazor.Pages.Players
         [Parameter]
         public int Id { get; set; }
 
-        private PlayerModel playerModel = new();
+        private PlayerModel? playerModel;
 
         [Inject]
         public required IDataService DataService { get; set; }

Blazor/Blazor/Pages/Questions/AddQuestion.razor.cs

@@ -9,7 +9,7 @@ namespace Blazor.Pages.Questions
 {
     public partial class AddQuestion
     {
-        private QuestionModel questionModel = new();
+        private QuestionModel? questionModel;
 
         public List<Chapter> chapters = new();
 
@@ -50,12 +50,13 @@ namespace Blazor.Pages.Questions
         protected override async Task OnInitializedAsync()
         {
             var response = Http.GetFromJsonAsync<Chapter[]>(API.API_URL + "chapters/" + API.TOKEN).Result;
-
-            chapters = new List<Chapter>(response);
+            if (response == null) chapters = new List<Chapter>();
+            else chapters = new List<Chapter>(response);
         }
         private async void HandleValidSubmit()
         {
-
+            if (questionModel != null)
+            {
                 await DataService.Add(questionModel);
 
                 var formData = new List<KeyValuePair<string, string>>();
@@ -63,7 +64,7 @@ namespace Blazor.Pages.Questions
                 formData.Add(new KeyValuePair<string, string>("idchapter", questionModel.IdChapter.ToString()));
                 foreach (var answerModel in answerModels)
                 {
-                formData.Add(new KeyValuePair<string, string>($"answercontent{answerModel.Id+1}", answerModel.Content));
+                    formData.Add(new KeyValuePair<string, string>($"answercontent{answerModel.Id + 1}", answerModel.Content));
                 }
                 foreach (var checkbox in checkboxs)
                 {
@@ -77,7 +78,7 @@ namespace Blazor.Pages.Questions
 
                 var formContent = new FormUrlEncodedContent(formData);
 
-            string apiUri = API.API_URL+"add/question/"+API.TOKEN;
+                string apiUri = API.API_URL + "add/question/" + API.TOKEN;
 
                 using (var httpClient = new HttpClient())
                 {
@@ -96,4 +97,5 @@ namespace Blazor.Pages.Questions
                 NavigationManager.NavigateTo("questions");
             }
         }
+    }
 }

Blazor/Blazor/Pages/Questions/EditQuestion.razor.cs

@@ -10,7 +10,7 @@ namespace Blazor.Pages.Questions
         [Parameter]
         public int Id { get; set; }
 
-        private QuestionModel questionModel = new();
+        private QuestionModel? questionModel;
 
         [Inject]
         public required IDataService DataService { get; set; }