reduce complexity for CheckWrongCompletedLines

11 months ago · 317dbeaa83
parent 35134c2bbc
commit 317dbeaa83
1 changed files with 7 additions and 13 deletions
--- a/Qwirkle/QwirkleClassLibrary/Games/Game.cs
+++ b/Qwirkle/QwirkleClassLibrary/Games/Game.cs
@ -474,7 +474,7 @@ namespace QwirkleClassLibrary.Games
                    previousTilesFound = true;
                }
                
-                if (cellUsed.Contains(extendedCell))
+                if (cellUsed.Contains(extendedCell!))
                {
                    previousTilesFound = true;
                }
@ -570,28 +570,22 @@ namespace QwirkleClassLibrary.Games
                {
                    nbTiles++;

-                    foreach (var t in checkdoubles)
-                    {
-                        if (t.CompareTo(extendedCell.Tile) == 0)
+                    if(checkdoubles.Any(t => t.CompareTo(extendedCell.Tile) == 0))
                    {
                        return false;
                    }
-                    }

                    checkdoubles.Add(extendedCell.Tile);
                }

-                if (extendedCell2?.Tile != null)
+                if (extendedCell2?.Tile == null) continue;
                {
                    nbTiles++;

-                    foreach (var t in checkdoubles)
-                    {
-                        if (t.CompareTo(extendedCell2.Tile) == 0)
+                    if (checkdoubles.Any(t => t.CompareTo(extendedCell2.Tile) == 0))
                    {
                        return false;
                    }
-                    }
                    
                    checkdoubles.Add(extendedCell2.Tile);
                }